From patchwork Mon Oct 5 07:15:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nipun Gupta X-Patchwork-Id: 314037 Delivered-To: patch@linaro.org Received: by 2002:a92:d603:0:0:0:0:0 with SMTP id w3csp1054660ilm; Mon, 5 Oct 2020 00:15:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySC5D85lIUcn2sfXeisadM5O++crbIn2a/Y3B6Xm7Cahzha5jsGODGFdPDQkL/1x4oUe5O X-Received: by 2002:a17:906:ad94:: with SMTP id la20mr13874812ejb.522.1601882139040; Mon, 05 Oct 2020 00:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601882139; cv=none; d=google.com; s=arc-20160816; b=rRNRrHEZQGOLSUQlqzFhGIGWk2rLM+Srr+DKt33u3UknRVg7PQqpOIlvMGM+Oq+cK0 jDaZqFFyC7ZOuXKSiUyQEM+MY5yycCVXmRJbdavP0DgUQMDgZFcmBLntLlfDN0BYHUTO 0NYaKDK077Gl/URjfOp0cG/rbDrnrkTLasiiBr76fZ4W4TB+NLqa1RukxVdqyR+YBpsv rFbob69wJusxBYXe0hGeW/d5Fq4sAAkuINl1k1/99Oi0LIR4cknd0eHc5GeH4LQI2hLi LLXg5qoxtd8Gth6heAxR8mQvuxbfO7jvqpAiQX5XelfYaXgYRGlaoMVu/wg5NEOMWpsd PvFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=53rRNM+8dwfJU7yeUv9Ej3RGnZATqeFAAcaufNF7zY4=; b=MnSKoivK5YDJEY/lCxur8iatsOlkUYKEZVGBCSfZgkKyAX3HUgEeZq2RQd49MfQ7Iw mVjfJhmy0eKMvKjmNhHEnxd2Kg1qel4St0xDzNTaJ0HWIXk3kUOVbuEZNVhgwUckBbh5 go+f1EbRka6I4vy/AJ87TW+wtaMHCeRnLQF74meOh3lrGHfzmfl+IQezUg/hoQg2Xy1G HYvDwOVt11+QpAIXnRLAzD/kYnlEc/uNF9wHIf+oPe9Pd6tIeor0yK2bqNohff9X6OEq 3RAeg6nd5E+JMk2QFok0IjrtFNTPkgJXAyo+xGEftJm1RXR2avBhAr685koBcWD3gQ15 6jJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id u23si6693674eja.295.2020.10.05.00.15.38; Mon, 05 Oct 2020 00:15:39 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15B531B667; Mon, 5 Oct 2020 09:15:18 +0200 (CEST) Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by dpdk.org (Postfix) with ESMTP id 2FFC31C01 for ; Mon, 5 Oct 2020 09:15:16 +0200 (CEST) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id EF5CE1A07B8; Mon, 5 Oct 2020 09:15:14 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 85BF21A0754; Mon, 5 Oct 2020 09:15:11 +0200 (CEST) Received: from lsv03196.swis.in-blr01.nxp.com (lsv03196.swis.in-blr01.nxp.com [92.120.146.192]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 4DF3E402C7; Mon, 5 Oct 2020 09:15:07 +0200 (CEST) From: nipun.gupta@nxp.com To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, arybchenko@solarflare.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, rohit.raj@nxp.com, Nipun Gupta Date: Mon, 5 Oct 2020 12:45:05 +0530 Message-Id: <20201005071506.28861-2-nipun.gupta@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201005071506.28861-1-nipun.gupta@nxp.com> References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH 2/3 v2] net/dpaa: support RX offload for error packet drop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Nipun Gupta This patch supports RX offload capability DEV_RX_OFFLOAD_ERR_PKT_DROP, to drop error packets in the hardware Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/fman/fman_hw.c | 7 ++++++- drivers/net/dpaa/dpaa_ethdev.c | 18 ++++++++++++++---- 2 files changed, 20 insertions(+), 5 deletions(-) -- 2.17.1 diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c index 4ab49f785..40e4e0000 100644 --- a/drivers/bus/dpaa/base/fman/fman_hw.c +++ b/drivers/bus/dpaa/base/fman/fman_hw.c @@ -597,7 +597,12 @@ void fman_if_discard_rx_errors(struct fman_if *fm_if) { struct __fman_if *__if = container_of(fm_if, struct __fman_if, __if); - unsigned int *fmbm_rfsdm, *fmbm_rfsem; + unsigned int *fmbm_rcfg, *fmbm_rfsdm, *fmbm_rfsem; + unsigned int val; + + fmbm_rcfg = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rcfg; + val = in_be32(fmbm_rcfg); + out_be32(fmbm_rcfg, val & ~BMI_PORT_CFG_FDOVR); fmbm_rfsem = &((struct rx_bmi_regs *)__if->bmi_map)->fmbm_rfsem; out_be32(fmbm_rfsem, 0); diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 1f94fc9b9..39f673db5 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -52,7 +52,8 @@ /* Supported Rx offloads */ static uint64_t dev_rx_offloads_sup = DEV_RX_OFFLOAD_JUMBO_FRAME | - DEV_RX_OFFLOAD_SCATTER; + DEV_RX_OFFLOAD_SCATTER | + DEV_RX_OFFLOAD_ERR_PKT_DROP; /* Rx offloads which cannot be disabled */ static uint64_t dev_rx_offloads_nodis = @@ -262,6 +263,18 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev) dev->data->scattered_rx = 1; } + if (!(rx_offloads & DEV_RX_OFFLOAD_ERR_PKT_DROP)) { + struct dpaa_if *dpaa_intf = dev->data->dev_private; + struct qman_fq *rxq = &dpaa_intf->rx_queues[0]; + + DPAA_PMD_DEBUG("error packets will not be droppped on hw"); + fman_if_receive_rx_errors(fif, FM_FD_RX_STATUS_ERR_MASK); + fman_if_set_err_fqid(fif, rxq->fqid); + } else { + DPAA_PMD_DEBUG("error packets will be droppped on hw"); + fman_if_discard_rx_errors(fif); + } + if (!(default_q || fmc_q)) { if (dpaa_fm_config(dev, eth_conf->rx_adv_conf.rss_conf.rss_hf)) { @@ -2031,9 +2044,6 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) fman_intf->mac_addr.addr_bytes[5]); if (!fman_intf->is_shared_mac) { - /* Configure error packet handling */ - fman_if_receive_rx_errors(fman_intf, - FM_FD_RX_STATUS_ERR_MASK); /* Disable RX mode */ fman_if_disable_rx(fman_intf); /* Disable promiscuous mode */