From patchwork Mon Sep 28 19:03:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 313682 Delivered-To: patch@linaro.org Received: by 2002:a92:5ad1:0:0:0:0:0 with SMTP id b78csp3546100ilg; Mon, 28 Sep 2020 12:05:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAP2qu0oyntT9HCJ2zqdUxjxegkYDkrcrx4bpHbrbnLpmlBqzEWvC4Or2/9QinyVbr1z0j X-Received: by 2002:a17:906:c1d7:: with SMTP id bw23mr222292ejb.171.1601319933566; Mon, 28 Sep 2020 12:05:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601319933; cv=none; d=google.com; s=arc-20160816; b=AeNhf9PtQxQa1BPY4b8S/SF3loiYyZalTUt6AGgtbDu8x+R89/oydvwW4M9y0fm9e7 I2vDmSwetqUgqqGc5/1PH8Ef7JwqwlNw0E29D3szRr/ppvo7U6M7eTi2qvAZkyKtNNvu eKCtXmkdpYox6SCZuvHfKn+jwltZiDFo7E/OLL+XYxQ04HfIW6nbgiPCIG9nprjT9EGM hjWn2cNYs87NDDcdV9caK1BXt82jadihR4hla5N/0MDdznM/pHjVZPxALslko+yx5iMc gSjilh9SsvGzsJ8UQ8N5pukEGC4LgUjlC9/s/MmZ9HVS6Lm4TO093B3rlvbbb9EZ2pQD 2pUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=GU9dARXNt9sMTonaO/Rw04cQ7AOmn/Pox4JW04ehysU=; b=mHlFqvBNd7NXNhiwfqtVfrwfDZW/D2tRZQbC0f0q7jy7DSR+f0F9ueDut2X4OwD4Zq n1k+9NdekL0Z5geZqcRyzftvfV6GBqyszgoVjMN4t2nvulUIaa7daJMOb1Nsbi3HAdVU NjLNS231VZxtDRJKQsUkutjRiPOu/u8ZBWzjXg89XbhIf4R0tgjFHEAt3/u4bJoFt6VV vaLZh5zbEkW6aiw4KWve9ZIUjEks6LwcRoZ70M5nBCQgjvkPskzAF3oUuIoa2hOaAmqN IflagnyTkPQzZVspHOT/+MitAXdUYDKY/V1wEZu+WxZglRHgKak306tx4gQ4EtLL+2bf rjdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id o21si1118714ejg.255.2020.09.28.12.05.33; Mon, 28 Sep 2020 12:05:33 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9CF711D6C8; Mon, 28 Sep 2020 21:04:15 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 014431D68D for ; Mon, 28 Sep 2020 21:04:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52EA81063; Mon, 28 Sep 2020 12:04:07 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 41AC43F70D; Mon, 28 Sep 2020 12:04:07 -0700 (PDT) From: Honnappa Nagarahalli To: dev@dpdk.org, honnappa.nagarahalli@arm.com, phil.yang@arm.com, jgrajcia@cisco.com, ferruh.yigit@intel.com Cc: nd@arm.com Date: Mon, 28 Sep 2020 14:03:32 -0500 Message-Id: <20200928190334.40624-6-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200928190334.40624-1-honnappa.nagarahalli@arm.com> References: <20200921192254.20560-1-honnappa.nagarahalli@arm.com> <20200928190334.40624-1-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH v2 6/8] net/memif: remove extra check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" eth_memif_tx_zc function is called only for S2M rings. Remove additional code for M2S rings in this function. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- drivers/net/memif/rte_eth_memif.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 404c86ae8..9babd073a 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -735,7 +735,6 @@ eth_memif_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) rte_eth_devices[mq->in_port].process_private; memif_ring_t *ring = memif_get_ring_from_queue(proc_private, mq); uint16_t slot, n_free, ring_size, mask, n_tx_pkts = 0; - memif_ring_type_t type = mq->type; struct rte_eth_link link; if (unlikely((pmd->flags & ETH_MEMIF_FLAG_CONNECTED) == 0)) @@ -812,11 +811,8 @@ eth_memif_tx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) } no_free_slots: - /* update ring pointers */ - if (type == MEMIF_RING_S2M) - __atomic_store_n(&ring->head, slot, __ATOMIC_RELEASE); - else - __atomic_store_n(&ring->tail, slot, __ATOMIC_RELEASE); + /* ring type always MEMIF_RING_S2M */ + __atomic_store_n(&ring->head, slot, __ATOMIC_RELEASE); /* Send interrupt, if enabled. */ if ((ring->flags & MEMIF_RING_FLAG_MASK_INT) == 0) {