From patchwork Fri May 8 13:02:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 186344 Delivered-To: patch@linaro.org Received: by 2002:a92:8d81:0:0:0:0:0 with SMTP id w1csp4157904ill; Fri, 8 May 2020 06:04:43 -0700 (PDT) X-Google-Smtp-Source: APiQypIlEB1uddKWcX0FQiDGhuctQiAKmOw+401nd1uxfy1Br1nu4HTDLW0Uym4/4tBDi0nrrodW X-Received: by 2002:a17:906:3e44:: with SMTP id t4mr1805446eji.337.1588943083570; Fri, 08 May 2020 06:04:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588943083; cv=none; d=google.com; s=arc-20160816; b=BslvpTLIGdAQkXsYuCJo0/97z4mLuTdNNx2SCqmLr2UBbc7S8MTl3C9p/LszeHtyC3 gN7g4sdKbvvIOJ+XBCsnccNeWxJ+2F7KRFpgp8gbwpV6pPXiYbPQKnj0ksZ5BkFOsjsL YyM8lRn0LmE2aTAe61sPiBt/e5Gi5mzG1X5wz8Ytk7LTX8HiQR9u0yvMFDQKcTOsF8LX P1STAn3wviN/NY8/lXQtL3/PM8N5Ioof0EH2pjjZbg29XwHRwbF0SmiIrv/uHXYylxi8 1+18ihvD+DNgXJq2Si3VSIzJmXIwzIuosimOjuOdKSzlykEyUKycn5QCsOuGADHvXv97 rw0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=xYdBpebDXG5p7OatYIKDc5NMhbUi7AJTu3fyxRc/ras=; b=udbqTNjpubfJtdoubCEAaTMcKZvf/7pJ3RBHzeGgh3bz0yjzPcuUL1y1sSv49PVzSA PAq0PQNolphu+WumJtRdknCsrIZDuIBgnEWLNy5iE7v54Tb61JsuwhCNynTQyBwEg6Hh pKcZBJnT8rQXL0u8wOfRsp4pv0P6WbqBKSSOVxVwibjZuJ61fhIJCIfiCynDYhlOhu0s QcL6Ms2WNDQmp3WDm5ie9CXZRmpfF9nH0vI7lcIL/e+ENqy4qDsBXABE7G6EQkbLFTmT 9Ijqr9pSDcERcylTeWOmfzoCX+D90m/rzi/s2PhyS35Tspfcyr/yILgmTYU/v6bvfDdL +HFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id pv20si909719ejb.295.2020.05.08.06.04.43; Fri, 08 May 2020 06:04:43 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 754E31DB80; Fri, 8 May 2020 15:04:29 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by dpdk.org (Postfix) with ESMTP id 3095A1DB11; Fri, 8 May 2020 15:04:26 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1032320100F; Fri, 8 May 2020 15:04:26 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 0C6EA201389; Fri, 8 May 2020 15:04:24 +0200 (CEST) Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.133.63]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 19DAF4030E; Fri, 8 May 2020 21:04:21 +0800 (SGT) From: Hemant Agrawal To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org, Rohit Raj Date: Fri, 8 May 2020 18:32:03 +0530 Message-Id: <20200508130211.14334-3-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508130211.14334-1-hemant.agrawal@nxp.com> References: <20200507104645.31990-1-hemant.agrawal@nxp.com> <20200508130211.14334-1-hemant.agrawal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v6 02/10] net/dpaa2: fix 10G port negotiation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rohit Raj Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate was not being updated in device link params, thus having the incorrect link speed in status (as 0). Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Cc: stable@dpdk.org Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.17.1 diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2cde55e7cc..4fc550a885 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER) dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK); - /* update the current status */ - dpaa2_dev_link_update(dev, 0); - return 0; } @@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) /* changing tx burst function to start enqueues */ dev->tx_pkt_burst = dpaa2_dev_tx; dev->data->dev_link.link_status = state.up; + dev->data->dev_link.link_speed = state.rate; if (state.up) DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);