From patchwork Thu Oct 17 12:44:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nipun Gupta X-Patchwork-Id: 176601 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp887822ill; Thu, 17 Oct 2019 06:01:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1kfuOXC74V41fuQu11N1XMU6ex5+ra4njx01VWT21EgeBXtdGkE98ZzL0GfCF5TV5RLJc X-Received: by 2002:a17:906:184e:: with SMTP id w14mr3345685eje.10.1571317278476; Thu, 17 Oct 2019 06:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571317278; cv=none; d=google.com; s=arc-20160816; b=OP0xcayXfQsk8ZTgc0h5/hvpZKzL82Cf5ZG/gcqd9l9NAELPtXpjpbRVdW9JSKODuc xj+rQaqcZzxJGVhIdsNMq9A9MJrUgKFiXRVHncHcUfM4ahWU77inrWxjpjxRxEO58r3A x2t2q9U2p7mG6LFTXours6AB+1grCto8pBHDCZAUt75DaWqGH2/wCuPucwhr8I4DfTff rvGkYtAwXwRzZMhugF1bNbZSpqWYy7qsca/RQy3nrWjF0QGAR32iakENoUDkYIEV+S7+ /yURwpy+XkQ4XdxCFmVCFKTVAKX9Gmp8SZYMA0vZMiCAYs81yoPcYPWPHT9RkbdVrgzK 8FHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=XMegJTQVwCOmgSW6+YxbGfzTtqdRLOfdrwVo05QnLE0=; b=zXV1b/pKUKDD0+wscCHQcw23lx6Uy2oJ+uhaW6xwxMbEpNyox42SmkA36EKoA/hCKR 2sUNuutl57alKj3JE8HX9LIzxqkht19wwio3g8SAdQl/7a8/2OB4duuKxn5Bi/CEa1WX n5EuG7l/S2jZWqHtN6qkVZMToz5YxrksTwg6oNDNBD2fAo5XhLpEst7ODN/OmQxXw4jG Z6DkeCeed/NHsDP1AjuIJvTOLZi+32u2zNg9Hbrn3fEWM3XBN9cWCPXTdjpx07Qk/lw3 SODHHKO3yNPHNWWzv8kACXKaYzxqsYtSoq2n3mYi35MqiD6O4BvfnxbgXq4R20OPK7cP 8xEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id v13si1394293eds.375.2019.10.17.06.01.17; Thu, 17 Oct 2019 06:01:18 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74CB61EA0D; Thu, 17 Oct 2019 15:00:22 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by dpdk.org (Postfix) with ESMTP id 727241E9AB for ; Thu, 17 Oct 2019 14:59:55 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 540BE20067B; Thu, 17 Oct 2019 14:59:55 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A6DD520011A; Thu, 17 Oct 2019 14:59:52 +0200 (CEST) Received: from GDB1.ap.freescale.net (gdb1.ap.freescale.net [10.232.132.179]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 5DB324031F; Thu, 17 Oct 2019 20:59:49 +0800 (SGT) From: Nipun Gupta To: dev@dpdk.org Cc: ferruh.yigit@intel.com, hemant.agrawal@nxp.com, sachin.saxena@nxp.com, Shreyansh Jain Date: Thu, 17 Oct 2019 18:14:03 +0530 Message-Id: <20191017124403.26734-10-nipun.gupta@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191017124403.26734-1-nipun.gupta@nxp.com> References: <20191011054657.21931-1-nipun.gupta@nxp.com> <20191017124403.26734-1-nipun.gupta@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH 9/9 v2] bus/fslmc: sanitize device name parsing for clarity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shreyansh Jain remove unnecessary dup and free Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index 4116552c6..b3e964aa9 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -235,8 +235,9 @@ rte_fslmc_parse(const char *name, void *addr) { uint16_t dev_id; char *t_ptr; - char *sep = NULL; + const char *sep; uint8_t sep_exists = 0; + int ret = -1; DPAA2_BUS_DEBUG("Parsing dev=(%s)", name); @@ -266,10 +267,11 @@ rte_fslmc_parse(const char *name, void *addr) } else { DPAA2_BUS_DEBUG("Invalid device for matching (%s).", name); + ret = -EINVAL; goto err_out; } } else - sep = strdup(name); + sep = name; jump_out: /* Validate device name */ @@ -283,23 +285,23 @@ rte_fslmc_parse(const char *name, void *addr) strncmp("dpdmai", sep, 6) && strncmp("dpdmux", sep, 6)) { DPAA2_BUS_DEBUG("Unknown or unsupported device (%s)", sep); + ret = -EINVAL; goto err_out; } t_ptr = strchr(sep, '.'); if (!t_ptr || sscanf(t_ptr + 1, "%hu", &dev_id) != 1) { DPAA2_BUS_ERR("Missing device id in device name (%s)", sep); + ret = -EINVAL; goto err_out; } if (addr) strcpy(addr, sep); - return 0; + ret = 0; err_out: - if (!sep_exists && sep) - free(sep); - return -EINVAL; + return ret; } static int