From patchwork Tue Oct 23 04:22:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 149411 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp220949ljp; Mon, 22 Oct 2018 21:22:39 -0700 (PDT) X-Google-Smtp-Source: AJdET5dDw7esqEKAVzJtkZh2DmJ4kk97uV8gRRwp8+62jhGVZK3aAN4ZRQYGOyg/JmKch4UvrYSp X-Received: by 2002:a5d:4550:: with SMTP id p16-v6mr14950265wrr.234.1540268559536; Mon, 22 Oct 2018 21:22:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540268559; cv=none; d=google.com; s=arc-20160816; b=eYX73/PmJs0873lheKiMDO+cZaHEzP0XFFTY4YTNjOYltH/XGGrPHjQdG+4vBX+m+U PhEl92BuKCRzck/u0nv3IEDfAX9W1aP2cbQZqeXCMf7OLZ4Z5PD1843gpv/yfF7aNet8 vCmBICrY7Skxt+46bzW3aczu9MkH5kGtPFoKo5S7ANz6IrVyJJLL2KJuJ3EO+JytLH5F m4iu93kTaEuyqcikcKauacoFv0knBWkQVdWSOjCsaeAaFZD9h/Wj2kWJ3eshv1LobtTc B6crZPr8DlFVEd8gCW50LakVnd1PxodrvvRqCtvpJiy/UIvN8Cek6OL20i2shXVCUNQ3 0HZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=AsiinWjO5/R1PwZJHzYvb6aSFnCxkRFT2SXWVhhb38k=; b=MD0xun6oSofl2iu9AxGea7V7YAjGYlPrP2ZTLawADSZI27FUZcLi+hiy4BVPh7g37H HkkxsnqNBvXY4PD40IxIakAvT/RmN5uogqdVHgA5IRPNk5+FqcXazOlSnqLEF1+TdK1K S9BAL8pNV2dHzmfjuQsjYZMuFuAVmaD/QuCFQnJjSNFtczmTYrj1h4n49f54+zH6s6sd SLNQtziLd/1Ah+dmbWSiqBE4GHZYQTk1zZ0lx0E6CW4hDSGIG4lr+G7ug3OdX/TX4rMb 9O8vd4Igibfhq0kHwV/Q00L8YHBMjmMdKyy2C71wZGc38fHKBswg9RI63CLsQX/FBojN rnrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id d28-v6si35503wrc.239.2018.10.22.21.22.39; Mon, 22 Oct 2018 21:22:39 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCE5F1B1F5; Tue, 23 Oct 2018 06:22:22 +0200 (CEST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 3EF2A1B1E3 for ; Tue, 23 Oct 2018 06:22:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F002341; Mon, 22 Oct 2018 21:22:17 -0700 (PDT) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.14.139]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 296453F5D3; Mon, 22 Oct 2018 21:22:17 -0700 (PDT) From: Honnappa Nagarahalli To: bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com Cc: dev@dpdk.org, yipeng1.wang@intel.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com, dharmik.thakkar@arm.com, nd@arm.com Date: Mon, 22 Oct 2018 23:22:02 -0500 Message-Id: <1540268524-126673-4-git-send-email-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> References: <1540268524-126673-1-git-send-email-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH v5 3/5] hash: fix key store element alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix the key store array element alignment such that every array element is aligned on KEY_ALIGNMENT boundary. This is required to make 'pdata' in 'struct rte_hash_key' align on its natural boundary for atomic load/store. Fixes: 473d1bebce43 ("hash: allow to store data in hash table") Cc: Pablo de Lara Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl Reviewed-by: Steve Capper Reviewed-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 4 +++- lib/librte_hash/rte_cuckoo_hash.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.7.4 Acked-by: Bruce Richardson diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index e087393..d79ba68 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -279,7 +279,9 @@ rte_hash_create(const struct rte_hash_parameters *params) rte_ring_sp_enqueue(r_ext, (void *)((uintptr_t) i)); } - const uint32_t key_entry_size = sizeof(struct rte_hash_key) + params->key_len; + const uint32_t key_entry_size = + RTE_ALIGN(sizeof(struct rte_hash_key) + params->key_len, + KEY_ALIGNMENT); const uint64_t key_tbl_size = (uint64_t) key_entry_size * num_key_slots; k = rte_zmalloc_socket(NULL, key_tbl_size, diff --git a/lib/librte_hash/rte_cuckoo_hash.h b/lib/librte_hash/rte_cuckoo_hash.h index ff95181..601b2ce 100644 --- a/lib/librte_hash/rte_cuckoo_hash.h +++ b/lib/librte_hash/rte_cuckoo_hash.h @@ -123,7 +123,7 @@ struct rte_hash_key { }; /* Variable key size */ char key[0]; -} __attribute__((aligned(KEY_ALIGNMENT))); +}; /* All different signature compare functions */ enum rte_hash_sig_compare_function {