From patchwork Wed Jan 10 10:46:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 124059 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5178490qgn; Wed, 10 Jan 2018 03:55:08 -0800 (PST) X-Google-Smtp-Source: ACJfBovxvt1jRa8EjZAUCNQeOxVvDuanZ3Qaaz0hzjjpjlxcXNMtldRUbTFhIc3UogpBkHeWxuqd X-Received: by 10.223.161.219 with SMTP id v27mr15833095wrv.165.1515585307932; Wed, 10 Jan 2018 03:55:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515585307; cv=none; d=google.com; s=arc-20160816; b=aC2SbgGno6nDZp5gKdLsd9bnyfxJjhPZcsBkhWgEKMItWnvjDfYrDq+lztCksMIS6P 3nAeImXvJkVF+Nb3UeoZ5tsyNpXB901ssXX2nlQ/lQFLiuLGgUpfL2ol0HRey8sgHNef muAIpz1bN/DPj582nypvQAVoeIlL4H9lf/hy1D9wYjNMTR3HEGlw500Cybtr4r7RUY1O fszL1vRuU4A1ib7bdaVcnolCOwjoNK+4xktPpAnjDpHDfd3kNDATA0M0bIidLD552kEd NEUhHx4TAMe39B3MtlysM34vkNTuuI3QyJDn0L2TZQTrv9To5xhvYtCFgbCIsNk9u8aY bV9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=BWn7wy7/2GSVvcUpErvl8ZydxbDpu7AOq8kGJ5f2OjE=; b=g//4LvJDJ7V2CDPG9FRvFW12Sz06F48+HAEPMIE/eqmLJ/KHbZFDuMVUhGgseWeIET MFEWy7zmJjjH99UaUUyg0Wv5pAp9ui03QRwQFlR3RTWY6C1LPTvgLh4XrEOimit4NJGv BR1+6IDhioUzEP5QOTX69AgPywr4k6ANvfgbF55AKriBERAhtuc25ThdXUy8r7WyMIAd Z2w3kSkynT4uPdWzGg5t5+9XoLxNKpIwBv+DQtBBkaoAeD6l4mATt3mo8ZzFRmWfL2n9 1ejwgoclthz4/e/oRSt4L8/CiUmjwqHoQvQQ3bWjtEKVSLLEfYZ77JWmtSzT13RDijRq CKiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id l25si13056202wrb.479.2018.01.10.03.55.07; Wed, 10 Jan 2018 03:55:07 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9181A1B289; Wed, 10 Jan 2018 12:51:15 +0100 (CET) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0087.outbound.protection.outlook.com [104.47.33.87]) by dpdk.org (Postfix) with ESMTP id 0B2C41B1C6; Wed, 10 Jan 2018 11:47:55 +0100 (CET) Received: from DM5PR03CA0059.namprd03.prod.outlook.com (2603:10b6:4:3b::48) by SN2PR03MB2365.namprd03.prod.outlook.com (2603:10b6:804:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 10:47:53 +0000 Received: from BN1AFFO11FD025.protection.gbl (2a01:111:f400:7c10::119) by DM5PR03CA0059.outlook.office365.com (2603:10b6:4:3b::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Wed, 10 Jan 2018 10:47:53 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD025.mail.protection.outlook.com (10.58.52.85) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Wed, 10 Jan 2018 10:47:19 +0000 Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.134.28]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0AAljSJ007124; Wed, 10 Jan 2018 03:47:48 -0700 From: Hemant Agrawal To: CC: , , Date: Wed, 10 Jan 2018 16:16:23 +0530 Message-ID: <1515581201-29784-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515581201-29784-1-git-send-email-hemant.agrawal@nxp.com> References: <1515504186-13587-1-git-send-email-hemant.agrawal@nxp.com> <1515581201-29784-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131600548418731185; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(86362001)(6916009)(5660300001)(2950100002)(6666003)(81166006)(97736004)(36756003)(85426001)(8676002)(498600001)(81156014)(48376002)(76176011)(51416003)(4326008)(53936002)(106466001)(104016004)(8936002)(77096006)(47776003)(2351001)(54906003)(50466002)(16586007)(305945005)(50226002)(8656006)(356003)(2906002)(105606002)(68736007)(316002)(296002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2365; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD025; 1:sAlbG+y4/opckrLJyHjlsvwHA0t5js1Zx6CsAAH4jD0tWtYv4eN4TpfnDhakg4SO9CBMK96WTjQ+1niVLPcqaQSOdkcv6imsYnRfu0+sNmcV8wzqj3uCk55BoX6ISm/3 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66768a6e-1c7f-4cd1-bcb1-08d558178735 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:SN2PR03MB2365; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 3:Xhr+4ijOAzf9pYK2z9Ag8k9LsqczfrCarQSjOuo+Nxo1bZA2Pmf2VQ6mvCI1D1bgttvE8/weWExEyn5QI/h0ijmOQB/IRzjFO9xM+5OPkws8XhYK0eXGb8vyfGAgJT6Dpz5RM8wxLAjfr+rr8F/oAO1H8jnhzON0DIApBdAOg3XhaFxRcJARTi0JzIIP9JWLxJzHOtVRx8iK7tTMQokO72M1pGqRUbO06VYAFxoS1hjAt+0CgKCjdqhTJvzPYyjKXwl3x3nnq6dGjC2U0fPctVZa3KT8um1e5AsVa1025zTwQisqWzKpEW5Teevmzlfli80pU2+V35HVDjsaJXQgSUH03OwwWV5AlA9f9etJqNg=; 25:Q5qX0qJdVifaSVEM2QlfOjlIpkBBMBLP3xHDVGq43U720VeSnAUiLtjAnPbE6i64oPSIbw9RspZbJCSPnziINU7nE6CUDSROI5ZAM6VfQaXEmTsLd4beRs63c/4HVbq0Z1HAURRC5mcDr2X3cu8M/l1wGNIPMS9beLy8XN8EFSh53cbbzMXIRCr1y5D3riNrJFr5P8zLbXzpH52MUaohgNvyjBBwHW7Equ7EUxDKvssa+cHPFpWrYudTsLR6QZF+Uo4GduvklaHH0vKwtHq1l2KxiA/gYETYmxLex5h+4NzRqowCdd5AZYe+tAA9mgYid0pdXoOiRilKpKayA17+6Q== X-MS-TrafficTypeDiagnostic: SN2PR03MB2365: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 31:6mUw4c5FF1kyAl5MYf2+Jgv0KTpRXBmrrvetUynkbT0aBdoU62bIRNSszVHtxy7W+IyRWvJWx+yfM0y+jkmP0JEOm740IXBUDRs1HYZ5PnLO7Y+T2uytCAfmklKbcaRmOz1aQeBHTLN4Vq7Mul82bXJEUHbMkLT95MY36dxTksXWFg7NkC8aelI2dC/SMRvkQxhe5Zy4f6UazvnYvsW03UbBN1FGuVhl0t06pLma2lA=; 4:UOYPDQ2+cmFFzTQp0Y/1Q2gyFRlt45tLH+ox8D7liC4omBD92LPVpw/sNyzTxcXDbGmUTO8igTomSyzjvztUcmNQuBDhrBBn93wvI059rr7Qav3z8hmflyeIO436NmhE9vnE3kyumEbqgEzguMJHyUlbH3LgskoYSDVWXqs2xZLDuf6ZeMQRuqsgExmI387LBvz7LZx7ve+EYqXy+OZFa8GfL4h2lYVOIBmI3nCGeLZIgLRUOF7kNzvgMMp2Nt+9wpPiLxKkrHOJI6txp4QUZ1wI0mmpz2QaocFLTaGzjvsiyJKIU6ddvMG2IzBxqSfp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231023)(944510075)(944921075)(946801075)(946901075)(10201501046)(6055026)(6096035)(20161123559100)(201703131430075)(201703131520075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(20161123565025)(20161123556025)(20161123561025)(201708071742011); SRVR:SN2PR03MB2365; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:SN2PR03MB2365; X-Forefront-PRVS: 0548586081 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR03MB2365; 23:RlovgzUQphbzWohTTn9sCaAlbfxrB5So2rXKgFwl/?= oHuZnZL7yEvvrYTBoM9KQje2OD+sJyXYMz/fCUVlhjnsIN/lMSUmCygBs2+GZ8cYYg7gz61mK1lYbecZ+Hm3X3t/q2HVu5jQP7VNNeCZUnstIeRJQPmCqer8sAQL/q+S8d+iLFJIb0r7DbYk5VwCQ7ocMoHwa2iFa9ar/3TxDHGTguQ71OyaSB/gnSkxOvQQE0RKbxLoVuI6Jsuy+dLPA3sqcM5LPzC/S9tdPLbpDP6FwyaYqCE+unmIhou2GlLJb3gs5WIfq4iU+yaV5QxLKD4LGR78ayG0RycrwCoq0BpkgDganNkSJeY+WagJe31GRSxUDp5SoBrRIt5vBEFj2B5nYACh8owfdjObOtBGbJjDDUaJCjw3pMNnk7QW7JKzSc0KS3ryRjTiQFwHs3NTnvOJGnP/uruwCtjMRTi5ASacx4ADZ2b9jexZTRjrBpgegZNweqQD3v390TuoqbAw3Dq7LAxtNfAsqeCG2PyzlkXUpyebJGiRE3uxQvuohZfk9+MZ6XxW/YtgWw3SmKhjIP5kTgboSKY37hvMB66sNLVzWA2MmBynYAMLJKGnZu9opRwkaTS7zyB5IR1j5DrjGpwqd499tVFVFQq0WBDI2d6/ou4vaH26dXIQrJbu3C5ybnfYC9xU9lUmKTnfwBZUI+1iQgdsSl6iJ7nouBZlm2DlXB48AXo3aCxxzylmi6PfU1fc84qNKFW2zcQp9AHlR2cItHi8pqWrsNXz9TirqOAJMHH4A9atcUo2YQLisfRJ6YwjnWgf8bb8UdBzERPDFd9x6wdRA+0XY8ECxUYjI9dilq0sUeFFcwxZVNUtB5BHzEBKXVkwwj6C6RjYzptEWLqznQiQm+a+rAnlJ+yTiOdr1ZjA9RiUpIWSO10bvRS2vFsPBHcVaCgJwXZWAnfendQxeeKUqDukWQH2LVXKAc7ltl7aeHZzcThNtUC0CWlRFRMr8Y968T92dtdey1NxeeOHmZtzyXknHJbEnCUjizY9Pnn2ZuDXnxCi3kIAbwFWGT7ygqmPHwa6839JbMxVymn X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 6:d0mNW/q9HY9xpVo4GaxTrW2Gvjvg/5lBfRKPF6MRzwz9a9eNbIB1NjmBF1hqCtro3/uREHkz/RLQkmXS7/4hDThqdlVEz7Sgaf8RcSGvfHz4+TPzQooJt46Txc7pmN7YmZjKQ8eSXxry/01Jep33PZXmNXhwH/T7JYYjy4573+B6OHHuujokMTKHE8c17jIs7LkD8fejxq0j4CxIfc53UMxoRqY/1lZ92VkQ1mHg1kV+d2lTeiQu6mlnVoE30YkTu4p339lOCLtDhiN1wvxxz5KWrwIS5XUTb5Km6ZAND9AwaaKqtY9iJx3BG7Ae2LoMwjJS2veWCxVrkyFpwCuUD0KZcYjsNxZZ26uv8FaNh/0=; 5:3sV2wWQpMAgB3Uio1DnNQf1LSLzgjUVFqnF4MmpJGbBCP+3eerC161KLvR5DN9ryxYp+53nhcyMu+6e3j440p70l9VxtSdTQy5tpiiB1/XDWbt2DRLnyG8QD7WYXFWVEEKhVP58vL2BcxwYoXUe5pnbmdvhnsRuq8wf0oHji9/Y=; 24:7e7TAauLy2A+CbWJj8OCkhCNCg9/k8650NAiCZkeXgYSI1x2wv6rO1JBxqxeVz4uYwg2oDAyttWfnX8pSOAv3bHUOlAZQHOBJHb93OfJ2e4=; 7:OJW5hOMOXDbD8NIH9gDsEH3DAekEDhAc43VvVYD4xhUZiuRZGVN4IqJyt/GstbvZgB6SeS+qqlcQn0Ten3lZjwJMvPQFc6QCpmnKsjhWdjM+xalhQVgQKHkbCCtqa+kz/YIOhz7Px7hxKHS9tOwR/Lw8LLyihC6F69qztcQ948vQubAdREkO6M14msq5tMt0g8YkjwWr2Qm+wo1iAyeI7sCWm7md8kLlDDENEGKgmkTidrrRvivQBabHEeMZGYDe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 10:47:19.9387 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66768a6e-1c7f-4cd1-bcb1-08d558178735 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2365 Subject: [dpdk-dev] [PATCH v3 01/19] net/dpaa: fix uninitialized and unused variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the issues reported by NXP's internal coverity build. Fixes: 05ba55bc2b1a ("net/dpaa: add packet dump for debugging") Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 2eb00b5..7b4a6f1 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -697,7 +697,7 @@ static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf) static int dpaa_rx_queue_init(struct qman_fq *fq, uint32_t fqid) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); @@ -743,7 +743,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, static int dpaa_tx_queue_init(struct qman_fq *fq, struct fman_if *fman_intf) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); @@ -774,7 +774,7 @@ static int dpaa_tx_queue_init(struct qman_fq *fq, /* Initialise a DEBUG FQ ([rt]x_error, rx_default). */ static int dpaa_debug_queue_init(struct qman_fq *fq, uint32_t fqid) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 905ecc0..c3a0920 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -639,7 +639,7 @@ tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf, return 1; } - DPAA_MBUF_TO_CONTIG_FD(mbuf, fd_arr, dpaa_intf->bp_info->bpid); + DPAA_MBUF_TO_CONTIG_FD(dmable_mbuf, fd_arr, dpaa_intf->bp_info->bpid); return 0; }