| Message ID | 20250217185119.430193-1-willy@infradead.org |
|---|---|
| Headers | show |
| Series | Remove accesses to page->index from ceph | expand |
On Mon, 2025-02-17 at 18:51 +0000, Matthew Wilcox (Oracle) wrote: > This is a rebase of Friday's patchset onto > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-fixes > as requested by Dave. > > The original patch 1/7 is gone as it is no longer necessary. > Patches 2-6 are retained intact as patches 1-5 in this patchset. > Patch 7 is hopefully patches 6-9 in this patchset. > > Matthew Wilcox (Oracle) (9): > ceph: Remove ceph_writepage() > ceph: Use a folio in ceph_page_mkwrite() > ceph: Convert ceph_find_incompatible() to take a folio > ceph: Convert ceph_readdir_cache_control to store a folio > ceph: Convert writepage_nounlock() to write_folio_nounlock() > ceph: Convert ceph_check_page_before_write() to use a folio > ceph: Remove uses of page from ceph_process_folio_batch() > ceph: Convert ceph_move_dirty_page_in_page_array() to > move_dirty_folio_in_page_array() > ceph: Pass a folio to ceph_allocate_page_array() > > fs/ceph/addr.c | 239 +++++++++++++++++++++--------------------------- > fs/ceph/dir.c | 15 +-- > fs/ceph/inode.c | 26 +++--- > fs/ceph/super.h | 2 +- > 4 files changed, 127 insertions(+), 155 deletions(-) > I did run xfstests with the patchset and I don't see any new or critical issues. Tested-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com> Thanks, Slava.
On Fri, Feb 21, 2025 at 08:44:19PM +0000, Matthew Wilcox (Oracle) wrote: > All callers of this function have now been converted to use > folio_mkwrite_check_truncate(). Ceph was the last user of this function, and as part of the effort to remove all uses of page->index during the next merge window, I'd like it if this patch can go along with the ceph patches.
On Fri, 2025-02-21 at 20:45 +0000, Matthew Wilcox wrote: > On Fri, Feb 21, 2025 at 08:44:19PM +0000, Matthew Wilcox (Oracle) wrote: > > All callers of this function have now been converted to use > > folio_mkwrite_check_truncate(). > > Ceph was the last user of this function, and as part of the effort to > remove all uses of page->index during the next merge window, I'd like it > if this patch can go along with the ceph patches. Is it patch series? I can see only this email. And [PATCH v3 10/9] looks strange. Is it 10th patch from series of 9th? :) I would like to follow the complete change. :) Thanks, Slava.
On Mon, Feb 24, 2025 at 08:11:20PM +0000, Viacheslav Dubeyko wrote: > On Fri, 2025-02-21 at 20:45 +0000, Matthew Wilcox wrote: > > On Fri, Feb 21, 2025 at 08:44:19PM +0000, Matthew Wilcox (Oracle) wrote: > > > All callers of this function have now been converted to use > > > folio_mkwrite_check_truncate(). > > > > Ceph was the last user of this function, and as part of the effort to > > remove all uses of page->index during the next merge window, I'd like it > > if this patch can go along with the ceph patches. > > Is it patch series? I can see only this email. And [PATCH v3 10/9] looks > strange. > Is it 10th patch from series of 9th? :) I would like to follow the complete > change. :) It's a late addition to the 9-patch series I sent a few days earlier. It's unusual, but not unprecedented. I set the Reply-to properly, so mutt threads it together with the other messages in the thread. Lore too: https://lore.kernel.org/linux-fsdevel/5c1ed8a12c92c143e234a59739af3663e9898ec1.camel@ibm.com/ Does IBM still make you use Lotus Notes? ;-)
On Mon, 2025-02-24 at 20:19 +0000, Matthew Wilcox wrote: > On Mon, Feb 24, 2025 at 08:11:20PM +0000, Viacheslav Dubeyko wrote: > > On Fri, 2025-02-21 at 20:45 +0000, Matthew Wilcox wrote: > > > On Fri, Feb 21, 2025 at 08:44:19PM +0000, Matthew Wilcox (Oracle) wrote: > > > > All callers of this function have now been converted to use > > > > folio_mkwrite_check_truncate(). > > > > > > Ceph was the last user of this function, and as part of the effort to > > > remove all uses of page->index during the next merge window, I'd like it > > > if this patch can go along with the ceph patches. > > > > Is it patch series? I can see only this email. And [PATCH v3 10/9] looks > > strange. > > Is it 10th patch from series of 9th? :) I would like to follow the complete > > change. :) > > It's a late addition to the 9-patch series I sent a few days earlier. > It's unusual, but not unprecedented. > > I set the Reply-to properly, so mutt threads it together with the other > messages in the thread. Lore too: > https://lore.kernel.org/linux-fsdevel/5c1ed8a12c92c143e234a59739af3663e9898ec1.camel@ibm.com/ > I see. Thanks. > Does IBM still make you use Lotus Notes? ;-) Luckily, we don't use the Lotus Notes. :) Otherwise, it will be impossible to survive. :) Thanks, Slava.
On Mon, 17 Feb 2025 18:51:08 +0000, Matthew Wilcox (Oracle) wrote: > This is a rebase of Friday's patchset onto > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-fixes > as requested by Dave. > > The original patch 1/7 is gone as it is no longer necessary. > Patches 2-6 are retained intact as patches 1-5 in this patchset. > Patch 7 is hopefully patches 6-9 in this patchset. > > [...] Applied to the vfs-6.15.ceph branch of the vfs/vfs.git tree. Patches in the vfs-6.15.ceph branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-6.15.ceph [1/9] ceph: Remove ceph_writepage() https://git.kernel.org/vfs/vfs/c/19a288110435 [2/9] ceph: Use a folio in ceph_page_mkwrite() https://git.kernel.org/vfs/vfs/c/88a59bda3f37 [3/9] ceph: Convert ceph_find_incompatible() to take a folio https://git.kernel.org/vfs/vfs/c/f9707a8b5b9d [4/9] ceph: Convert ceph_readdir_cache_control to store a folio https://git.kernel.org/vfs/vfs/c/baff9740bc8f [5/9] ceph: Convert writepage_nounlock() to write_folio_nounlock() https://git.kernel.org/vfs/vfs/c/62171c16da60 [6/9] ceph: Convert ceph_check_page_before_write() to use a folio https://git.kernel.org/vfs/vfs/c/15fdaf2fd60d [7/9] ceph: Remove uses of page from ceph_process_folio_batch() https://git.kernel.org/vfs/vfs/c/a55cf4fd8fae [8/9] ceph: Convert ceph_move_dirty_page_in_page_array() to move_dirty_folio_in_page_array() https://git.kernel.org/vfs/vfs/c/ad49fe2b3d54 [9/9] ceph: Pass a folio to ceph_allocate_page_array() https://git.kernel.org/vfs/vfs/c/d1b452673af4 [10/10] fs: Remove page_mkwrite_check_truncate() https://git.kernel.org/vfs/vfs/c/9dcef93363e7
This is a rebase of Friday's patchset onto git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-fixes as requested by Dave. The original patch 1/7 is gone as it is no longer necessary. Patches 2-6 are retained intact as patches 1-5 in this patchset. Patch 7 is hopefully patches 6-9 in this patchset. Matthew Wilcox (Oracle) (9): ceph: Remove ceph_writepage() ceph: Use a folio in ceph_page_mkwrite() ceph: Convert ceph_find_incompatible() to take a folio ceph: Convert ceph_readdir_cache_control to store a folio ceph: Convert writepage_nounlock() to write_folio_nounlock() ceph: Convert ceph_check_page_before_write() to use a folio ceph: Remove uses of page from ceph_process_folio_batch() ceph: Convert ceph_move_dirty_page_in_page_array() to move_dirty_folio_in_page_array() ceph: Pass a folio to ceph_allocate_page_array() fs/ceph/addr.c | 239 +++++++++++++++++++++--------------------------- fs/ceph/dir.c | 15 +-- fs/ceph/inode.c | 26 +++--- fs/ceph/super.h | 2 +- 4 files changed, 127 insertions(+), 155 deletions(-)