mbox series

[v3,0/2] ceph: fix caps revocation stuck

Message ID 20240117042758.700349-1-xiubli@redhat.com
Headers show
Series ceph: fix caps revocation stuck | expand

Message

Xiubo Li Jan. 17, 2024, 4:27 a.m. UTC 
From: Xiubo Li <xiubli@redhat.com>

V3:
- reuse the cap_wq instead of using the system wq

V2:
- Just remove the "[1/3] ceph: do not break the loop if CEPH_I_FLUSH is
set" patch from V1, which is causing a regression in 
https://tracker.ceph.com/issues/63298


Xiubo Li (2):
  ceph: always queue a writeback when revoking the Fb caps
  ceph: add ceph_cap_unlink_work to fire check_caps() immediately

 fs/ceph/caps.c       | 65 +++++++++++++++++++++++++++-----------------
 fs/ceph/mds_client.c | 48 ++++++++++++++++++++++++++++++++
 fs/ceph/mds_client.h |  5 ++++
 3 files changed, 93 insertions(+), 25 deletions(-)

Comments

Venky Shankar Feb. 12, 2024, 2:53 p.m. UTC | #1 
On Wed, Jan 17, 2024 at 10:00 AM <xiubli@redhat.com> wrote:
>
> From: Xiubo Li <xiubli@redhat.com>
>
> V3:
> - reuse the cap_wq instead of using the system wq
>
> V2:
> - Just remove the "[1/3] ceph: do not break the loop if CEPH_I_FLUSH is
> set" patch from V1, which is causing a regression in
> https://tracker.ceph.com/issues/63298
>
>
> Xiubo Li (2):
>   ceph: always queue a writeback when revoking the Fb caps
>   ceph: add ceph_cap_unlink_work to fire check_caps() immediately
>
>  fs/ceph/caps.c       | 65 +++++++++++++++++++++++++++-----------------
>  fs/ceph/mds_client.c | 48 ++++++++++++++++++++++++++++++++
>  fs/ceph/mds_client.h |  5 ++++
>  3 files changed, 93 insertions(+), 25 deletions(-)
>
> --
> 2.43.0
>

Tested-by: Venky Shankar <vshankar@redhat.com>
Milind Changire Feb. 13, 2024, 9:33 a.m. UTC | #2 
On Mon, Feb 12, 2024 at 8:23 PM Venky Shankar <vshankar@redhat.com> wrote:
>
> On Wed, Jan 17, 2024 at 10:00 AM <xiubli@redhat.com> wrote:
> >
> > From: Xiubo Li <xiubli@redhat.com>
> >
> > V3:
> > - reuse the cap_wq instead of using the system wq
> >
> > V2:
> > - Just remove the "[1/3] ceph: do not break the loop if CEPH_I_FLUSH is
> > set" patch from V1, which is causing a regression in
> > https://tracker.ceph.com/issues/63298
> >
> >
> > Xiubo Li (2):
> >   ceph: always queue a writeback when revoking the Fb caps
> >   ceph: add ceph_cap_unlink_work to fire check_caps() immediately
> >
> >  fs/ceph/caps.c       | 65 +++++++++++++++++++++++++++-----------------
> >  fs/ceph/mds_client.c | 48 ++++++++++++++++++++++++++++++++
> >  fs/ceph/mds_client.h |  5 ++++
> >  3 files changed, 93 insertions(+), 25 deletions(-)
> >
> > --
> > 2.43.0
> >
>
> Tested-by: Venky Shankar <vshankar@redhat.com>
>
Reviewed-by: Milind Changire <mchangir@redhat.com>

> --
> Cheers,
> Venky
>