From patchwork Fri Oct 28 14:34:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preudhomme X-Patchwork-Id: 79947 Delivered-To: patch@linaro.org Received: by 10.80.142.83 with SMTP id 19csp1240856edx; Fri, 28 Oct 2016 07:34:36 -0700 (PDT) X-Received: by 10.98.72.86 with SMTP id v83mr25296051pfa.148.1477665276560; Fri, 28 Oct 2016 07:34:36 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id t8si13949461pgn.52.2016.10.28.07.34.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2016 07:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-return-94255-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org; spf=pass (google.com: domain of binutils-return-94255-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=binutils-return-94255-patch=linaro.org@sourceware.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; q=dns; s=default; b=LwdB SGfUWiO6rKTf85dzZpuavGmUWgBwnGoKnCN809RKjrsBIhcXWScvk18dc2GCmRgd 90wdf+pS4rzLWwkLdsr96XPEyMEtsi3kKuhLvqJo255pysQ7v9xHGeF7/AFROGe4 fR7gLeClGmMcCc87kmkl178ZLtrFmyZcq+mI+y4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type; s=default; bh=z/hqlA2hkk 93A8jeIN0MVRlBVMo=; b=aH4+NJVleQuK7TDXl7eyrGs95Lde+SESsIquCKeUxI sHO3jJ8lSrOdHLO/+ZokbGzg+SGh5bv+yMiVSv0me1mUdoTS/TpayFrJkY8RCOA5 2OlcnvygFiWnh3A+MixG6ZfqUoPfobbztx/wrO09VjfpOh12fpTPPGMxeWwv4VHy A= Received: (qmail 64676 invoked by alias); 28 Oct 2016 14:34:21 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Delivered-To: mailing list binutils@sourceware.org Received: (qmail 64656 invoked by uid 89); 28 Oct 2016 14:34:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_50, KAM_LAZY_DOMAIN_SECURITY, KAM_LOTSOFHASH, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=arm_aext_v6sm, arm_ext2_v8m, ARM_AEXT2_V8_1A, sk:69dfe98 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Oct 2016 14:34:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 54E5C16; Fri, 28 Oct 2016 07:34:09 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 950143F220; Fri, 28 Oct 2016 07:34:08 -0700 (PDT) Subject: Re: [PATCH, gas/ARM] Add support for Cortex-M33 To: "Richard Earnshaw (lists)" , Nick Clifton , Alan Modra , binutils@sourceware.org References: <9e016132-e31c-0d2f-80f3-96fb91ee7c05@foss.arm.com> From: Thomas Preudhomme Message-ID: <04111be5-2d74-0c50-6b0b-ef221846ec1d@foss.arm.com> Date: Fri, 28 Oct 2016 15:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: X-IsSubscribed: yes Hi Richard, On 27/10/16 13:45, Richard Earnshaw (lists) wrote: > On 26/10/16 16:09, Thomas Preudhomme wrote: >> [resending with mailing list also as recipient this time] >> >> Hi, >> >> This patch adds support for the Cortex-M33 processors launched by ARM >> [1]. The patch adds support for the name and wires it up to the ARMv8-M >> Mainline with DSP extensions architecture. It also updates documentation >> to mention this new processor. >> >> [1] >> http://www.arm.com/products/processors/cortex-m/cortex-m33-processor.php >> >> ChangeLog entry is as follows: >> >> *** gas/Changelog *** >> >> 2016-10-26 Thomas Preud'homme >> >> * config/tc-arm.c (cortex-m33): Declare new processor. >> * doc/c-arm.texi (cortex-m33): Document new processor. >> >> >> *** include/ChangeLog *** >> >> 2016-10-26 Thomas Preud'homme >> >> * opcode/arm.h (ARM_AEXT_V8M_MAIN_DSP): Define. >> (ARM_AEXT2_V8M_MAIN_DSP): Likewise. >> (ARM_ARCH_V8M_MAIN_DSP): Likewise. >> >> >> Tested by building libgcc and libstdc++ for Cortex-M33 and running a >> hello world compiled for it. >> >> Is this ok for master? >> >> Best regards, >> >> Thomas >> >> > > OK. > > R. > Likewise, do you confirm that the reworked attach patch is ok (ie. NEWS entry is ok for new processor support)? *** gas/Changelog *** 2016-10-27 Thomas Preud'homme * config/tc-arm.c (cortex-m33): Declare new processor. * doc/c-arm.texi (cortex-m33): Document new processor. * NEWS: Mention Cortex-M33 support. *** include/ChangeLog *** 2016-10-26 Thomas Preud'homme * opcode/arm.h (ARM_AEXT_V8M_MAIN_DSP): Define. (ARM_AEXT2_V8M_MAIN_DSP): Likewise. (ARM_ARCH_V8M_MAIN_DSP): Likewise. Ok for trunk? Best regards, Thomas diff --git a/gas/NEWS b/gas/NEWS index a2a62563f867edf26462a08a23950b179710d288..9bddc5de57b6f05746b2b4296ec909f209f277f2 100644 --- a/gas/NEWS +++ b/gas/NEWS @@ -2,7 +2,7 @@ Changes in 2.28: -* Add support for the Cortex-M23 processor. +* Add support for the Cortex-M23 and Cortex-M33 processors. Changes in 2.27: diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 69dfe989133cbdc12f2da9d2864e6788eace3353..a1b81adf66723321c1a979f47ed4133e3a53ec84 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -25406,6 +25406,8 @@ static const struct arm_cpu_option_table arm_cpus[] = ARM_CPU_OPT ("cortex-r8", ARM_ARCH_V7R_IDIV, FPU_ARCH_VFP_V3D16, "Cortex-R8"), + ARM_CPU_OPT ("cortex-m33", ARM_ARCH_V8M_MAIN_DSP, + FPU_NONE, "Cortex-M33"), ARM_CPU_OPT ("cortex-m23", ARM_ARCH_V8M_BASE, FPU_NONE, "Cortex-M23"), ARM_CPU_OPT ("cortex-m7", ARM_ARCH_V7EM, FPU_NONE, "Cortex-M7"), diff --git a/gas/doc/c-arm.texi b/gas/doc/c-arm.texi index 565ef73250e957e2da11cc261ec9d4b5ccb9c7c2..8217095e1a1a051741fbeeb0512893b211da5abb 100644 --- a/gas/doc/c-arm.texi +++ b/gas/doc/c-arm.texi @@ -131,6 +131,7 @@ recognized: @code{cortex-r5}, @code{cortex-r7}, @code{cortex-r8}, +@code{cortex-m33}, @code{cortex-m23}, @code{cortex-m7}, @code{cortex-m4}, diff --git a/include/opcode/arm.h b/include/opcode/arm.h index feace5cd654d2224e2c2f526a37e4fd248b9900a..3b0d061cb14ef71f47256d6c90296299e27f8d1e 100644 --- a/include/opcode/arm.h +++ b/include/opcode/arm.h @@ -151,8 +151,10 @@ #define ARM_AEXT2_V8_2A (ARM_AEXT2_V8_1A | ARM_EXT2_V8_2A | ARM_EXT2_RAS) #define ARM_AEXT_V8M_BASE (ARM_AEXT_V6SM | ARM_EXT_DIV) #define ARM_AEXT_V8M_MAIN ARM_AEXT_V7M +#define ARM_AEXT_V8M_MAIN_DSP ARM_AEXT_V7EM #define ARM_AEXT2_V8M (ARM_EXT2_V8M | ARM_EXT2_ATOMICS | ARM_EXT2_V6T2_V8M) #define ARM_AEXT2_V8M_MAIN (ARM_AEXT2_V8M | ARM_EXT2_V8M_MAIN) +#define ARM_AEXT2_V8M_MAIN_DSP ARM_AEXT2_V8M_MAIN /* Processors with specific extensions in the co-processor space. */ #define ARM_ARCH_XSCALE ARM_FEATURE_LOW (ARM_AEXT_V5TE, ARM_CEXT_XSCALE) @@ -272,6 +274,8 @@ #define ARM_ARCH_V8M_BASE ARM_FEATURE_CORE (ARM_AEXT_V8M_BASE, ARM_AEXT2_V8M) #define ARM_ARCH_V8M_MAIN ARM_FEATURE_CORE (ARM_AEXT_V8M_MAIN, \ ARM_AEXT2_V8M_MAIN) +#define ARM_ARCH_V8M_MAIN_DSP ARM_FEATURE_CORE (ARM_AEXT_V8M_MAIN_DSP, \ + ARM_AEXT2_V8M_MAIN_DSP) /* Some useful combinations: */ #define ARM_ARCH_NONE ARM_FEATURE_LOW (0, 0)