From patchwork Mon Jun 18 12:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 138898 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp3864624lji; Mon, 18 Jun 2018 05:00:45 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJfxIQZp6JPuZI5M+tvku078JOQXVd1MO3ZOPt4rDmMTXwbbj/qTiYPn+hp+4KfrnBBv71p X-Received: by 2002:adf:9acc:: with SMTP id a70-v6mr9694062wrc.180.1529323245452; Mon, 18 Jun 2018 05:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529323245; cv=none; d=google.com; s=arc-20160816; b=koCHWQNSh1blQXTlw0IMDmsGWHrZvRrYVKxGIA14lcriaXOz02GpKPXBO9FiUvyZOM ZRxyNj0AkcJJWEJdK7UC0KiHniXR9b7Q6NDNNvvPZTXDe4jHk+za9ME8moAtLsj1Mg/9 DJi8rssus1mACqR8wII72sFl7XsV7mGbBp0vHulFgAr1/mtKXzVuJlNSOBbdXzuzKEFY 9FaenNxlmvZrxNN97j+irdLOkjBP9rbnlwJAZt10TpPSEYgq2gZ4hgxGvjQ2mj7Vtejg 9lNxaigBozqzr0ybe5b6xxkFfz3ktbgWcHqLXNSxXFAkxAA/BBWzLiZNcexE8+e7fMD+ XHgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=SQMn/kf2ZHvPoKh9z0n2cG9+1BcPTl/g/9ZodFhE6LY=; b=EEFqI8EN/7n3r4czUpV8/Psm7rXSovNrs1grPUVcurhzvlTl1uWMUurT5ExufCVbTs +8pm4OUHl3l1J3/JZQicmvBfZcIlUeTv27mWjOwzJUVfp4KBoTSosoWxQTAe615iv//j 1BGiDSK+0wF84xidDecncJwqeazgT9uIW6ibJUOUyUh7RS4DMyPI9OWh+KEvVBpxb/9n qnapNfkmEjD931wuFaGIh2pED10pDU6UmO8BcOOa0tQKY/bZoY1SD9igiPyA9im05JHj f4JRB0Dkl35zEw8fsgOsO6P//sivalmlx2vAEa9DN3zjzsrpFjhmMwZLfDlDKMJ/QGqb DbHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kcsP7KQg; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id u20-v6si4865452wmd.184.2018.06.18.05.00.45; Mon, 18 Jun 2018 05:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kcsP7KQg; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 84D312676FD; Mon, 18 Jun 2018 14:00:12 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 676242676E9; Mon, 18 Jun 2018 14:00:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 852B92675D5 for ; Mon, 18 Jun 2018 14:00:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=sD26fmjgKCP70Lgaehvq6+qEc29PSWL6R8YNjp9jgOM=; b=kcsP7KQgE6FO BZbe070UGvqe8R+0HIfCCnEfKkZgJgqgk4t8EiTEm27LTSzJJ+r5NIXNuRv46Dw0yqGps1TA2WRan x11Hv9l6ZRe0HUw2vEBVwgbfz+OEJNLXSo4QClNPZu8PyiTMXehw/QqahU7MQvlfhffROUG7Bk2UF 9mcvo=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fUspF-0007xG-L8; Mon, 18 Jun 2018 12:00:01 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fUspF-0008VA-60; Mon, 18 Jun 2018 13:00:01 +0100 From: Mark Brown To: Colin Ian King In-Reply-To: <20180606095719.30831-1-colin.king@canonical.com> Message-Id: Date: Mon, 18 Jun 2018 13:00:01 +0100 Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Daniel Baluta Subject: [alsa-devel] Applied "ASoC: ak5558: make two structures static" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: ak5558: make two structures static has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From e380be7c557c4ddb1cb71404c10e0bfb3daf4644 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 6 Jun 2018 10:57:19 +0100 Subject: [PATCH] ASoC: ak5558: make two structures static The structure ak5558_pm and soc_codec_dev_ak5558 are local to the source and do not need to be in global scope, so make them static. Also make soc_codec_dev_ak5558 static. Cleans up sparse warnings: warning: symbol 'ak5558_pm' was not declared. Should it be static? warning: symbol 'soc_codec_dev_ak5558' was not declared. Should it be static? Signed-off-by: Colin Ian King Reviewed-by: Daniel Baluta Signed-off-by: Mark Brown --- sound/soc/codecs/ak5558.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.17.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/ak5558.c b/sound/soc/codecs/ak5558.c index f4ed5cc40661..448bb90c9c8e 100644 --- a/sound/soc/codecs/ak5558.c +++ b/sound/soc/codecs/ak5558.c @@ -322,13 +322,13 @@ static int __maybe_unused ak5558_runtime_resume(struct device *dev) return regcache_sync(ak5558->regmap); } -const struct dev_pm_ops ak5558_pm = { +static const struct dev_pm_ops ak5558_pm = { SET_RUNTIME_PM_OPS(ak5558_runtime_suspend, ak5558_runtime_resume, NULL) SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; -struct snd_soc_component_driver soc_codec_dev_ak5558 = { +static const struct snd_soc_component_driver soc_codec_dev_ak5558 = { .probe = ak5558_probe, .remove = ak5558_remove, .controls = ak5558_snd_controls,