From patchwork Fri Apr 13 11:24:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133363 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp621715ljb; Fri, 13 Apr 2018 04:24:23 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/aYPhNVnCfDkh3J4H6jWJLoKiR86DhWj6kEIOV2btioILIRL/5akD/hqylXVuj3sXRBTqs X-Received: by 10.223.136.176 with SMTP id f45mr3540791wrf.57.1523618663298; Fri, 13 Apr 2018 04:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523618663; cv=none; d=google.com; s=arc-20160816; b=QNqvpyrK5mFuI1Vn4cG8hVnae2jXF25MAxw94xQvOtQYVfjZeoBmx2ANNr2izaIsE0 39r47hdpvQlHQyQlrb1Ha3vypUJ8gaqnGCveUB6UO3c6eUjDj9ZgvIJtangebjpNH9sF klGx0Ly6+X5+WolfyOz42wKKgNV3xAAV4CuqxwdR/+zQj62d2svrz0falp2yJGovOGK+ Zddd3V58sHCUublXfG4WLmbK8QKW6v/+msB3IXzBmEWHk+1zNBYtG1wGsppw42wYuEkb yhi43tjWY4qbudZJ4FvBTesIfHhrixyiik68Rpa5CePE8UtC8FLR6q9qow3F+kt0YnZk ZXFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=T25jxfe5ycdQArfzYb+aBNT1BQfMYnhHpD/nVKL+VIY=; b=0yVRDBfpZ2mJJ831+OPZhYzSafcNQfUWtniKQpqeGMOYCMGziU/Kb5R5fwMfP19C62 qWnnIVi5DiTbWBn2FfTWiDXxaDfxyVzEy969hinS6DqYRHnzZZ+s5W7ZMofEaBy3r6/6 aB/TPtWLyEWASe6Bv/8pOomwXVv5rjAyD7sDkrFQj4/QE/3P+pHO2ivdz0+4/CUFpbuD Hk+Q8Alf+UE7EmcZ/JCGykMetiAl6Zl2hYqR4B/vtpdagIBe1EPP6Dj1PoonuQCsvMCv bEqSwtoIHB2kbq2I4RsUDGy6aQ6MwpcGI/mSirws2KXU7/xr86HaiIs0JDXtnEi2xMMx CxnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=qDyDeKTj; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id e41si4153718wre.329.2018.04.13.04.24.23; Fri, 13 Apr 2018 04:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=qDyDeKTj; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 294DE2673FE; Fri, 13 Apr 2018 13:24:08 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7F67C26735C; Fri, 13 Apr 2018 13:24:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id A4F4B2675DB for ; Fri, 13 Apr 2018 13:24:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=xDoliWYvIMUJwEpRzjb2tu6ZIfSColXpp8NrfuFIw9M=; b=qDyDeKTjjuSQ 2/IU8S/U3HP49Q1flArxV67TKyqMWPZ40IQwYFhqmcprFNnOEllDwzLTvtJA15CW2SA96CJX5Rgnq MNnsH8/EbPj3NlZeOCTNdhDNbxhGzWlAMYiZPDbxydZVdXPBRQQzYceEz74gSRJX/NYhML8DJZD2u a4GZ4=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6woD-0008CW-0i; Fri, 13 Apr 2018 11:24:01 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6woC-0000BO-Ij; Fri, 13 Apr 2018 12:24:00 +0100 From: Mark Brown To: Jia-Ju Bai In-Reply-To: Message-Id: Date: Fri, 13 Apr 2018 12:24:00 +0100 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: intel: cht_bsw_rt5645: Replace GFP_ATOMIC with GFP_KERNEL in snd_cht_mc_probe" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: intel: cht_bsw_rt5645: Replace GFP_ATOMIC with GFP_KERNEL in snd_cht_mc_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ca243b56cc07b63da38bddfd30d48792f442cca8 Mon Sep 17 00:00:00 2001 From: Jia-Ju Bai Date: Mon, 9 Apr 2018 18:48:31 +0800 Subject: [PATCH] ASoC: intel: cht_bsw_rt5645: Replace GFP_ATOMIC with GFP_KERNEL in snd_cht_mc_probe snd_cht_mc_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, snd_cht_mc_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Mark Brown --- sound/soc/intel/boards/cht_bsw_rt5645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/cht_bsw_rt5645.c b/sound/soc/intel/boards/cht_bsw_rt5645.c index 49ba1a956a06..f5a5ea6a093c 100644 --- a/sound/soc/intel/boards/cht_bsw_rt5645.c +++ b/sound/soc/intel/boards/cht_bsw_rt5645.c @@ -539,7 +539,7 @@ static int snd_cht_mc_probe(struct platform_device *pdev) int ret_val = 0; int i; - drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_ATOMIC); + drv = devm_kzalloc(&pdev->dev, sizeof(*drv), GFP_KERNEL); if (!drv) return -ENOMEM;