From patchwork Fri Apr 13 10:55:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133353 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp596554ljb; Fri, 13 Apr 2018 03:56:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx49+yiYUhsyncvgPqdwsUFsdCh1N7CzsLKsr3+14800pXxewAV5pk/rgiN5R111ddzzsrsFt X-Received: by 10.223.225.133 with SMTP id k5mr3127446wri.263.1523616977315; Fri, 13 Apr 2018 03:56:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523616977; cv=none; d=google.com; s=arc-20160816; b=b6y6JQTj0xtSss/pXOWYkle+EY1c4RCUiACKJ+raBwLH+ite3/kqgXZEAFGtWOHdkc jNWXvR8MyUSpR235JR151NC89thHhfRoF8UMw+BF+e9DDzkFeaRA8QNChI0EATWoO2bM /vBA/wYiyrAFyoUuo6Nk8Fa7N3yr/QEZwEBobuf0ZONWy9Fe1zB/jWaB38t2P9bUkpDQ NmzOdqoNhL12ZWDuCFKjV9fp4SYrIxcmLwbApm5qI6I8ol7zh9a++pBjBAdXk3DOncMN alM1nkmJPw9wfqF307RTEPQiMp3asKiQ2H42TZalLkcs0e+JhiJMwxMziUsaFxoywOgd O0iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=AumVRKfWV/yatUqD7pg698AwBZXrzdI4CezxQ8kQrNI=; b=fHL+TjFEBfi6n95WHtPhRURxxFaUkG+2vIlqZiFTldKAb0k9bMyLdnYFFyhL/FIzlZ JXQpfBK+3NJ3jvKvvp+VUUgt1/DubOo190pdfv1UqbemmZnjTfqVjgTv8FR4ulBv30kC vQoFvxSiLuq15asrowj1ww6gUhuWVhO2vnCq01DH2B8urVxvretAL+isUTirUSNlGcOL ngZqsKxNyRGzy/BxzPbUMEd/W3Al5rmQ+IrMiTe7C7qf7x2uOptTIz7H4BDd5r+NrQmm 0HKhxlfF6CKbujL0X7ksBfG0aVgDguHNDsjwU3+ms0rRTTc1N+fdQ284pXvmEu4+BmEK WS0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=K7BXDWnG; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id v133si1115052wmb.222.2018.04.13.03.56.17; Fri, 13 Apr 2018 03:56:17 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=K7BXDWnG; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 40CEB267356; Fri, 13 Apr 2018 12:55:56 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BD3722673F6; Fri, 13 Apr 2018 12:55:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 8E7B72673A2 for ; Fri, 13 Apr 2018 12:55:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=mxjvhda0N19pua91LLUl0mJxdfd7rLUbE6vbDeBghe0=; b=K7BXDWnGdA+k qWOn1jVlMrKLtKB8G5t6iam1d7J1xHyJlxVQd/EVJmWBMW8bGXLcrMkrHrHgSDoxPG/1Op6zwWBtM 1PRBtWkIJaVsnwy6rJ/RpIkllVgqJtooChrZq6tmVekG1/fPfhu8LP6LrP47FAPKPkwCxQ53zBgvk Y0e2E=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6wMq-00086O-5G; Fri, 13 Apr 2018 10:55:44 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6wMp-000776-MO; Fri, 13 Apr 2018 11:55:43 +0100 From: Mark Brown To: Jia-Ju Bai In-Reply-To: <1523270974-23082-1-git-send-email-baijiaju1990@gmail.com> Message-Id: Date: Fri, 13 Apr 2018 11:55:43 +0100 Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, broonie@kernel.org Subject: [alsa-devel] Applied "ASoC: intel: skl_nau88l25_ssm4567: Replace GFP_ATOMIC with GFP_KERNEL in skylake_audio_probe" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: intel: skl_nau88l25_ssm4567: Replace GFP_ATOMIC with GFP_KERNEL in skylake_audio_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From fe552c82476f2fb16e87a76ee178465325e57f61 Mon Sep 17 00:00:00 2001 From: Jia-Ju Bai Date: Mon, 9 Apr 2018 18:49:34 +0800 Subject: [PATCH] ASoC: intel: skl_nau88l25_ssm4567: Replace GFP_ATOMIC with GFP_KERNEL in skylake_audio_probe skylake_audio_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, skylake_audio_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Mark Brown --- sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c index 212ac8971e55..b0610bba3cfa 100644 --- a/sound/soc/intel/boards/skl_nau88l25_ssm4567.c +++ b/sound/soc/intel/boards/skl_nau88l25_ssm4567.c @@ -696,7 +696,7 @@ static int skylake_audio_probe(struct platform_device *pdev) struct skl_nau88125_private *ctx; struct skl_machine_pdata *pdata; - ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC); + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); if (!ctx) return -ENOMEM;