From patchwork Thu Mar 1 19:26:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130401 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp3190643edc; Thu, 1 Mar 2018 11:27:35 -0800 (PST) X-Google-Smtp-Source: AG47ELv1JPITCyK0OtNxmjhmulfVdxk++flwbYXcxr1ezChXAK+NTaO6b2Gm+L9Nwmaoi2Fc7Vm0 X-Received: by 10.28.30.210 with SMTP id e201mr2132883wme.34.1519932455047; Thu, 01 Mar 2018 11:27:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519932455; cv=none; d=google.com; s=arc-20160816; b=DiWLvYXP+cIdSnvV7jJVXp+YfTREpfQL+bHExbgKbdEHZZKPvJNiIz/qdTpftnvkjH 2tphLHtiVZnEXhqzt7cJ96afZfnn1jTbfFVkW9L70iv+EnNz+DuM1kfo+URe/Km6HHqx 9fZ/j0kNiI82HUHTLw95LmMereQZGTxBpeaTwQ55dhwg9Fiv3udSjuTppQOKk3SPJTBr dZ+nutcEtbaGYw4vjYpILMD3Ih54/Eh3R/SfwKzOpeEBBkY77mu0vCWkt3iUc6s2K8da gQfck/No6uLp38GeEp2Lswg7UL6z0G+b6S3vL5EafeSQ9HvX8fZriTAA6yxCaB3/nbr0 gdYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=2gUd2hPOFaKuv5xqYpvfkHb0XJkmgGv21IxkKl0Fg7M=; b=gS8W3rwmC+uyAsF0KzVoex8VtHTBNWicJpNMdOTw/0HcP7B+9c4UI6bE8gSjDVf7Sb peFsiE8aa2p6RDPre8Tu2bqudkE34teGZpjyKxBKAQ1fSDMhKZ2tVhofQ/FDa7/NC2+/ 9IfMcQJFQ+TVNOZgB0VjTXhhj7+kvxWUYZIxS/H0fA56PZNJRpAqs9qywBHrLt31mafW WcACQPv/Ws6qXL5ccyV6KOhafdRWVmBDMO9tPNXQC2hUxbV6I6G/m4j2ZKRVlsNbIOFe Vk9sa1DzgrAKr54uZV3c7sXVB/7cIrsp1fGITrcBf0rG5BZGZJ7GGc03ZBssvSOzXgYa dNfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=AX1WeJYS; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id t3si2978067wmg.214.2018.03.01.11.27.34; Thu, 01 Mar 2018 11:27:35 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=AX1WeJYS; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 6EA9D267BC4; Thu, 1 Mar 2018 20:27:29 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A0B42267BC6; Thu, 1 Mar 2018 20:27:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id F1028267BC2 for ; Thu, 1 Mar 2018 20:27:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=7NmkI/xNyK3kPwywKX8gmWCfAtdy4waEiJZ+k2PtJqU=; b=AX1WeJYSukX6 nR3Ecf/L3GpGxmbeLEimdOEHZ/WptLXcNK0rH8NKII5iuOLo87Jw+kEOqtRRVemVdTZDSktr5+Oly 9F0n9d0EWBqQO1/3tOMTJFxWVR+bIBBEED3c4OCYUCtjl/K2SrwxPZgP/ApK3rtgOPaIE3VLCIrnD pJbNk=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erTqE-0005j8-ER; Thu, 01 Mar 2018 19:26:10 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1erTqD-0001WJ-WB; Thu, 01 Mar 2018 19:26:10 +0000 From: Mark Brown To: Hans de Goede In-Reply-To: <20180225104713.4745-12-hdegoede@redhat.com> Message-Id: Date: Thu, 01 Mar 2018 19:26:09 +0000 Cc: Oder Chiou , alsa-devel@alsa-project.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Carlo Caione , Bard Liao Subject: [alsa-devel] Applied "ASoC: rt5651: Remove programming of PWR regs before force_bias_level() call" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rt5651: Remove programming of PWR regs before force_bias_level() call has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From a25fe11746846f5dd3286cf690b470e3d049797f Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Sun, 25 Feb 2018 11:46:52 +0100 Subject: [PATCH] ASoC: rt5651: Remove programming of PWR regs before force_bias_level() call Remove the setup of the PWR_ANLG1 reg which was done directly before calling snd_soc_component_force_bias_level(SND_SOC_BIAS_OFF), as the latter will override any settings done to PWR_ANLG1 immediately anyways. Tested-by: Carlo Caione Signed-off-by: Hans de Goede Signed-off-by: Mark Brown --- sound/soc/codecs/rt5651.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index d4fb16686889..74f83af3b6be 100644 --- a/sound/soc/codecs/rt5651.c +++ b/sound/soc/codecs/rt5651.c @@ -1662,16 +1662,6 @@ static int rt5651_probe(struct snd_soc_component *component) rt5651->component = component; - snd_soc_component_update_bits(component, RT5651_PWR_ANLG1, - RT5651_PWR_VREF1 | RT5651_PWR_MB | - RT5651_PWR_BG | RT5651_PWR_VREF2, - RT5651_PWR_VREF1 | RT5651_PWR_MB | - RT5651_PWR_BG | RT5651_PWR_VREF2); - usleep_range(10000, 15000); - snd_soc_component_update_bits(component, RT5651_PWR_ANLG1, - RT5651_PWR_FV1 | RT5651_PWR_FV2, - RT5651_PWR_FV1 | RT5651_PWR_FV2); - snd_soc_component_force_bias_level(component, SND_SOC_BIAS_OFF); rt5651_apply_properties(component);