From patchwork Thu Aug 17 17:13:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 110329 Delivered-To: patch@linaro.org Received: by 10.140.95.78 with SMTP id h72csp2466351qge; Thu, 17 Aug 2017 10:14:45 -0700 (PDT) X-Received: by 10.223.134.76 with SMTP id 12mr4324511wrw.50.1502990085526; Thu, 17 Aug 2017 10:14:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502990085; cv=none; d=google.com; s=arc-20160816; b=DMjfxIT3OqH1c557s6SVgsgC6MQiPedCffKzSNLn/PkhLcV6+4dSVGnwUyN4qb6Qyx wd3J/s0hulABHjuCNRM5Mc9ZmiSBmCO/EXHIzivKowoSPrpiYqdZYfG7xZghC39b3grA cyTxIDnuJY3Ps+9l7sYfmegvQPHFr6rj3b6TkYQKTxA6DYSKPSj8ZztKg3gzFOh8LhS8 P6GINIAqG0Ovb1xUSHUdBA+06BXEbpw5OlMNtf9me17AOWCP3AnxBzxINf7Uqcq7hHwS sLLaRy8eQb0GyHjl83M2bxLkl6VPdOsT6umIMysrIZkatn1mnGYtHk31iOFlWSooZyQX Sq/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=YtN/wOtZTOpGFGi4DgP0Um5r6Bargy/Xvcx2a27fguU=; b=SWIqEo0Rwve/R3MLDTer+V7rPNwqdrGO56zOADJBcdIuRQe8hm9xqgGu7/0v6S3OMh vdz4yMWhwXG24EOPlY8/+en4w1Hkpp+VZMP0aVCn0EUH5ObdRyHiApPwsJgJPF6WQmC6 NR4+3D7XBQ/4IVooxzT7h/G0S3mAO1R/MGvRUKMXX8q79uUp5VAgYXb1BV7DcXq2Ubc+ uOAfKzVu5EJGcwlyk+ZAXAc1Kx6L4hu0w7yejpo1LD3oTszX3qMfNfi3T9xZD80Q9tTH vANAW5ANh9tM1nZL+NXEbndGIh9Wy6lvx3QwOUf/PIvWaQf6++F1mDy5WMXxCH/sxgDg ft4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Zv1Y+zqo; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id e24si2693003wrc.491.2017.08.17.10.14.45; Thu, 17 Aug 2017 10:14:45 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Zv1Y+zqo; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F31A7267060; Thu, 17 Aug 2017 19:13:39 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A3C37267060; Thu, 17 Aug 2017 19:13:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id C6A07266FEC for ; Thu, 17 Aug 2017 19:13:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=k/VyBd/f+4Zim5Fva8PSs2rD1qyE/DRsD4MSPAbDdMs=; b=Zv1Y+zqoW5mF f/Wnu17xVBCIkCTu+yMrlvbsEun6eo/tpPSNn/ZjoKBIk1eyPvNwP7+T0nQbzuybHEr4gTzdJ0E4y jxrWX3It9hRAxv1Xe3yJX3l9uVpMOcEaghrcFv9wpErui3do2acXfz8w+vLKCTc/MxhYRTABKXrWB Hy6i8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1diOMA-00078n-JR; Thu, 17 Aug 2017 17:13:18 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1diOMA-0008S0-6U; Thu, 17 Aug 2017 18:13:18 +0100 From: Mark Brown To: Harsha Priya N In-Reply-To: <1502427646-18880-1-git-send-email-naveen.m@intel.com> Message-Id: Date: Thu, 17 Aug 2017 18:13:18 +0100 Cc: alsa-devel@alsa-project.org, Shruthi Sudhakar , Harsha Priya , liam.r.girdwood@linux.intel.com, vinod.koul@intel.com, broonie@kernel.org, tiwai@suse.de, naveen.m@intel.com, pierre-louis.bossart@intel.com Subject: [alsa-devel] Applied "ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From d46b1828406f74bc2d9ffe15e9a7b76ddbffbf7f Mon Sep 17 00:00:00 2001 From: Harsha Priya N Date: Wed, 16 Aug 2017 16:19:55 +0530 Subject: [PATCH] ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform Patch fixes cracking noise in rt5663 headphones for kbl platform by calling rt5663_sel_asrc_clk_src() for RT5663_AD_STEREO_FILTER to set ASRC. The ASRC function is for asynchronous MCLK and LRCLK. For RT5663 ASRC should be enabled to support pcm format with 100fs. ASRC function will track i2s clock and generate corresponding system clock for codec. Calling this func helps select clock source for both RT5663_AD_STEREO_FILTER and RT5663_DA_STEREO_FILTER filters which fixes the crackling sound. Signed-off-by: Harsha Priya Signed-off-by: Shruthi Sudhakar Signed-off-by: Naveen M Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/intel/boards/kbl_rt5663_max98927.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.13.3 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c index 8bdd6131c6ad..c1442147d138 100644 --- a/sound/soc/intel/boards/kbl_rt5663_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c @@ -356,11 +356,13 @@ static int kabylake_rt5663_hw_params(struct snd_pcm_substream *substream, struct snd_soc_dai *codec_dai = rtd->codec_dai; int ret; - ret = snd_soc_dai_set_sysclk(codec_dai, - RT5663_SCLK_S_MCLK, 24576000, SND_SOC_CLOCK_IN); /* use ASRC for internal clocks, as PLL rate isn't multiple of BCLK */ - rt5663_sel_asrc_clk_src(codec_dai->codec, RT5663_DA_STEREO_FILTER, 1); + rt5663_sel_asrc_clk_src(codec_dai->codec, + RT5663_DA_STEREO_FILTER | RT5663_AD_STEREO_FILTER, + RT5663_CLK_SEL_I2S1_ASRC); + ret = snd_soc_dai_set_sysclk(codec_dai, + RT5663_SCLK_S_MCLK, 24576000, SND_SOC_CLOCK_IN); if (ret < 0) dev_err(rtd->dev, "snd_soc_dai_set_sysclk err = %d\n", ret);