From patchwork Tue Aug 1 14:16:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 109172 Delivered-To: patch@linaro.org Received: by 10.140.101.6 with SMTP id t6csp1556723qge; Tue, 1 Aug 2017 07:17:11 -0700 (PDT) X-Received: by 10.28.184.202 with SMTP id i193mr1623844wmf.22.1501597031678; Tue, 01 Aug 2017 07:17:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501597031; cv=none; d=google.com; s=arc-20160816; b=OA3r4zpSj4+nB7BI+qtJ8xWcsL5cbn+k8841qpG18pHIOi5Q6S3Vgz3UxCshsLtJU0 kFexzvNVi6Q+KyBUDDP/eo0/IBb+ylU8sv4c+DSobzd+uywDbM5+o7ap6He1RxA/ilJh Hvz7K1iseu8JnodRMT9588NBTjoJrsOIg3ACvxXi4Db/6hDhvf3MJJ9mbg66q2PP45Tk mZHW5uo5UkZfpvEPZeoB/OZ6lPmY67usVGFxavJKDmn7/q+Zn7R3wsqXZHrwGDTc4xsE bDIH6CMX1VlvXBtZt/q9o8tgv5U+ReNoUfUdIqkpJ+CNMzs4utG+4zhbW6zhJznPAf96 6xKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=x9yTqCnUJJ1ENhFvEu9/ciMq/YziMNRVzXJ5ssWAyBY=; b=bO9Lrj0872R7gnVy3Lq/yjpFUOTEMR7zmM2xaz5ss0nZmIblOsGB+ZlZPSURVi+ey2 /kx3E3NatVsXeuqZ6S5Wove2zVw8OCvra/N+IqgjkK/YJdE3fqxOIi0YG1VGeJyPi0qC Qt6xVP+aH1gbW9dgdDb6rKWUQqCz07q1fm1SrTelQIsEe7ViY++z5+xRxU/zEy7KI8dJ byVQVs+Qh7hQI8151nxNXXVnW3tDB/6KoEsBXNEFTpOSuXZOVonWYUrNkjIal0vjrOX0 p/JV/2nNbGix3M4pHbIN5tsAyo24u37hsiAtvaO2m3FyXkgwyLJbLgg5gdH223GGFaB0 +MYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id m205si1343040wmf.159.2017.08.01.07.17.11; Tue, 01 Aug 2017 07:17:11 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 540DD267192; Tue, 1 Aug 2017 16:16:58 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C1144267193; Tue, 1 Aug 2017 16:16:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 0D0F7267145 for ; Tue, 1 Aug 2017 16:16:48 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dcXyT-0000bQ-Np; Tue, 01 Aug 2017 14:16:44 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dcXyR-0008OG-6T; Tue, 01 Aug 2017 15:16:39 +0100 From: Mark Brown To: guneshwor.o.singh@intel.com In-Reply-To: <20170728104216.26859-3-guneshwor.o.singh@intel.com> Message-Id: Date: Tue, 01 Aug 2017 15:16:39 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, Takashi Iwai , Guneshwor Singh , Patches Audio , Liam Girdwood , Vinod Koul , Mark Brown Subject: [alsa-devel] Applied "ASoC: Intel: Skylake: Remove return check for skl_codec_create()" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: Skylake: Remove return check for skl_codec_create() has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 693c0fb26a312d7cc866b1e9195187789b69e7e6 Mon Sep 17 00:00:00 2001 From: "guneshwor.o.singh@intel.com" Date: Fri, 28 Jul 2017 16:12:15 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Remove return check for skl_codec_create() Since skl_codec_create() always returns 0, make it return void and remove return check. Signed-off-by: Guneshwor Singh Acked-By: Vinod Koul Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.13.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index b9e1310673f0..ab651517e8b8 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -528,7 +528,7 @@ static int probe_codec(struct hdac_ext_bus *ebus, int addr) } /* Codec initialization */ -static int skl_codec_create(struct hdac_ext_bus *ebus) +static void skl_codec_create(struct hdac_ext_bus *ebus) { struct hdac_bus *bus = ebus_to_hbus(ebus); int c, max_slots; @@ -559,8 +559,6 @@ static int skl_codec_create(struct hdac_ext_bus *ebus) } } } - - return 0; } static const struct hdac_bus_ops bus_core_ops = { @@ -612,9 +610,7 @@ static void skl_probe_work(struct work_struct *work) dev_info(bus->dev, "no hda codecs found!\n"); /* create codec instances */ - err = skl_codec_create(ebus); - if (err < 0) - goto out_err; + skl_codec_create(ebus); if (IS_ENABLED(CONFIG_SND_SOC_HDAC_HDMI)) { err = snd_hdac_display_power(bus, false);