From patchwork Fri Jul 21 16:46:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 108499 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp1015529qge; Fri, 21 Jul 2017 09:46:31 -0700 (PDT) X-Received: by 10.28.212.7 with SMTP id l7mr5581332wmg.31.1500655591644; Fri, 21 Jul 2017 09:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500655591; cv=none; d=google.com; s=arc-20160816; b=MJ5seeizty2t/0SwvYs+GHKtXUF8duDBLyr1G/fQlPLRwF9GRbMqqq/iNlqR1eyrUO ZYrw5G4viZnECdQ+a0OYyX2Dybxkp/4dw9eQAjw9Xq+mpii5yWNLKSBGlqo987mXumaP 5aYjqlQfBpVvtRwB7BcISLeqd55wcfSNaG2dwQFq4JeDTJMScVWetYgDvrfJUGKAyFrV R54ia7PQcevRwheukXXrySr+P8VTWltVMM1DH5K/YmUq9kSOyE46mPB+9xgIBgcBo1pA Vpd2x2nEWPVUtYdyJMKSH8GlWXAa9T2h2uVdFx4LtZR9NEgFw6TewdMCns/Q3YZxNluM vTMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=eWZ0vQpmpQpulFA6TsQ7OipNiGXHLrXgvL6PE8GWBMY=; b=LZN94UhUysjtFZrfWQoF40Ln/qfhePl+jkYvvHD6hLjsmCLuMbox7C6G3qd/ExoX5e SSDJh30GvDDWrlsPR4lu84zxpLv9q4Ad2AlQZDS/ZaGqM8adeBUK6ropRnpY5tVhL0LH PS2DLBcwL8Z5zteAn+3PsdOB1PuigJ/nXo2r6srbDMF2itS509JfFk7l3Su0AFVzwPq7 ygC/87sr+Y0CrZhnCuG3gavxoATvNk47U/1b6bxVZlBHzGh8m0k38MDAI1K2O4jZ+RfN 2BylrjkVB1Z8l8dS+kwutkZcIuZ0OoaCotOe7h/M5Ggdk2XpQ9S6RQA4QzTLc3AVNJvC Fphw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id m20si1285298wmi.39.2017.07.21.09.46.30; Fri, 21 Jul 2017 09:46:31 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4355726753E; Fri, 21 Jul 2017 18:46:22 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 50FDA26753F; Fri, 21 Jul 2017 18:46:21 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 60C9526753D for ; Fri, 21 Jul 2017 18:46:18 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dYb45-0002gj-1i; Fri, 21 Jul 2017 16:46:11 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dYb42-0005nu-F2; Fri, 21 Jul 2017 17:46:06 +0100 From: Mark Brown To: Fabio Estevam In-Reply-To: <1500572177-14939-1-git-send-email-fabio.estevam@nxp.com> Message-Id: Date: Fri, 21 Jul 2017 17:46:06 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, broonie@kernel.org, richard.leitner@skidata.com Subject: [alsa-devel] Applied "ASoC: sgtl5000: Use snd_soc_kcontrol_codec()" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: sgtl5000: Use snd_soc_kcontrol_codec() has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 364e93ca5dd6f4d266c3a5ff169961d2caac19fb Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Thu, 20 Jul 2017 14:36:17 -0300 Subject: [PATCH] ASoC: sgtl5000: Use snd_soc_kcontrol_codec() Since commit a72952672005 ("ASoC: sgtl5000: add avc support") the following kernel crash happens after running a 'reboot' command: ALSA: Storing mixer settings... [ 20.031604] Unable to handle kernel paging request at virtual address fffffffe [ 20.039268] pgd = de2a0000 [ 20.041999] [fffffffe] *pgd=8fffd861, *pte=00000000, *ppte=00000000 [ 20.048387] Internal error: Oops: 80000007 [#1] SMP ARM The function that takes a kcontrol parameter and returns the codec that registered the control is snd_soc_kcontrol_codec(), so use the correct function to fix the problem. Fixes: a72952672005 ("ASoC: sgtl5000: add avc support") Signed-off-by: Fabio Estevam Tested-by: Richard Leitner Reviewed-by: Richard Leitner Signed-off-by: Mark Brown --- sound/soc/codecs/sgtl5000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.13.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 8f6814c1eb6b..80f6d1da7095 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -409,7 +409,7 @@ static int dac_put_volsw(struct snd_kcontrol *kcontrol, static int avc_get_threshold(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); + struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); int db, i; u16 reg = snd_soc_read(codec, SGTL5000_DAP_AVC_THRESHOLD); @@ -442,7 +442,7 @@ static int avc_get_threshold(struct snd_kcontrol *kcontrol, static int avc_put_threshold(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { - struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); + struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); int db; u16 reg;