From patchwork Fri Jul 7 12:51:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 107191 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp25413qge; Fri, 7 Jul 2017 05:52:33 -0700 (PDT) X-Received: by 10.223.152.20 with SMTP id v20mr787238wrb.8.1499431953241; Fri, 07 Jul 2017 05:52:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499431953; cv=none; d=google.com; s=arc-20160816; b=KljPoPJP3ZD6xAgT7uqPsdhj14wGXPBRzo8mLKFPgPOqATeBREVxZw3zr5hwi6645Z W8wFpS7Hw/LajCEVrUL4gkvcrUD9h5y6Xu6Qk6imEDx+O77UV/L/eWQR8cYISD0iGkVl rNBPp1kQmbP4f+0+kfYyfMY9vVxCvzDLQ4oyGkrgPP4Bui/UjZ/5HRlaIVdoq5soF7cJ K7vpnBaOYtK/G3Sc/6wjPy5egOJ5cXe/RDR38mRMgreCXvdE1EcfR6QGOjNT/oaJ90CQ m4KemwiE3vhPL9w7wFXVFIS+HmaRUJrBRRH09tUaXZoY8lr6J3ItGWAFnAf+xEmEzYO6 OM4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=LjumRyS9olCe0C3GctwZUwMIBz6jBYR8oB1MmjP3IIE=; b=SAqgh6GwZIvRm5h6kYzswHB09xclZ5Y8z2i9Vt/7gVxCSD9KCnijdwtYpV18yimlNO bcUs8Gt2VXF88EqEID0uIkoH7z1secXq+/UO2cZXWD0tbl+O1td23xncX2/Z0urhxOgJ tDYs+qOmncObeS5Fcgla7MaP0UdV0tcqC6GRLKwvMlcZPQq0Ya5LuqGRFiiOb4OoNgLb UMimzV03AtyVbMzD153LCUmVpOlXF9TYjAhnycKQ78bdRtEI8gpo1gn0rCTmN1AjyeHe zVLdw5etaWDhAqvzZ8IlFWveltejn2dib9wwf6spTEkPOu1d9X8nRMKFl3Yt8EEego75 /wRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id d42si2160432wrd.85.2017.07.07.05.52.32; Fri, 07 Jul 2017 05:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 23ED82671B9; Fri, 7 Jul 2017 14:52:25 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B9FCE2671B9; Fri, 7 Jul 2017 14:52:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id DBED82671AE for ; Fri, 7 Jul 2017 14:52:20 +0200 (CEST) Received: from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dTSjn-0005Xo-Q5; Fri, 07 Jul 2017 12:52:02 +0000 Received: from broonie by finisterre with local (Exim 4.89) (envelope-from ) id 1dTSjk-0002nC-Cz; Fri, 07 Jul 2017 13:51:56 +0100 From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: <20170630204350.GA8158@embeddedgus> Message-Id: Date: Fri, 07 Jul 2017 13:51:56 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , "Gustavo A. R. Silva" Subject: [alsa-devel] Applied "ASoC: spear: fix error return code in spdif_in_probe()" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: spear: fix error return code in spdif_in_probe() has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From adee2d75d095c1b0ef83fd2b5f403c819e5c6ef3 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Fri, 30 Jun 2017 15:43:50 -0500 Subject: [PATCH] ASoC: spear: fix error return code in spdif_in_probe() platform_get_irq() returns an error code, but the spdif_in driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- sound/soc/spear/spdif_in.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.13.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c index 977a078eb92f..7f32527fc3c8 100644 --- a/sound/soc/spear/spdif_in.c +++ b/sound/soc/spear/spdif_in.c @@ -223,8 +223,10 @@ static int spdif_in_probe(struct platform_device *pdev) host->io_base = io_base; host->irq = platform_get_irq(pdev, 0); - if (host->irq < 0) - return -EINVAL; + if (host->irq < 0) { + dev_warn(&pdev->dev, "failed to get IRQ: %d\n", host->irq); + return host->irq; + } host->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(host->clk))