From patchwork Thu May 25 01:18:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 686444 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A06C7EE31 for ; Thu, 25 May 2023 04:56:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4F31586F; Thu, 25 May 2023 06:55:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4F31586F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684990569; bh=jVO+YGsbwRnAzy9jREUYpNMZuswwebg6ihl8fGfpDtQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=DW1ptfjD8ryVcEJyy1jpOBUfwsIg/mCiBh3YGi5k4i3BGcjICF3tH7u32n4B+rj1r i/Tg+1gyqjXG/dIRKgcz5YwMVBkcwj5pdRbNJ6hQhlgow3DkeussTT0WUpYHCY/Uld btsxAlQMbw66wVcGviRpdXXIjDp2F9xDChutveic= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3507F805DF; Thu, 25 May 2023 03:18:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AAC1FF805D4; Thu, 25 May 2023 03:18:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D597FF805D4; Thu, 25 May 2023 03:18:10 +0200 (CEST) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on20728.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::728]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D7C87F805C7 for ; Thu, 25 May 2023 03:18:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D7C87F805C7 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=Y+fXljOz ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QzGAfcZINUNNi9U/e2LDQbJhsuGp3Wm9+QSYlZrT5lCah0h7i6A71w8KU29ESOvJzRlXEluOlgYnxUh6jHLkT8dtaUzYumjrUSyu2duR5/PvRuE5cpz92Z1xcZeANj7H6BZ5EVqBHArI2ogcaSD09DAy9AxwDV3VG3O+NEd2VSLt3lef3vcI/ABlJ7DrV5QCFtkvuZFKQo6eTXoKsgs3hDvbgZNgqmVGrbGwXAE2rMbQg/toxDWXBzS+djQQzo84BTwGdxvwq1mt7uaK2n/YZBXgaFhiYBGlPdZIoXQSivyMLBsvQ7qmavAo7BRMheKzJzFte/5FRf0NiUhVO0m0sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kmQ6mb3JrwoxbGRKGzZ43ikrzMM7iiARHn29Pvf66OE=; b=IG4HXbDy3nciU+ufUjxSOi043XXQffXIEJ2YE9uDMJ2J5NQ/0P4shZmZUMkkIU+gp5ubGEsw+Y7xArPS8fvWaICIusG+9YKEijC+5B30oQn5YenShbq1mY7nFdctL4VsZYzhpxRISUj35rVBZmvYYM2/ZgQaIoUJyInv9Gk9CG5Bklrki3k/sEg9hjcDr3CCRdelFOeumKRc7Lxbwx9riaxiLkFw5128Sdg+Y4RHo8cqKvKb0oKkiDTIUyfIf1J7Vg9c3B7rYrEq4drQFQ93hsoaB/8Tbm8IhJ6IbmdnvFkTWlVbRwMvETFbin1Tab1QjuKgL+4geJrI7jTGGO0Bsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kmQ6mb3JrwoxbGRKGzZ43ikrzMM7iiARHn29Pvf66OE=; b=Y+fXljOznIxbfcTTAIjmIajgEEaifshfFOK3NwEVHr//8n+jqwT3UNUFhNFDJBFCmmHsg0l/kRln1P0lLtPolp5bcFD5z+bTuusG6ytlAG3MFnpJSEgyg3EFi+TOc0CzAzXnYY7Rcm1fiLm3yXHPYjBTqj1PiW8rdOdZqk7+Ch4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB8440.jpnprd01.prod.outlook.com (2603:1096:400:15d::5) by TYCPR01MB8485.jpnprd01.prod.outlook.com (2603:1096:400:156::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May 2023 01:18:03 +0000 Received: from TYCPR01MB8440.jpnprd01.prod.outlook.com ([fe80::6c36:5ff9:24c9:e4f7]) by TYCPR01MB8440.jpnprd01.prod.outlook.com ([fe80::6c36:5ff9:24c9:e4f7%6]) with mapi id 15.20.6433.016; Thu, 25 May 2023 01:18:03 +0000 Message-ID: <87pm6pgqet.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: alsa-devel@alsa-project.org Subject: [PATCH v2 03/21] ASoC: soc-pcm.c: cleanup soc_get_playback_capture() error User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 In-Reply-To: <87ttw1gqgn.wl-kuninori.morimoto.gx@renesas.com> References: <87ttw1gqgn.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 25 May 2023 01:18:03 +0000 X-ClientProxiedBy: TYXPR01CA0045.jpnprd01.prod.outlook.com (2603:1096:403:a::15) To TYCPR01MB8440.jpnprd01.prod.outlook.com (2603:1096:400:15d::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB8440:EE_|TYCPR01MB8485:EE_ X-MS-Office365-Filtering-Correlation-Id: 86db84e0-91c4-49d3-f85e-08db5cbde31e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3FWh4iWDNS1wmFYeHDURfC2UDvGoFxcWLo+JVtIsz/70SQM7SiMqHUPUMgDUXKCj1v/RJ5Tip3QTB5cfk6NPJn2g0Hzq/SlAjx9axtfViiC9j1whka575uNme+RAASdYIOOoEWrWgLLVwmUV9gpxoGO3TJ27/Eq27HjKtm5RwA47XakM9tGPz2hN5AZwharFHJktQHlVD1jCD6A1oG7Je59hDn1m8q0nMk8pjazlml0CKLLAhJ0w9jjTMytO/4gDYjcU0Y28xIhbpAJ3ggSat5RXVkixvzwMrCxKpgCER9DoTxLJIIjxm1TBRlqRh7ZZmF01zP7yYnAMGcHhblskGbJd2YJ2YKU+eY78huUqzlxCPldnntL7LSnaaTqYVANsGJJMn85/85e83PLXnSvqIh+Vl7b1aONdP8SmhVhoTJ0cBjMFsYUq1Hq91S44EYTKNGAKwTl4/yKSKKoGxA6wtMCU9Cj3aacPIhgzSMjy9S5Sxe41jqVtmlIMY0R1d91U24xgGoENmG49JWO/Xf8Ak0Cy3xHXAdLEByO9tvPKvrfxjSON70Kd6oIjLMvIQTxzh97bwGI6dV+40ezrQC0XZu9Qai2sU9pS1DGCR4mmECsUDQiYicmpihc/xVtTDa/Z X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB8440.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(451199021)(4326008)(83380400001)(66556008)(52116002)(66476007)(66946007)(6486002)(110136005)(2616005)(6512007)(26005)(6506007)(186003)(86362001)(2906002)(478600001)(8676002)(8936002)(5660300002)(36756003)(38350700002)(41300700001)(38100700002)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-2?q?66BFLKZUa8c4ARn42qqMnRT?= =?iso-8859-2?q?dHtcyzxApe8ldCuTtqve79m5lPYgJVM93m9nIs9CKl9H3YXWS0Fc1afkebuy?= =?iso-8859-2?q?3PFJJwJr0YKiyDx8dX3R7ybB6G68sdSqa+2pmidO1+s7vfvFuNer3eu9VayN?= =?iso-8859-2?q?fvre5YPfYBtWr+NTkxvEPnH6kMzdUpMwJinqvsSr/MeCsq8hn/GYwYEqpmbk?= =?iso-8859-2?q?Bsar2coq5rpwxOIHMZPCaEIduc358E+yuvcsYNLfVzwKLs5lV4JsTw8PISua?= =?iso-8859-2?q?URRz8VW0bDTR8rXRt1pabhkIFrJFtfMhkZkivFGT9tVYKt6xG6vuE4p0rtFv?= =?iso-8859-2?q?Rq+EwLZjHkFaTFqLp+D4xKWJVxFbDXDXztEuHjXEdl7JKubpES9r9VnjCUCM?= =?iso-8859-2?q?RnNEqwC6WQekTCAZ8HkIE9BYcZUrqVRNB8DuRTJ5LWqPNgVR8tHlkDzKCBid?= =?iso-8859-2?q?w9Riw3CA2VR8XpBHQ6vSZcB/8ZvQUfyCoCa6q6ClQWj+5VT6eoTUAnguK2dw?= =?iso-8859-2?q?lLH540fa2PW42fWOselMevoJo8VTmviPz6v7+KJXJGuF0w6pkd3vtkmRj9iM?= =?iso-8859-2?q?Lp69hGihZY0H1qgt+kcMVoLtGwhTNtwD/4mDwULdFElzwmKOVusKuYOq/Pb6?= =?iso-8859-2?q?Yo9oERRS4xnYSqYt/FbVD8o+R7cUdy+vzZ7nDrsCSDSFXeDNoGu+XHutHyRd?= =?iso-8859-2?q?mzaqLF4lyFRgop71STfArhm1QYyYNOOpIn32eOn42SXfBnieAloCbJDDF4Ie?= =?iso-8859-2?q?iWY8x9MK0iNjSJ2wu2ga8pAk3Yl932P9eESkEq7SXxuNazkksAwZElmCN/4l?= =?iso-8859-2?q?T+1k5f0T0IUzRU/K2aFZ4iNjk5DlG543as/IqBxbfncM/nfmZ7d/Wj4592f+?= =?iso-8859-2?q?1clWz0FXy81zqDztlAkwkM8aIrjUTXmOIe7hBnMaT6WCK19I4QD2bIE/65dc?= =?iso-8859-2?q?zgUY1V9nCPqP7AFEXw5cuYGkdX4g4F5+LXDhPK2NNoGHuT/3IN9d9cuik7MX?= =?iso-8859-2?q?u/Gysrn2wFefr0ogpB3J/p/OiXbPxfFl6TZyueUY/e1Dzf0E7rC9ebXEzbzd?= =?iso-8859-2?q?pWY08RuWAmNLFskciV5jAqRY0GFiUEtukRKkRnskw9hiCtFUSdvWsI4BBose?= =?iso-8859-2?q?o9ssJLLYziaHhJfwfdbky0k+DFMLsOqVLRBnf6V2/wAYw+Md3fk/wXV4sEnE?= =?iso-8859-2?q?toaE0eUD5ZMNDo+Lxi6KPhhALpNdSnmz8G27PdhqbnWagIywOIiZiFfAm+Wp?= =?iso-8859-2?q?p8Qx2GAZE52L+hEkh/3AX25KmW9T4p3JeLn/df5UZe5ikcZ+p04VgcSuwUUR?= =?iso-8859-2?q?7wAfg06+VS6MJYmRBmqP/lS5ibi0YNNehgjHEoyxy4wS1qOI6XmDHby5vQfE?= =?iso-8859-2?q?GpPAKpkVoQ6/bJnts/NP/A+N6+m61EWRtpezSreA0wxaYVOYq/fA/fOXfTBa?= =?iso-8859-2?q?iTWEWYzYI6MXnPKUaUIHZdhW8lGG29xnCfgaFkrp5Qw9dLU6tVOQ8sWvnwWk?= =?iso-8859-2?q?HfO7DLJxJDqL5sahcTHmnXV/B6caVHkFBNIFi7zeblidRH4UioXUbtsfRL6n?= =?iso-8859-2?q?851b9yaaoCT1QKlL4T6n7wnkDapR8ppY7alWwoH0+3/Z2TXi9nNOrpWf8czn?= =?iso-8859-2?q?249JPH1JJ3JzKhTcc7ea/+sofVMVbjj+ZtC72wG0K6y2nfZ/MkNpJRYkYrBw?= =?iso-8859-2?q?=3D?= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86db84e0-91c4-49d3-f85e-08db5cbde31e X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB8440.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 01:18:03.3375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8u277nOZN8cAmgQR3ZjWlitKookZH7BUVCf9MLQx/1GZezwxs7EFsKDW/IhXoUtCGiCWiBLwu9+9LsCReMf+VffQPvudR4JaPaiQJScPzcICykY15mEhbF1+pgXW8PFI X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB8485 Message-ID-Hash: AVOR5ESNTMLKTFOLC5OTMPCRSKMEFAB4 X-Message-ID-Hash: AVOR5ESNTMLKTFOLC5OTMPCRSKMEFAB4 X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: soc_get_playback_capture() (A) checks dai_link status, and indicate error if it was not matching (B). (A) static int soc_get_playback_capture(...) { ... ^ if (dai_link->dynamic && dai_link->num_cpus > 1) { | dev_err(rtd->dev, (B) "DPCM doesn't support Multi CPU for Front-Ends yet\n"); | return -EINVAL; v } ... } We can use 100 char for 1 line today. This patch cleanup error code line. Signed-off-by: Kuninori Morimoto Reviewed-by: Amadeusz Sławiński --- sound/soc/soc-pcm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index db3fbe1af2ce..47da3be0ff46 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2736,8 +2736,7 @@ static int soc_get_playback_capture(struct snd_soc_pcm_runtime *rtd, int i; if (dai_link->dynamic && dai_link->num_cpus > 1) { - dev_err(rtd->dev, - "DPCM doesn't support Multi CPU for Front-Ends yet\n"); + dev_err(rtd->dev, "DPCM doesn't support Multi CPU for Front-Ends yet\n"); return -EINVAL; }