From patchwork Mon May 13 00:31:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 797288 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F25AEC25B4F for ; Mon, 13 May 2024 00:32:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 77A8CE65; Mon, 13 May 2024 02:32:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 77A8CE65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1715560371; bh=LpEgflAnaRpE4Ou+VTtJmDUg1kREtmzu8AUQFFn+8ks=; h=To:In-Reply-To:References:From:Subject:Date:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From; b=IvtBk/eZ9M9vAYwwKHxCPrp7kdj3y9DKjDDSO2IA+2ET175oiuRUZp02qxqsbTdpa d1ovKY8S3bk4Xu5kD7TEt1TikWbwPva3R/xOuWfXpYtjuTpuRTLPXJxvDcFEtnzKPp TMuPwn7daWk9WHiMj7iC/GblvFr+lNtTvpesMFyc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BEEF0F805FB; Mon, 13 May 2024 02:32:05 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1F277F805FC; Mon, 13 May 2024 02:32:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3FB1DF805D7; Mon, 13 May 2024 02:32:01 +0200 (CEST) Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c405::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DBE3EF805B0 for ; Mon, 13 May 2024 02:31:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DBE3EF805B0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=D7P6XUJx ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b//KgNpYaCSclrhrLVDUcST1F4Mt9rptDZUrO0PavInZR5Pasr1KfhFOApX9NcRq0a6IrSskPCr4yv9KREfOCrfYQsaxYRR8HlDXEY2da1wnaJJmv/xNY/9axyIgk8g0WwVtf/8VSFCq0L+H8WUtCj9J1ratWXAj5zicBR7s8UL8pO6EEENq5SoCX/Ss/nbohKeN6Wx6Hv4VCaNMfxjOp7rdoLYl7UD9wNZWxmv30r5BGgQYBdBiqA7kvyFLLwXbXotqneWOqZqMLhaUNsXedESTU6gZ8P53quWipw7eMpLMJQ0k/koA3ofCaEDx91w8nSAJlDuaX7pl5lv9SQeWyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N891GCPkFOK6Q9TdgM4xmubqMKrzaFgOQMTodNvQuvs=; b=nWVOPNesCc/BwtK1UhAK06jHit/N1WWmryBHgstY7Sl2iQMLSb+VUlTwnipFvkg2Y2LlbP3T8upSychV04W+t1b3OC6z2Hn7AtvU83blw84bPC3PLs33628vZBEkAPR6HnqbhyKV4p2ZFU2mkn4hoVWyhdAEv/8IlMZa+Od8ZYw70d/dDPUosjaKmzCyX92J0iNWlgbvIAlbc+xn3y9xwrQ8XKWNyUKjqKr0zh//KpFJRR+yHhABmr/Fgddv9g8GdJX9GYZhsFA7H7D71smCEm8Aj9K0/OQLU9EurTcte2bnyHGt5/ZpmEfprqlkvFvEOew7T1eQCiKsfaiKE4IL8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N891GCPkFOK6Q9TdgM4xmubqMKrzaFgOQMTodNvQuvs=; b=D7P6XUJxdq/970h3pqbx4nNnC7m6iUWrjo3ByFKe0oFhYYuUWaF3iw0rOhwaqtfMfHxI3ZPbEzcFfYI2Yixu6/3TcFM++BjKDNK2MarIflhzUrTA9+Cofqn3BuqKRUzS8dCBsINiOeq8ODeF/ThYgHZumF0tEIdIWPBCC7d1gog= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TY3PR01MB10906.jpnprd01.prod.outlook.com (2603:1096:400:3af::14) by OS3PR01MB7383.jpnprd01.prod.outlook.com (2603:1096:604:14a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 00:31:52 +0000 Received: from TY3PR01MB10906.jpnprd01.prod.outlook.com ([fe80::592:9b7b:ef57:2dd8]) by TY3PR01MB10906.jpnprd01.prod.outlook.com ([fe80::592:9b7b:ef57:2dd8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 00:31:52 +0000 Message-ID: <87le4ezh53.wl-kuninori.morimoto.gx@renesas.com> To: =?iso-8859-2?q?=22Amadeusz_S=B3awi=F1ski=22?= , Alexandre Belloni , Alper Nebi Yasak , AngeloGioacchino Del Regno , Banajit Goswami , Bard Liao , Brent Lu , Cezary Rojewski , Charles Keepax , Claudiu Beznea , Cristian Ciocaltea , Daniel Baluta , Hans de Goede , Jaroslav Kysela , Jerome Brunet , Jiawei Wang , Jonathan Corbet , Kai Vehmanen , Kevin Hilman , Liam Girdwood , Mark Brown , Maso Huang , Matthias Brugger , Neil Armstrong , Nicolas Ferre , Peter Ujfalusi , Pierre-Louis Bossart , Ranjani Sridharan , Sascha Hauer , Shawn Guo , Shengjiu Wang , Srinivas Kandagatla , Sylwester Nawrocki , Takashi Iwai , Vinod Koul , Xiubo Li , alsa-devel@alsa-project.org, imx@lists.linux.dev, linux-doc@vger.kernel.org, linux-sound@vger.kernel.org In-Reply-To: <87o79azh65.wl-kuninori.morimoto.gx@renesas.com> References: <87o79azh65.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v2 2/3] ASoC: soc-pcm: Indicate warning if CPU / Codec availability mismatch User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0 Date: Mon, 13 May 2024 00:31:52 +0000 X-ClientProxiedBy: TYCPR01CA0164.jpnprd01.prod.outlook.com (2603:1096:400:2b1::19) To TY3PR01MB10906.jpnprd01.prod.outlook.com (2603:1096:400:3af::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY3PR01MB10906:EE_|OS3PR01MB7383:EE_ X-MS-Office365-Filtering-Correlation-Id: 662768c2-0b69-44b1-6f0f-08dc72e415de X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|7416005|52116005|366007|1800799015|921011|38350700005; X-Microsoft-Antispam-Message-Info: HVcToIRM7Yr4ByKjWaLSPjxPaqqlo5qYDS3ZnM+Tq7+TfEmaCuvfFjngHWOC3meHaLNrLbhtIwA2ToF6XutYCcohtUTooKgjnljATIsng061q34mKdgRdLk7GxWN94Rxp5DR1/xEWAKOvZNRafEK050GHKQVEmB3gmhd1JXuHIzApze0drn6QqMcZkoQlOMXrVr2wri7R68Lk2h+2PD7HRFqKR5G9ljDcYhBXA6UhA+v66ZpMInY7Est5MHxlVNDiHpvsMszKANiWHK020My5w3wvX+DxW50QjQK1utKgi8/yQjVBbBYkct3DSD6tfnoojMHxeA8pcILHHaVUFFUUnoJdYP3F13rYk71VG3FVeHGlrMn33aXBHOsm5dD3n1S50grW3EizoCZSIGuPXDKIfYJK/mbQyVWmQ+QxF0X9W9KQM5K5PYnvYdvBF2dpN7bXNGgIKMN2Atet07ZEX0Td4BOHVOU1d1WtMKYUdQ7dL34iLSzezO1xP8pDoOny9UnfFHFmIxattNku3oVUn/jYoOkQJNOPTQSP1wxRw3NIT/M+axgJHMUJnIEFAGA96DJjbpROVbeoAKJFTPtkZupH6JWD6yFiYDTd9No5hvZJGhyau/LIgak/TLjtKbfR+IPaNCelj2jXkT9fQ2exVc0HNe7nNPy/TfabhTjs8q1K2r1A7d+nDbuzeR4Z6Vkb0hOcjBlAlcn/CwXPAq1dYWHw7vG1Os02dpv1BnR+OIJtzXIxKru45lRSh+JTQKo45haELyRf8rl3OrwmsbeY66AO1bAHpXQ2I0d0uFtgQvRc6/Yw4xZOAgBzfQX/SKck/8jZF9FQ4JNBJCmiegj6TmN+3xaWE0P1y3xc1YUtwAuvUbJ9QFOv/ge8ADh5RMm1SWHcNk/hy1ZG/gN2Xi4r4PmRKiP75CxXL2fI/2PAhYfW4aeSlE1T+Qg6/yiFVqTm7fdrPa5fULv+xhrg9Di6clV1oJGf+5yulZ3t1xAXH1fTGK/EkYJuryzQ8mSGyv1f5qIFpHQDiLt7odOt0JXmuylU7bbR8dX2OB0rDTZw3HxnwyVPZGvr8ju2M1HF088jXr6cWUK8N8LTWIsGpShRzIQd3dmDx+lHAhGY0kkB5w+8W97/GJxzS6ReHhjtfFOE2fwxn4qg61NSf4IO0a9lm1L0uVKzA3skNRTVTQpivgv2gk8KhP/6k/S5n1QtwWwlkvvPBpi4XrpmZhFi1tOm5URFAu3LehnWFr0zu2W5EAy1eajMR9mJcs44CfdRr54LncI93uydYxVOvuS/DpJBNfn5/JXckXWB/IJaIcCR5GuOvK4GTGDiiy7ikUxb4n7OfyHCRHvm2f2W7w7V5On69U4fw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TY3PR01MB10906.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(7416005)(52116005)(366007)(1800799015)(921011)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ul5/+qExd20JVhzC9FU/8M63tteuJHVRSuuro4wAardI8xz/Nq2OhuCaivzuhSyxPs7fTcS/OGqRLYnCnGil/VhsHtXwWRamflvGoIXSy2ikil6CRGj2XbXGCCJ/XzWUlOQDnayK+oiqsgd4/AX2b/zgaEmqOxlp8ct2wqX0icD8VJiEWtuuDxdcAOqc/zJDJO2TkAzaKH47liJ2fm1mBrKACYIsJ/pHu2WbQSw5mnAgG0HzPBNe+P65y4rInGzkh+fjxgZUq+78laH3FBvHLSI5q1UcgE6GSRUqGCCyRTyV7CCMY2nr6b3kRhJZMeQU1dbQbN00xnaYk2bqIjesr5PTss7rNSHXvgqMhpADJDdey3Wa9Bw+B3mhEJzN54LuBhltRsmGf158VfHKQWVArU+JCqEUEnpk3FK24z0uJod2Etf+uH9/ZGZbGrOP/obXaDGY9woOYbvVV/b5Nn9XvK0excPJdjT/6gyPF6X+fqyr5HvV0Wwf0nxQq9WNDSgb4NG1hdKPDcVWzu5RByYmw1gb5w6AzI6z/Hgnpfm/jRrQviEAjcLiKWDxAf+or8/oF27s4Bo9xnOmJB2bObFPAX8ZuWT9cWRmAHu3y3avX4jzfgzhSZOfWF4EI7tdKmx1kh3T29Br85nPxisJFN0DVzNNYGwwpNob1B1/MAIwsLOgeVrBJJLvtopRpQBqGtCkakHIG9ZsXnMKZpN0Eu+j3vWmW3j/x0r6uuD4SlmbceNm7QizmhmitqEVWajJIVrCc2+QQmosszQPtvckbAiXXC8D2RdWGIuOmuUkFLSvspjNlZ8vTVXDEiqe6OrrdTgTaEU/ojJw59POFVGH1rz6Zdg6k5t8qCd/c3sTLOs41pp1+qrELTuQl90MrcLiIBbY8v74RD/Zoy4qwc4JVY0i416DignhUDNRtuNw8ve33Gt+iZoUBIa+R0+WIF1UtT5hfns+ksCZx7zEQDsXY1gPlPAIngN9wjBOHaeCKdDeTyEPhh2eGu+foHwzUaduh/8JHwN6cW3qpEgHuEBAlYShA6zYtpCNrZaHhb7M/lvROYxAz09D/Z8F05KjqXqmy+Wlfbg5YdqwAD+c1nJX/I6IUuhU7do6+94+Z0fVp6CciG8xEIrZ+GNP054qYCA3/Fy1rNUr10aHwh6j5CzcmlYfosq8EDHwWHTvxTrc0hb50WXflbIS7l46FewTK0PLBRsi87HKCgjyhGHYApqKSLScFaWZRAOpWDVktoxCw3QV7lKdu7xiW8B01t5reYEhIw8ccJnERin6+O1i1OaJ4WowWsLfPElGz+2/QZdvSVj5kwUAtXAfe1pa52TUzEyOT5I1yxSYx5PiSXZn+L9VTQyFQi22qTlVVLDU7K5YsRXSS/jo/mDasj7daBkpItPH/L0ceOLyhCjvR8tHoKQJ6gjEOyvUZL6B87FdeitlTYTmTon9hNRIx7/DhzieGSWWo7Pu3ouDPWoAzk/WpOaSmWEyd3HbQQHiU/Z8EjoN2SnEOBriUpWtB/6IybBpUXYhoQleOXmqQlIkRmagmtCcomtEhuW3IUgnYmEZOjh1fd0yavAW8jUPcZuiC3DByVrLlcexQeZFZRcDI6zsz4DX6i7OOJkr+4EULvbmohnCiL8nejY= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 662768c2-0b69-44b1-6f0f-08dc72e415de X-MS-Exchange-CrossTenant-AuthSource: TY3PR01MB10906.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2024 00:31:52.5537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1U4dx8MfQ7tg62QFFBRb9+9t02SMg8s+cH5wzDIJiYKvqYbEngFyfCTKTagKEPXrzPlEn8Lk63UFb98NLWsiYNKMym2Z3Q9RkikbywyjpZ4YKdY3dTpailaWGLBMqQCV X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB7383 Message-ID-Hash: 4BP2XJQB73CKVP56GKJUYT2PSS4KVGG6 X-Message-ID-Hash: 4BP2XJQB73CKVP56GKJUYT2PSS4KVGG6 X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Current DCPM is checking CPU side availability only, but it should also check Codec availability. But because of long DPCM operation history, it is possible that the some Codec driver check have been bypassed. It should be error, but let's add grace time to update driver. This patch indicates warning in above case. Each applicable driver need to update during this grace time. Signed-off-by: Kuninori Morimoto --- sound/soc/soc-pcm.c | 45 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index c4d80cad5982..5729912ceff9 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2795,6 +2795,7 @@ static int soc_get_playback_capture(struct snd_soc_pcm_runtime *rtd, { struct snd_soc_dai_link *dai_link = rtd->dai_link; struct snd_soc_dai *cpu_dai; + struct snd_soc_dai *codec_dai; struct snd_soc_dai_link_ch_map *ch_maps; int has_playback = 0; int has_capture = 0; @@ -2806,15 +2807,25 @@ static int soc_get_playback_capture(struct snd_soc_pcm_runtime *rtd, } if (dai_link->dynamic || dai_link->no_pcm) { + int has_playback_both = 0; + int has_capture_both = 0; for_each_rtd_ch_maps(rtd, i, ch_maps) { cpu_dai = snd_soc_rtd_to_cpu(rtd, ch_maps->cpu); + codec_dai = snd_soc_rtd_to_codec(rtd, ch_maps->codec); if (snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) has_playback = 1; if (snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_CAPTURE)) has_capture = 1; + + if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK) && + snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) + has_playback_both = 1; + if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_CAPTURE) && + snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_CAPTURE)) + has_capture_both = 1; } /* @@ -2850,9 +2861,39 @@ static int soc_get_playback_capture(struct snd_soc_pcm_runtime *rtd, has_playback = 0; } } - } else { - struct snd_soc_dai *codec_dai; + /* + * REMOVE ME + * + * Current DPCM is checking CPU side only, but both CPU and Codec should be + * checked. Indicate warning if there was CPU / Codec mismatch. + * To keep compatibility, warning only for now. + */ + if ((dai_link->dpcm_playback || dai_link->playback_only) && + !has_playback_both) + dev_warn(rtd->card->dev, + "System reuqsts playback, but not available (%s)." + " Please update Codec driver\n", + dai_link->stream_name); + if ((dai_link->dpcm_capture || dai_link->capture_only) && + !has_capture_both) + dev_warn(rtd->card->dev, + "System reuqsts capture, but not available (%s)." + " Please update Codec driver\n", + dai_link->stream_name); + + /* + * REMOVE ME + * + * In case of there was no dpcm_xxx flag, and CPU / Codec mismatch, + * follow new style + */ + if (!dai_link->dpcm_playback && has_playback) + has_playback = has_playback_both; + if (!dai_link->dpcm_capture && has_capture) + has_capture = has_capture_both; + + } else { /* Adapt stream for codec2codec links */ int cpu_capture = snd_soc_get_stream_cpu(dai_link, SNDRV_PCM_STREAM_CAPTURE); int cpu_playback = snd_soc_get_stream_cpu(dai_link, SNDRV_PCM_STREAM_PLAYBACK);