From patchwork Wed Apr 30 12:00:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 29412 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f197.google.com (mail-qc0-f197.google.com [209.85.216.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E8BC4203F3 for ; Wed, 30 Apr 2014 12:01:02 +0000 (UTC) Received: by mail-qc0-f197.google.com with SMTP id i8sf5164117qcq.8 for ; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=lH3zg0VN/L3qvPyVd+kXTsmI7HOx997XFR0xLTeSF9w=; b=ZuYg5qqA/BEpbETKe+sbqgR1E9rRmKQjoyqSJ+68sBpO77NEFQaFiLocpyDekMx0HV Sr3NB9U18w/4+FWwJwOxlAdFnEhYKxrSlZO3sb1b0EMpK2NPRt4ijY1R+RC/s6TlMTjt +ATGO+gg+c/6U6UboscDa+LkSTwEI7v91wSCDcF8Yk8PHZmI/KBEe+pDWQtbCm0d1cXb HC0zp82oFfLOJiJ9vNiOK3DU9Od7TKj4P/TqYC0ngv1rqDy9UYXADFM+rCx7GdN0JywV KDZl35rSIRhOu0wiI5IZyuQu27+bMOvqRMlY9/kr2W9GLVKkAMOOAHG20iO3n1qkCZns EZ0w== X-Gm-Message-State: ALoCoQnr/sSGGL0K0CvPbiCfMCc81UkgFExdIIJtUGC+7/Eya8VW8QQ6f/8XkEYwlwC9ngoPNc9t X-Received: by 10.224.167.8 with SMTP id o8mr2159583qay.0.1398859262637; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.89.70 with SMTP id u64ls550055qgd.80.gmail; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) X-Received: by 10.52.69.146 with SMTP id e18mr3037947vdu.15.1398859262427; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id ui2si5248286vdc.154.2014.04.30.05.01.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 05:01:02 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id im17so2058844vcb.0 for ; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) X-Received: by 10.221.34.7 with SMTP id sq7mr3637004vcb.5.1398859262324; Wed, 30 Apr 2014 05:01:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp272871vcb; Wed, 30 Apr 2014 05:01:01 -0700 (PDT) X-Received: by 10.66.136.131 with SMTP id qa3mr7684873pab.77.1398859261287; Wed, 30 Apr 2014 05:01:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id yb4si16732989pab.308.2014.04.30.05.00.59; Wed, 30 Apr 2014 05:01:00 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758767AbaD3MA5 (ORCPT + 9 others); Wed, 30 Apr 2014 08:00:57 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:56924 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757878AbaD3MA4 (ORCPT ); Wed, 30 Apr 2014 08:00:56 -0400 Received: by mail-pd0-f170.google.com with SMTP id x10so1610920pdj.29 for ; Wed, 30 Apr 2014 05:00:56 -0700 (PDT) X-Received: by 10.67.14.98 with SMTP id ff2mr7637084pad.101.1398859253249; Wed, 30 Apr 2014 05:00:53 -0700 (PDT) Received: from [10.10.10.29] ([115.113.119.130]) by mx.google.com with ESMTPSA id el14sm134364359pac.31.2014.04.30.05.00.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 05:00:52 -0700 (PDT) Message-ID: <5360E5E7.8090807@linaro.org> Date: Wed, 30 Apr 2014 17:30:39 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Mark Brown CC: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, sbkim73@samsung.com, rdunlap@infradead.org, dianders@chromium.org Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board References: <1398243705-31151-1-git-send-email-tushar.behera@linaro.org> <20140424133920.GA12304@sirena.org.uk> <5359E18B.60600@linaro.org> <20140429222915.GU15125@sirena.org.uk> In-Reply-To: <20140429222915.GU15125@sirena.org.uk> Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tushar.behera@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 04/30/2014 03:59 AM, Mark Brown wrote: > On Fri, Apr 25, 2014 at 09:46:11AM +0530, Tushar Behera wrote: >> On 04/24/2014 07:09 PM, Mark Brown wrote: > >>> defined. Why is that? Also, why is the secondary I2S playback stream >>> not supported (this may be a reason to restrict to only the one I2S >>> interface)? > >> AFAICS, I2S driver doesn't support secondary DAI with DT (dai type is >> always TYPE_PRI in case of DT). Hence I could not find a setup to test >> secondary dai with this board. > > OK, that should be fixed at some point. I will hopefully be able to > look at this myself on the Arndale Octa though (or Chromebook or Arndale > once XCLKOUT is implemented). > XCLKOUT mux register (0x10040a00) is not part of core clock SFR range, rather it is part of pmu-system-controller node. One option would be to add a clock provider for XCLKOUT. That would require me to extend current clock driver to get the pmu-system-controller phandle which in turn is dependent on the patch to early initialize syscon driver.[1] Will it be okay to configure XCLKOUT in snow sound-card driver by taking the phandle of pmu-system-controller from device tree? The implementation is provided below. [1] article.gmane.org/gmane.linux.kernel/1679446 diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index 0fa89a4..d7fe7a0 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -15,6 +15,7 @@ #include #include #include +#include #include @@ -22,6 +23,10 @@ #define FIN_PLL_RATE 24000000 +#define XCLKOUT_OFFSET 0x0a00 +#define XCLKOUT_PARENT_MASK 0x1f00 +#define XCLKOUT_PARENT_XXTI 0x1000 + static struct snd_soc_dai_link snow_dai[] = { { .name = "Primary", @@ -66,6 +71,7 @@ static int snow_probe(struct platform_device *pdev) { struct snd_soc_card *card = &snow_snd; struct device_node *i2s_node, *codec_node; + struct regmap *pmureg; int i, ret; i2s_node = of_parse_phandle(pdev->dev.of_node, @@ -84,6 +90,19 @@ static int snow_probe(struct platform_device *pdev) return -EINVAL; } + /* + * On Snow board, SoC XCLKOUT line is connected to codec MCLK. + * One option would be to add another clock provider to configure + * XCLKOUT mux register. Else we can get pmu-syscon phandle from + * device tree and update the register here. + */ + pmureg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, + "samsung,pmu-syscon"); + if (!IS_ERR(pmureg)) { + regmap_update_bits(pmureg, XCLKOUT_OFFSET, + XCLKOUT_PARENT_MASK, XCLKOUT_PARENT_XXTI); + } + for (i = 0; i < ARRAY_SIZE(snow_dai); i++) { snow_dai[i].codec_of_node = codec_node; snow_dai[i].cpu_of_node = i2s_node;