From patchwork Sat Jul 27 13:40:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Audu X-Patchwork-Id: 816343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2BDAC3DA7F for ; Wed, 31 Jul 2024 08:50:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 888FB23E0; Wed, 31 Jul 2024 10:49:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 888FB23E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722415805; bh=r+dhww+Qqi4Jwf+59kLJSk6bzmgwKaWwB6UQ6V8q3kA=; h=From:Date:Subject:To:Cc:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=Db309VWxWNT5BnHGpaXAKItiJWlUHQpXOitKdWb6bub3E3B3bzB6c8vS/MHBEQddl tKQoa+BgJYayMp7gYGA3owNpctka4lOlA5DjPOsCtQvzQ1EwX5Mb+lVxnBn3XwGF/y dWYeosPgwuzQb0Td9NHE3484w41CWTLNJXnpahiM= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 83C9BF805FB; Wed, 31 Jul 2024 10:49:05 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E39E0F80604; Wed, 31 Jul 2024 10:49:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E6E45F8026D; Sat, 27 Jul 2024 15:44:42 +0200 (CEST) Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B3902F800C9 for ; Sat, 27 Jul 2024 15:40:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B3902F800C9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=ia3UWRJJ Received: from fedora.local (unknown [IPv6:2a01:cb16:6:5884:9994:cab6:56f0:715d]) (Authenticated sender: jau@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 3428E60141; Sat, 27 Jul 2024 15:40:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1722087641; bh=r+dhww+Qqi4Jwf+59kLJSk6bzmgwKaWwB6UQ6V8q3kA=; h=From:Date:Subject:To:Cc:From; b=ia3UWRJJBLrX5fupW1sc2Logaeogl/KXPBIEQTy3jlU1mU94QeYML95YCIOXhA9Ar KVu6FE52Q/ofxzNK4jBEqX1cU0VVJm/Cq1lVoYPCVJG2qczRVn5IA6A5s2xrmSBzRB gweuAIEEd/X8Q3Sp6rKvF5uphq1F/dA9zhRkc9HSDNFEqvMoHvMH7vaeoWny9Xv09K QaMV1jBCA4GmLzW6AE+oIKo7kcOeeu75mtwyD6J5fkLCQJKfRm1xJeaQRsBxxDh+Q3 UL9mZ9BWUxg5a3ewibQC9Wp3yp47nTHO7Oh60SGnO2Wz/290jmmepZ6AUBNniQtJzm DaiYkFPykB/Qg== From: Jerome Audu Date: Sat, 27 Jul 2024 15:40:15 +0200 Subject: [PATCH v2] ASoC: sti: add missing probe entry for player and reader MIME-Version: 1.0 Message-Id: <20240727-sti-audio-fix-v2-1-208bde546c3f@free.fr> X-B4-Tracking: v=1; b=H4sIAL74pGYC/3WMMQ7CMAwAv1J5xqgOEUFM/AN1SFqbemlQUiJQl b8TujPeSXcbZE7KGa7dBomLZo1LA3PoYJz98mDUqTGY3tjeGcK8KvrXpBFF30gnZ0UkGMsOWvN M3PT+uw+NZ81rTJ99X+hn/50KIaG/BOJRzjQGe5PEfJQEQ631Czs1wimoAAAA To: Arnaud Pouliquen , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Audu X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1722087631; l=3355; i=jau@free.fr; s=20240721; h=from:subject:message-id; bh=r+dhww+Qqi4Jwf+59kLJSk6bzmgwKaWwB6UQ6V8q3kA=; b=ZarBGTSz1xjIEXXH1wTTuH4cum1rX6cKT6MnHivk7q26E5+h/LQ4p2/N1N5qVXTwLA+524zh9 v+e4RMecMqOBPXENoUt16xiuHwbopAK7I7kCwcAhn5aYPI7qNHhtUVC X-Developer-Key: i=jau@free.fr; a=ed25519; pk=CfXLqyNBjY9A4RDoxPChE7qFvTjVyy0rJNTfI4JQ0dI= X-MailFrom: jau@free.fr X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: GIV5WKVE7WTWJGPCMQ6FUFDAEKA5ZAB3 X-Message-ID-Hash: GIV5WKVE7WTWJGPCMQ6FUFDAEKA5ZAB3 X-Mailman-Approved-At: Wed, 31 Jul 2024 08:48:45 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch addresses a regression in the ASoC STI drivers that was introduced in Linux version 6.6.y. The issue originated from a series of patches (see https://lore.kernel.org/all/87wmy5b0wt.wl-kuninori.morimoto.gx@renesas.com/) that unintentionally omitted necessary probe functions for the player and reader components. Probe function in `sound/soc/sti/sti_uniperif.c:415` is being replaced by another probe function located at `sound/soc/sti/sti_uniperif.c:453`, which should instead be derived from the player and reader components. This patch correctly reinserts the missing probe entries, restoring the intended functionality. Fixes: 9f625f5e6cf9 ("ASoC: sti: merge DAI call back functions into ops") Signed-off-by: Jerome Audu --- Changes in v2: - Update changelog - Link to v1: https://lore.kernel.org/r/20240721-sti-audio-fix-v1-1-a8b1ecf61cb4@free.fr --- sound/soc/sti/sti_uniperif.c | 2 +- sound/soc/sti/uniperif.h | 1 + sound/soc/sti/uniperif_player.c | 1 + sound/soc/sti/uniperif_reader.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) --- base-commit: 0c3836482481200ead7b416ca80c68a29cfdaabd change-id: 20240721-sti-audio-fix-1374fffb24e7 Best regards, diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c index ba824f14a39c..a7956e5a4ee5 100644 --- a/sound/soc/sti/sti_uniperif.c +++ b/sound/soc/sti/sti_uniperif.c @@ -352,7 +352,7 @@ static int sti_uniperiph_resume(struct snd_soc_component *component) return ret; } -static int sti_uniperiph_dai_probe(struct snd_soc_dai *dai) +int sti_uniperiph_dai_probe(struct snd_soc_dai *dai) { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct sti_uniperiph_dai *dai_data = &priv->dai_data; diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index 2a5de328501c..74e51f0ff85c 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1380,6 +1380,7 @@ int uni_reader_init(struct platform_device *pdev, struct uniperif *reader); /* common */ +int sti_uniperiph_dai_probe(struct snd_soc_dai *dai); int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt); diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c index dd9013c47664..6d1ce030963c 100644 --- a/sound/soc/sti/uniperif_player.c +++ b/sound/soc/sti/uniperif_player.c @@ -1038,6 +1038,7 @@ static const struct snd_soc_dai_ops uni_player_dai_ops = { .startup = uni_player_startup, .shutdown = uni_player_shutdown, .prepare = uni_player_prepare, + .probe = sti_uniperiph_dai_probe, .trigger = uni_player_trigger, .hw_params = sti_uniperiph_dai_hw_params, .set_fmt = sti_uniperiph_dai_set_fmt, diff --git a/sound/soc/sti/uniperif_reader.c b/sound/soc/sti/uniperif_reader.c index 065c5f0d1f5f..05ea2b794eb9 100644 --- a/sound/soc/sti/uniperif_reader.c +++ b/sound/soc/sti/uniperif_reader.c @@ -401,6 +401,7 @@ static const struct snd_soc_dai_ops uni_reader_dai_ops = { .startup = uni_reader_startup, .shutdown = uni_reader_shutdown, .prepare = uni_reader_prepare, + .probe = sti_uniperiph_dai_probe, .trigger = uni_reader_trigger, .hw_params = sti_uniperiph_dai_hw_params, .set_fmt = sti_uniperiph_dai_set_fmt,