From patchwork Tue Mar 12 16:12:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 779788 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 428C9C54E5D for ; Tue, 12 Mar 2024 16:13:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5D89DB70; Tue, 12 Mar 2024 17:13:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5D89DB70 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1710259997; bh=LJp6ddIBxKSeMRxJ3S+DBK5ZXqlfGj6rcL3czL4Snfg=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=ERA+FtTFXaAXwyl0dGw/+DOeKUX9npWvSuSCkU7eDvG4aSXFNVFMivC2JUTZu4uGs b7pvw0l2s9UJaXJfAY+ogyKNaiE97O2IZ7dolrfLLoe77GY7ATxrcs4MW9HF5f2Gkf 6S31XJHDX8BdGfqM3xAnL2ztTYU3k6ueS8qwrcXE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 53405F8057D; Tue, 12 Mar 2024 17:12:49 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id AA6C9F805A9; Tue, 12 Mar 2024 17:12:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D65ABF8028D; Tue, 12 Mar 2024 17:12:44 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BC406F800E4 for ; Tue, 12 Mar 2024 17:12:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BC406F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=H5C8q/QL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710259961; x=1741795961; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=LJp6ddIBxKSeMRxJ3S+DBK5ZXqlfGj6rcL3czL4Snfg=; b=H5C8q/QLcO3q6aNjxzYpaRFeLp6yM9NxvBNjQnZ3BGSCPUDg61Dwx2Zn PsIKPivlGpZhM3ZX+771AMsoaMaGKSNX9Oxiz8Ol5Q0HDkrNrwrFHgz04 aSFikhrLYfNWx7UBPLKukhPcQM9Wy8ZKniC8XJ/+owi4Dn4moBM8qHvcX XB8/wcawiRq2rp4fdCYYSElA/qAsRPZQaKsPkPfaQ3YBL7KSCKP7qaScw FuhuI88jOhdPwjFb96fHmYDHaBqm3zyfyihilZECKFOVxmk3vZwkGBXzr 7JJmBFbST+pbkvkiREa873Ma7N/o7v//4eOLHYCPaBYHXP0ubkqchMsEH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="16379603" X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="16379603" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 09:12:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,119,1708416000"; d="scan'208";a="11493432" Received: from yinnielx-mobl.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.212.74.193]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2024 09:12:34 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, Gergo Koteles , Shenghao Ding , Pierre-Louis Bossart Subject: [PATCH] ALSA: hda/tas2781: remove unnecessary runtime_pm calls Date: Tue, 12 Mar 2024 11:12:17 -0500 Message-Id: <20240312161217.79510-1-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Message-ID-Hash: LL3TJ75BWFLL6QFZKQN4G27NLQETLBXE X-Message-ID-Hash: LL3TJ75BWFLL6QFZKQN4G27NLQETLBXE X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The runtime_pm handling seems to have been loosely inspired by the cs32l41 driver, but in this case the get_noresume/put sequence is not required. Signed-off-by: Pierre-Louis Bossart --- sound/pci/hda/tas2781_hda_i2c.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 2eb1f9e443c0..4475cea8e9f7 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -796,11 +796,8 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) pm_runtime_use_autosuspend(tas_hda->dev); pm_runtime_mark_last_busy(tas_hda->dev); pm_runtime_set_active(tas_hda->dev); - pm_runtime_get_noresume(tas_hda->dev); pm_runtime_enable(tas_hda->dev); - pm_runtime_put_autosuspend(tas_hda->dev); - tas2781_reset(tas_hda->priv); ret = component_add(tas_hda->dev, &tas2781_hda_comp_ops);