From patchwork Wed Nov 29 21:28:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 748529 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 361D4C4167B for ; Wed, 29 Nov 2023 21:30:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C405384D; Wed, 29 Nov 2023 22:29:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C405384D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701293404; bh=sv7wIqGoko8jDyDNalpgXrfOYBuhs77xTTqM6kb7mvQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=VMB/TGpkLiI7Z/DlLganH/btcXmpSmWJV7XPpBgzr9Ld9vb92OKp9w1tOquWYymKn 7tmIuC2Ik2lIslXbYRCoTT+bJFLqYBEowL9PovIze7gIrkw7+bCs0X0c7fokojtH3T OtGBnpSgXBsWpsSZfZjpGAP9FFFfpnh7zS6me3tE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9FFB2F805F2; Wed, 29 Nov 2023 22:29:06 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B3351F805F3; Wed, 29 Nov 2023 22:29:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA932F805D8; Wed, 29 Nov 2023 22:29:00 +0100 (CET) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42246F8016E for ; Wed, 29 Nov 2023 22:28:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42246F8016E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Y42SlOJJ Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c9b5e50c1fso4100561fa.0 for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=Y42SlOJJWGP3xnpOGAVwIICosB4oWK1xlUmEjZYlgdx2O8I5QA0hBxRm8JIeOvVM/H tat1R3HQeO/Qc2tAfynxpwBnDHjAkHiYe4mtGcLVteUHCLBRqSnQhvq4IuzBjc7mkK5x tRwF2KYxxXY5WkDzaE8hRrhafVyRYSasNXS9lxAC+v3dxkUoXkT0SB6DfdSAEfVjXl0d 9FVVg6K4jPEO5+Ic5ejFR4jmTspwcDa8b7g3jrM+Hs1iMDnCa93N0lBCYHRSL40+FBFh kgmQiWqCHN5PjsiOxB4YEZZj2kTUmVTefRiOP0ODTq/9CEyozfAwGmQ7Fixj+YAbXl3Q 3N9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=A7Qn6pAzJterBe9SlTuw94tIqeDseFPpm1L0xGvSMLxGvWZIYXInekgpUQO8/ezZaM N0Pu5IxiT2wl2blM/lkqhru5SJIBVVK2PT5iA/5eW+SFvg6zqZmWGKM9wbzSSgQFVG+w oGZbfxymNhrbJ/Nt/zPiVXzGTXTQu7bl/f7McsKcS/ZTS98EUUFm7UNlczoQrB1QF44B VP8Y4l/Z2lvjBXbHhUb20rMKZCg6FSGYbg3kmCpKHF8WdNVQIe8NAo8aTSKlQqJWCbaR whkREWGnbk6rDyNRbtiMBXNQDo3aH0QKAfM6MqrvPeSWfO/ySvSbbM4eq14fAUuWVNrO QbGg== X-Gm-Message-State: AOJu0YwD0UAy2NOc4UqqTq+bn+j9AMB2zwfLiEHbyA296BMQOagSALuW CjBwkCYywzIKsVFiU40cQD2jPg== X-Google-Smtp-Source: AGHT+IEC56sw8UX2ii4LX1W7ed8InaZsSu/jcEIqr13PU5ZEBtax1tJX/hGuJk6YOIA9moirDg3WrA== X-Received: by 2002:a2e:874b:0:b0:2c9:c58a:b2f4 with SMTP id q11-20020a2e874b000000b002c9c58ab2f4mr1049900ljj.41.1701293323490; Wed, 29 Nov 2023 13:28:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:43 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:38 +0100 Subject: [PATCH 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-2-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 Message-ID-Hash: TKMBMR7D5CDB6G2MY6V72BZBLJOTBYFZ X-Message-ID-Hash: TKMBMR7D5CDB6G2MY6V72BZBLJOTBYFZ X-MailFrom: linus.walleij@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__);