From patchwork Fri Oct 27 14:47:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elinor Montmasson X-Patchwork-Id: 740745 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CDEFC4167B for ; Fri, 3 Nov 2023 16:20:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AB8EDF6; Fri, 3 Nov 2023 17:19:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AB8EDF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1699028445; bh=FvxH5GPEMJEVyDzetblKmOwn1pCBtisZhSSYxCUv+l8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=H++hMn88TS5nKb2nSUFvkKHbP4bE5p1xYPCcGARR3NXL7L5X377tSRmtlhw191yCn YguFDr7iIs+Jj5bVK+0oT2Y4GvSC9fdKWMsd7O2IPXLj006EtcJmcyPNm+meXnTb8Z hTtn6m1sb6Cdv+vUnRLqLxoOdXG0u3rjzKTw73bI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9219F805C2; Fri, 3 Nov 2023 17:18:16 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5CB1BF805BE; Fri, 3 Nov 2023 17:18:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1CB46F8024E; Fri, 27 Oct 2023 16:51:21 +0200 (CEST) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CC056F8010B for ; Fri, 27 Oct 2023 16:51:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CC056F8010B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=savoirfairelinux.com header.i=@savoirfairelinux.com header.a=rsa-sha256 header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=aQOjTCk7 Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id A535B9C3367; Fri, 27 Oct 2023 10:51:17 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id GDOt_IpZWaTR; Fri, 27 Oct 2023 10:51:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 361E59C336A; Fri, 27 Oct 2023 10:51:17 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 361E59C336A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1698418277; bh=8HGoMHANb/tdPqN6PKDlYl4GEq322Al+vUqvK5oUFQE=; h=From:To:Date:Message-Id:MIME-Version; b=aQOjTCk7HgfnzqMBnpl8ZvySGmSZk+IBB0SY0ZvtxMcc3oYPxOOyvyZ707qRvtsB5 OADAaB2eDmToJdO8XLwVOE4EFMkRCr5q1tQ1Ua9irCqCOtC1BwBpaOafTvAq2CQtQR XqbJ28cwp6nLJMcbxgNs1p7odvLLntm1V9Ut1xk9FknQgljdrIiitq45ODEfLJEwWl ALL/a+PIDOZpuA43d6djVjkGZooeiEYj626QDrz4F8Aiwtira1FrPWShWgy+l7ncIt 8ngXx3pJayDbJnku3VQ+nAfgURxGV3OOtplFsoqsppTIpoQb0/PQGR8j8dj8xX5q2H H1Bl45BDVe/pw== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id IgMBJNhPjrbM; Fri, 27 Oct 2023 10:51:17 -0400 (EDT) Received: from gerard.rennes.sfl (lmontsouris-657-1-69-118.w80-15.abo.wanadoo.fr [80.15.101.118]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id 4E0D09C3367; Fri, 27 Oct 2023 10:51:16 -0400 (EDT) From: Elinor Montmasson To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, broonie@kernel.org Cc: elinor.montmasson@savoirfairelinux.com, alsa-devel@alsa-project.org, philip-dylan.gleonec@savoirfairelinux.com Subject: [PATCHv2 05/10] ASoC: fsl-asoc-card: set generic codec as clock provider Date: Fri, 27 Oct 2023 16:47:30 +0200 Message-Id: <20231027144734.3654829-6-elinor.montmasson@savoirfairelinux.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231027144734.3654829-1-elinor.montmasson@savoirfairelinux.com> References: <20231027144734.3654829-1-elinor.montmasson@savoirfairelinux.com> MIME-Version: 1.0 X-MailFrom: elinor.montmasson@savoirfairelinux.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: ANBI7N7VP4SIA3F5IAB2DA2EMH6FKETO X-Message-ID-Hash: ANBI7N7VP4SIA3F5IAB2DA2EMH6FKETO X-Mailman-Approved-At: Fri, 03 Nov 2023 16:18:04 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The default dai format defined by DAI_FMT_BASE doesn't set if the codec is consumer or provider of the bit and frame clocks. S/PDIF DIR usually converts audio signal to an asynchronous I2S/PCM stream, and doesn't consume a bit or frame clock. As S/PDIF DIR and DIT are used as codecs for the generic use case, set codecs as provider of both bit and frame clocks by default. Signed-off-by: Elinor Montmasson Co-authored-by: Philip-Dylan Gleonec --- sound/soc/fsl/fsl-asoc-card.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 64f6bcf04720..61c0fd97cde3 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c @@ -723,6 +723,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev) generic_codec_dai_names[1] = "dir-hifi"; priv->dai_link[0].num_codecs = 2; priv->dai_link[2].num_codecs = 2; + priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP; } else { dev_err(&pdev->dev, "unknown Device Tree compatible\n"); ret = -EINVAL;