From patchwork Fri Oct 20 20:59:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Hasemeyer X-Patchwork-Id: 737310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD18CC00A8F for ; Mon, 23 Oct 2023 14:40:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D189C9F6; Mon, 23 Oct 2023 16:39:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D189C9F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1698072004; bh=RiC4CUPwQVZ5g0b9P+Y++/Y7a2cailDUgucK0AuK7es=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=d7IHvW7hqrgXfG7oDk6Eu67C4j6D/2xm9vVUzGmTot2jo1r3sE/ANNd9ZTRt0CyyH 3gF5dDGhq+D9ypg/ScxMNY0v+/idzF1a3Llfr+exZEOfUT2juawHMS0kkKYqEVyIi8 EhAj8cdZiAUHFu6vuHqyWwCEdM3l30GnwzyvMUkY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id AFC5EF80563; Mon, 23 Oct 2023 16:38:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0FEB3F8055B; Mon, 23 Oct 2023 16:38:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 66917F8027B; Fri, 20 Oct 2023 23:00:18 +0200 (CEST) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E58ADF8024E for ; Fri, 20 Oct 2023 23:00:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E58ADF8024E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=QDMCtdm9 Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7a67c3d62a3so43184139f.1 for ; Fri, 20 Oct 2023 14:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697835607; x=1698440407; darn=alsa-project.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yo+YzGcf5ti2JGohRAjm5fHeXV6DLkhxTHbBeTwM3H0=; b=QDMCtdm92gEIhszW9f7Z/BAt5zxQd6nd2HYe2mlWxGoGstaRExs5d2W/eUwbA0SV0m ClYSzzJCvuoaUmrAkAAd7PvS+keN/E1/ENFClyXtTvFyiF0cG+SGAEQ4U9zpGL9ObVuP WIygEXcB9YlFrbWxH4UtHe+n09MHRFy+Zyn3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697835607; x=1698440407; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yo+YzGcf5ti2JGohRAjm5fHeXV6DLkhxTHbBeTwM3H0=; b=ke254vmD7j009EuW/5En3HKsmEieig5DMf+yIgG5oYkWseSjxU6b3NQn2XD9RNv2GL kzwQnMr2AJMpbRzvbAVyeoT/71OHmqC4Go4Cx/Pf/Z7zmAyysnecyEPqn9hUxFIvwy09 PUPrpZ4K8cZxpapNXh08buwC/9L2Yim47HNr8ARj/6K1ZsDvO5UELbVXCnqN/sHMWpSp aPPN8S5nZ9S21jI2m0aBrWi8YzOh95A3tiEF9NcDzJ8P8Xv/6VKzk4lT2cDwQPsnbn9A A2yeCF1Zq6PAUriE602wi0DmPQVq0iz8WSzb1Dc2HA42zuZYc8kXiEjkIPi4r6AsZ+N2 DvqQ== X-Gm-Message-State: AOJu0Yyaz2eyAGMv6+ufoSmCavK50dnf54v+Z5KfvufYQm4qRsd+t6cP cLMc+7MtgLhnrybjZea33AkALw== X-Google-Smtp-Source: AGHT+IHLHEyod+8rFouea36HiEYaF4mxyr+6M++FfbGIBZU2nDJ69584ByMJ7vuTFzTPPec8CAEqCg== X-Received: by 2002:a05:6602:1355:b0:7a2:a6db:9a58 with SMTP id i21-20020a056602135500b007a2a6db9a58mr3565751iov.15.1697835607174; Fri, 20 Oct 2023 14:00:07 -0700 (PDT) Received: from markhas1.lan (71-218-45-6.hlrn.qwest.net. [71.218.45.6]) by smtp.gmail.com with ESMTPSA id y127-20020a6bc885000000b0076373f90e46sm850966iof.33.2023.10.20.14.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 14:00:06 -0700 (PDT) From: Mark Hasemeyer To: LKML Cc: Curtis Malainey , Mark Hasemeyer , stable@vger.kernel.org, Bard Liao , Daniel Baluta , Jaroslav Kysela , Kai Vehmanen , Liam Girdwood , Mark Brown , Peter Ujfalusi , Pierre-Louis Bossart , Ranjani Sridharan , Takashi Iwai , alsa-devel@alsa-project.org, sound-open-firmware@alsa-project.org Subject: [PATCH v1] ALSA: SOF: sof-pci-dev: Fix community key quirk detection Date: Fri, 20 Oct 2023 14:59:53 -0600 Message-ID: <20231020145953.v1.1.Iaf5702dc3f8af0fd2f81a22ba2da1a5e15b3604c@changeid> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog MIME-Version: 1.0 X-MailFrom: markhas@chromium.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: HQKFIHKYY73QJRY4FWKDCQL5ZTTXAJI3 X-Message-ID-Hash: HQKFIHKYY73QJRY4FWKDCQL5ZTTXAJI3 X-Mailman-Approved-At: Mon, 23 Oct 2023 14:38:20 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Some Chromebooks do not populate the product family DMI value resulting in firmware load failures. Add another quirk detection entry that looks for "Google" in the BIOS version. Theoretically, PRODUCT_FAMILY could be replaced with BIOS_VERSION, but it is left as a quirk to be conservative. Cc: stable@vger.kernel.org Signed-off-by: Mark Hasemeyer --- sound/soc/sof/sof-pci-dev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c index 1d706490588e..64b326e3ef85 100644 --- a/sound/soc/sof/sof-pci-dev.c +++ b/sound/soc/sof/sof-pci-dev.c @@ -145,6 +145,13 @@ static const struct dmi_system_id community_key_platforms[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "Google"), } }, + { + .ident = "Google firmware", + .callback = chromebook_use_community_key, + .matches = { + DMI_MATCH(DMI_BIOS_VERSION, "Google"), + } + }, {}, };