From patchwork Fri Sep 29 11:24:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= X-Patchwork-Id: 728123 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E3D4E80ABE for ; Fri, 29 Sep 2023 11:27:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 233B51F1; Fri, 29 Sep 2023 13:26:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 233B51F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1695986849; bh=n6j/8JbNexZ4eZNndUruxtY9Vtx+V07GnvEiTnjwOq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=XR0XbLAKGFZLobeGCYYTM7cO7mpmEVXRmiPaZx5xq6yufVtVRGQNb9KcLsfYtX1sD e4yxsKZnkh7pqroGVWKSNE2OuPxwKpsc3UMa0bBp12619bMVEttyrJeVDkGFmmUMy4 Aam9lbDDTpQpEZu4lr5XCCvlNnuzQ3lMAR7Ee5mA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D955CF805AC; Fri, 29 Sep 2023 13:25:08 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 50BE1F805AC; Fri, 29 Sep 2023 13:25:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F275F8047D; Fri, 29 Sep 2023 13:24:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 17666F80551 for ; Fri, 29 Sep 2023 13:24:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 17666F80551 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jeMLjf3J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695986682; x=1727522682; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n6j/8JbNexZ4eZNndUruxtY9Vtx+V07GnvEiTnjwOq4=; b=jeMLjf3JvGDKKig28uQcWYKVAkfiA/OigU3FF2E0nPYr2oyxRFyk1U+8 gsYupMK1tUNUYkcBjbR2tTD8vOLPq5MXKc3lBJYKlqkAJ70cZTEhMBwyR gRRa9vd3gcKon0vjJKOhFhUuaiawJEa2JNc4wlfbGHKRCW11C8eWR7mM2 A49VTj+zYr3kfzuC+0Qj1P/EXsdgEk0V6GwL5XXdrj0XvL/OH/iAHNndg CeyEP5s5JzI14CO9ZHq2sOqfhWyaRJi4heYMdk70YOeaVfdTkSp6QMvzn ewU6Lumv8QMFk093hvv8L3GdWUuszyAI+uWgEsvput7+1HBMEb+1jlUyb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="880267" X-IronPort-AV: E=Sophos;i="6.03,187,1694761200"; d="scan'208";a="880267" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2023 04:24:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10847"; a="753353787" X-IronPort-AV: E=Sophos;i="6.03,187,1694761200"; d="scan'208";a="753353787" Received: from dev2 (HELO DEV2.igk.intel.com) ([10.237.148.94]) by fmsmga007.fm.intel.com with ESMTP; 29 Sep 2023 04:24:37 -0700 From: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= To: Mark Brown Cc: Cezary Rojewski , Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org, =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= Subject: [PATCH 6/6] ASoC: Intel: avs: Drop superfluous stream decoupling Date: Fri, 29 Sep 2023 13:24:36 +0200 Message-Id: <20230929112436.787058-7-amadeuszx.slawinski@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230929112436.787058-1-amadeuszx.slawinski@linux.intel.com> References: <20230929112436.787058-1-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: SSIU5WDBU6DO2YNCOX2MS7JKEESFHA7W X-Message-ID-Hash: SSIU5WDBU6DO2YNCOX2MS7JKEESFHA7W X-MailFrom: amadeuszx.slawinski@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Cezary Rojewski HDAudio streams are decoupled on startup() and, decoupling them again on prepare() is redundant. Signed-off-by: Cezary Rojewski Signed-off-by: Amadeusz Sławiński --- sound/soc/intel/avs/pcm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c index 3f1f98e1a31a..7b84197bd8b9 100644 --- a/sound/soc/intel/avs/pcm.c +++ b/sound/soc/intel/avs/pcm.c @@ -350,7 +350,6 @@ static int avs_dai_hda_be_prepare(struct snd_pcm_substream *substream, struct sn format_val = snd_hdac_calc_stream_format(runtime->rate, runtime->channels, runtime->format, runtime->sample_bits, 0); - snd_hdac_ext_stream_decouple(bus, link_stream, true); snd_hdac_ext_stream_reset(link_stream); snd_hdac_ext_stream_setup(link_stream, format_val); @@ -615,7 +614,6 @@ static int avs_dai_fe_prepare(struct snd_pcm_substream *substream, struct snd_so return 0; bus = hdac_stream(host_stream)->bus; - snd_hdac_ext_stream_decouple(bus, data->host_stream, true); snd_hdac_stream_reset(hdac_stream(host_stream)); format_val = snd_hdac_calc_stream_format(runtime->rate, runtime->channels, runtime->format,