From patchwork Wed Mar 15 15:04:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 663475 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 830E4C61DA4 for ; Wed, 15 Mar 2023 15:13:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 33A7D1289; Wed, 15 Mar 2023 16:12:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 33A7D1289 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678893193; bh=w4dLN8vnz0yCwrrxTh+pYlgW8ahlVuhDBIx/FCLxdP8=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kUrME9O7mdaTmdS7yL8bX8OkEOD+ZvSRFaqSwB4d6XP6MUahhLV66PRmaNsVwgf9A UB75tJ0u5q8KST+6od9d+h+xynrbjt2cfgk1H2sZ8c63x5edmliyqidos3yO8YQvKU /8364OPHN4Tf0J+3lPrhnYlJWIeNms6K7HyCCRZE= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4AFF9F80588; Wed, 15 Mar 2023 16:09:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3C14F805E5; Wed, 15 Mar 2023 16:08:28 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9D4BCF80482 for ; Wed, 15 Mar 2023 16:08:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D4BCF80482 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjP-00075c-PP; Wed, 15 Mar 2023 16:07:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjP-004KTy-3i; Wed, 15 Mar 2023 16:07:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjO-0057cF-18; Wed, 15 Mar 2023 16:07:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaroslav Kysela , Takashi Iwai Subject: [PATCH 007/173] ALSA: mips/hal2: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:04:59 +0100 Message-Id: <20230315150745.67084-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1357; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=w4dLN8vnz0yCwrrxTh+pYlgW8ahlVuhDBIx/FCLxdP8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd09SBHfUjCSVLdffqXVvpqqUTipN8SdjwKpR x3BwH0I2MSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHdPQAKCRDB/BR4rcrs CTtaCACWs4vsGeD5p/wYsFYpwLVXLpnS57bjDFNvj0briuTOfEpDp+wU8fN3DIFpXwH1i5+xvyk pd2gOu+ANwE5ysJdgKhaV0JlPAyd2Wnh0IFdLFodNqeDP2dk0OnJIHBtT/y30002OrHwzPhb/ru LJR0jYKvMHi2H97idHI4povsOV84E4M/sRWuUcAX8steApa88Yy7mR9ZRWhzxvIEJ3EWA1xPiyA S1gwYQm+EY6xtEGLhmLNXPW2dEwc13FzPiV2byfVbUuVZZDdfOixWqM7pPYRnEZEGyEmZi3c7CJ 5psRY2nTmXcvls4oFVukzWv2lKXM9mlzYMt/KWeYXRiAla/8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: YBXUDU4FPSTWCOTDMEA2JIYNFCMTPLID X-Message-ID-Hash: YBXUDU4FPSTWCOTDMEA2JIYNFCMTPLID X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/mips/hal2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c index 9ac9b58d7c8c..3c26334227bb 100644 --- a/sound/mips/hal2.c +++ b/sound/mips/hal2.c @@ -877,17 +877,16 @@ static int hal2_probe(struct platform_device *pdev) return 0; } -static int hal2_remove(struct platform_device *pdev) +static void hal2_remove(struct platform_device *pdev) { struct snd_card *card = platform_get_drvdata(pdev); snd_card_free(card); - return 0; } static struct platform_driver hal2_driver = { .probe = hal2_probe, - .remove = hal2_remove, + .remove_new = hal2_remove, .driver = { .name = "sgihal2", }