From patchwork Wed Mar 15 15:07:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 663417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A39DC6FD1D for ; Wed, 15 Mar 2023 15:43:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E1E1113FC; Wed, 15 Mar 2023 16:42:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E1E1113FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678895025; bh=353bY49l/dkMVarksV1RC/m/kOWxhIRbESGYmQm3iVE=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TshbRWhNAYcbeRIEVMFj6YIULl3npQ0KzNOlmvUfli4Slc+vc60qS2robRlqPywtK x2dnkQUQ3O1YrmTnqX1A2Afj0WIaCf5JHXbtnDwM+wsxfpPrm7Vkb2CgR0Kj8NLeUz f0ZBjkVlLwqdQJYGTD/tmQur+jkUWUOgkLnLEju4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 43AFFF80C8C; Wed, 15 Mar 2023 16:15:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F050F8055C; Wed, 15 Mar 2023 16:10:23 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5A370F80549 for ; Wed, 15 Mar 2023 16:08:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5A370F80549 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSk2-0000ea-EJ; Wed, 15 Mar 2023 16:08:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjx-004KgJ-Of; Wed, 15 Mar 2023 16:08:33 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjw-0057mK-NY; Wed, 15 Mar 2023 16:08:32 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Peter Ujfalusi , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Subject: [PATCH 163/173] ASoC: ti: davinci-mcasp: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:07:35 +0100 Message-Id: <20230315150745.67084-164-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1577; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=353bY49l/dkMVarksV1RC/m/kOWxhIRbESGYmQm3iVE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd8cVkLE5YE5+//JlJ/MR3AVlZGs5ari7NBA/ cPwh2Q9WiKJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHfHAAKCRDB/BR4rcrs CWZcB/97T91Bl01ybJa1gwrpUzDin2qTQaLEJIvJnQoRtF6kvoU2eqnpM52lknDxs37oCuW6Lgs OIxR/52deRldZYcZ5BXgBPM6JesXxuc6U4ep2nApY4laZOvZ5jLZB/Txd7Y2Ip4gKHRwoCxzDDF PK1tuD6Wx7ynItpSsxeaPTDMatv3kWRuaaeFMMvrh0cA7s5vIwDrV33w8D6VUn4oljpAJgQ3I00 YqKEGYyBxGMzKVR8ioaHFYM9Psl1Vn6VtYWDekzQjWJtCZrh5oIhqHCEatosqghgKnrhn8hoUt0 +5tTHTtGurS/YMtedA8IDQTCzPQwNlp2J2cw005PuXWjiXKq X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: 4FQGS5IQKRUU4NA7EZPTCOPYA6PT47NP X-Message-ID-Hash: 4FQGS5IQKRUU4NA7EZPTCOPYA6PT47NP X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/ti/davinci-mcasp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index 578254549d2d..c0892be2992b 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -2461,11 +2461,9 @@ static int davinci_mcasp_probe(struct platform_device *pdev) return ret; } -static int davinci_mcasp_remove(struct platform_device *pdev) +static void davinci_mcasp_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM @@ -2531,7 +2529,7 @@ static const struct dev_pm_ops davinci_mcasp_pm_ops = { static struct platform_driver davinci_mcasp_driver = { .probe = davinci_mcasp_probe, - .remove = davinci_mcasp_remove, + .remove_new = davinci_mcasp_remove, .driver = { .name = "davinci-mcasp", .pm = &davinci_mcasp_pm_ops,