From patchwork Tue Mar 14 15:34:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 662995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92D64C6FD1F for ; Tue, 14 Mar 2023 15:35:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B10CF135F; Tue, 14 Mar 2023 16:35:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B10CF135F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678808153; bh=1G1zMeht/WlyuhmuonP+l4frSpmQIv6r742X7ZAq8Jg=; h=From:To:Subject:Date:CC:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=hvMvXPDceUZMO4AvxaWBxSJ2JAbUrllMQzEdeZpi7KKQH0P8LfR2wdkGQ52OqWSMd gPGYNaBs3ar1Pt0ekZMwxB4zMKMkwaUP0cAdV5m4Oi8QDogpQJEV1bwwqxe92rA1MI Vnwdh/tkj7uuU73gA/rZT0dQ38lixtosqjJPcgs4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 056FBF80423; Tue, 14 Mar 2023 16:34:40 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 38CADF80423; Tue, 14 Mar 2023 16:34:36 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0627.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::627]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5433FF80093 for ; Tue, 14 Mar 2023 16:34:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5433FF80093 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-NXP1-onmicrosoft-com header.b=WTtW9iMb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2moNVOv3A3Lc08X3LNexfxfkuac3OLX5voPpQ1lN4cnEzdSqokRkPiIt+j/nUX/ex4Dgm55oSwzNfgtJjVqAH8zoI1xNX/uh839G7b5EmX7+Id8eJbGjKuY2Aem8MkwwDVMaBB+bjHVrnPBD0opnVthuAN2vTmBrcSG8JilNhydbvjvl+u50BFioz1hJMQEoHaUcOqA+8qK5MR2cm33bal88vhM5uIXMXFs5vr5eDx1mjVGQDln+oZVcMHNQUzhGPJOzO7I2D+8Vlyk5w7QUt7/uMLQRh3ox5MYXwKRqmvWoXJrB0CqivCUfG80+zEeyY2xKA/iFLCI3Q4f4wBuyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9oiEE/Se8r5+8USjZJ3+s8fYimwB6HJy4aLNW7gkBhU=; b=FWGTVB/6kqqSa6zhY+p0Q0775KRVM7hXeHgKwm4rt5PxytK75Rtbf5pU0ruKT8KmqLVHbJzBnyJ/Vc72WKIkJT/Lf+PxG0KxjqCBkgY5IqBkVzeBvxXsIVqGYvOU1JdtOtXRJJaWXqeoy1hU6M0sS2F2uK0MUcR27tar3jmcjTrLz0A3L0TcuHyP8lx6bMxxPvEbBiNU2vuBNTGnh8Fi9Txtou2+zwf3Wvx6651ds/9aSdsCDs5n7nfD5xXxG6p925scoB6iEK2NRcfDHB15VM9qZH2z9azfsK22mw/2Gj0KmYxzJ7a5kdJvqZM53x+f9v/TvrJePFydmTAVRKkABA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9oiEE/Se8r5+8USjZJ3+s8fYimwB6HJy4aLNW7gkBhU=; b=WTtW9iMbCgx/eRqJlIamFN6l5WS3n+BMKI428oZ2tf1OZybCodl2436ZrlbH+o4zCewleTvciS2wzof/tIgbQiVMT+9TNULFezjPm+x42niVhdawlss4dcEVgas7Nqtc/WsNf6xAw1dJ0dyHTpxUOGAlNt2G42UDAK1lCgDq47g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5151.eurprd04.prod.outlook.com (2603:10a6:803:61::28) by VI1PR04MB7055.eurprd04.prod.outlook.com (2603:10a6:800:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Tue, 14 Mar 2023 15:34:24 +0000 Received: from VI1PR04MB5151.eurprd04.prod.outlook.com ([fe80::f922:7fbe:d027:5597]) by VI1PR04MB5151.eurprd04.prod.outlook.com ([fe80::f922:7fbe:d027:5597%3]) with mapi id 15.20.6178.024; Tue, 14 Mar 2023 15:34:24 +0000 From: Daniel Baluta To: broonie@kernel.org, alsa-devel@alsa-project.org Subject: [PATCH] ASoC: soc-compress: Inherit atomicity from DAI link for Compress FE Date: Tue, 14 Mar 2023 17:34:09 +0200 Message-Id: <20230314153409.1805280-1-daniel.baluta@oss.nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: VI1PR06CA0213.eurprd06.prod.outlook.com (2603:10a6:802:2c::34) To VI1PR04MB5151.eurprd04.prod.outlook.com (2603:10a6:803:61::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB5151:EE_|VI1PR04MB7055:EE_ X-MS-Office365-Filtering-Correlation-Id: 026bbd4e-fdff-480a-1bb4-08db24a1964d X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nbw+P6F36dyaBNpMgjMCvrlk2dx96F9nT4sv8GG82e08NM/X4hjt/Xj00O0k8faSPHic/e4zPmW+aBXJYmOnapnQKTzo1qfqTFBEMV+qxpQSXqr9k0dbrdsMeNjoPjuqVIcJnkkZkoTzsI3nQFOt6aDuAatXDsbSR0MmSXS6WTnA6Ri5RoXlmmhq/T/iCHwD99HMtjdX0s1b3Qh3AEHmtcnNtam2s+fGsj0WzgEmnBR6s3eVi7pD8HtDmqKA/9+MPB1JgPfxLVFmw4zynSWveZf6XbQPxhwE1TqFuM4G254gKNU9uT0BKu7vxPc/CM8OYLJf7OViKaywAeL0vx/B9FzBXZb3admoh+HdfTky49E9WHhwVxAvwnPGkmCPYlKkJgjjDgsx4WumBEz9J4noNyETIoiz/6hAwf4+GtuUKbciLhZDmIVBylDdoFr1LdA9BZZZeqre1k34Uw4GiyF6CLfxd6GZJ6b6QpwnH+eIFus32kMGbF1/SRbF+Iv0wzud48Qx4VeSTMc9ktiXwVe6S0n2cwvGQ+Lt7vZnERZs9gXJgpR6UZB+OduXz0nbit19s7tatAvb++cfjQdbraGw+iWh+YQ0r+yH8NTJbYY+ErV6VBsW/PdIkReOuR0vp0SqQ13vbekH03rNUDdbdsjy6oN7V9lsG4/6TtNa87Yy+QuVOXeT9epytRdNzKmkYl3rlNVld/kNEfyGUgNOli5T3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5151.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39860400002)(346002)(396003)(376002)(136003)(451199018)(8676002)(478600001)(44832011)(316002)(66556008)(4326008)(66476007)(66946007)(8936002)(5660300002)(2906002)(41300700001)(86362001)(6486002)(26005)(6506007)(6512007)(1076003)(6666004)(2616005)(186003)(52116002)(38350700002)(38100700002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ess1RHlSc7zim2bNerSXh5cuFkzLVPIRAxkmoAZ3N51OEof56c6OVWAy1+F5/OuAg+EONpVNNH/BwiGdEHuuZzVdLZT/5pUmhVj2vRi76j506wkRP1k61cwfMxL/MrvFfmvFFmrEzL9VGEEoYkhhaQFvJHMFaHlKyQS/NAMHHdfab9puDAn1Pf0zqaBQ/tHxke0NQlYgDqAwC3Ge+zGBrXb6J79WbTtAfok0DXlbKdu6t3kP+5eJIxjdIA9xXA++c2s0ERvagRH4KFUo+ja4zPpTOHxfDy6OQg1ZQS65JFeWArQp1QxdXgRQfCEKpFephv0k641Yn5ikCzhc90PaHt9k5N9aB5ylUMkHzVdA50KxtaWTcBq9QNnQOobolM9zpPL8M/mQoCrqgSDkgDa87uSjCLR5TUERWbRfLbltWN8W1XCTZsJ+4409s4bq8fpWxvFBMMNYd9VntLZBzoHPj2l9Gt+bZjp0A0Uj1w/RxXyf3XiLybYqUtN5b2a22mn87KTKT5ETivzKPeMFZ+ZCbFPvdQTWi27Ty/JSSjH87sQU4s8NkB/3bK9BJzC5WukduZ+2xObn4zsBOdl2+LYm/vervdfO8GgqVm+/m9oqwoqVtSp5kL12waNk0dDyK8uniJg+U4hXYXTb+lElacIXj3OxXgXyeVgeeJkqKkUyH/Wrj2nsEu+pvq9v1Figs2y7wVlR5BCs2DHgkqifgcQrdqEdm1MQRHpN3iJcrwp6ZEjDjqffSpt6eCyAuvEUvAUR0Vgk/aHmvwAD3ndfSHHQj+5SGliwjiLjUYDawTS7XLdq2ESOZ4JoPZrGYsts7/wR6pNTNo4+70pGhRFQ3MYcMkKWDHyn0MrTvCSpbLQIl/1VB+r1i1iC5JSn//sKzv9HVGg1LBPrKLd/35H0u8/ptG4IuZ8TH0vs2ChGIMSL1FTwhZr0G8nr+/bJRHHEEQq9WduISVBiZOhX093QfqRRuOrhjI2W6CEhSC0FIFwN2fgqLkRwWNt9QbknbXub1m81rulqE7E1Mv6PyZRK/FBEYCEW4onsrm3JLp2wAutDOCIZj8764P08m/Gf0YCgoFguMKI+4KKB7BUscHRP2lcO6lX6lJMyWnGK0V30a9t/0gVYuhxt2RtuDyYlYsIZ1UsVoBAmjF6uEfusIP0m2Gg6PookD25Ab+NmCUfa6gKLgeyRdujjJYuKbNN0VnslmvptVrgd+3I5CkUCDfT//mRbjtdPNYjy3r7dFpcsKXMYAp2IPC4jwREF2OXIEkVRdsDoWqmJOyNPRHEouGqmjCFCa76fH8gKEDJ+SAMQhmotUtA1DNshRwhp07lov6G+wdeOSvW7wmhAFouIPznx9iQN42e4OLBSJeqz221bPqfnJczXxCm4Hrr4o+vmTSiz9ztZxEMztZ1CSsIzpyGpEDoqH019RAXN6BJYAVSjivJrCHguFod8PF2cW2v2TFcdqmRmtn4eswlMrCKD4nlBhu6mBzSIjcsvYhFVmgpzGi6LGr6nzHPxqadjGtglzq7dv6nNzzVpbZW2vM0U+aq6/q+tn8i1OFJvrfn09jpCbJNn+Bgi2um6nkquZLsMNh4bBejzO0hwlEuLgy07VWNQZeZlBA== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 026bbd4e-fdff-480a-1bb4-08db24a1964d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5151.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2023 15:34:23.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sLgsGnc1CoSKOnYDs9Ezkjwy4Ay2pdgXyE4ZIc2M203+kgEJB/EhjKtwkjY2v4s/1c9Jk2DLSs0rAf9NXfPKWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7055 Message-ID-Hash: H3PTUIVJVPTZCY7DMJTA5QIFMBWLNUU5 X-Message-ID-Hash: H3PTUIVJVPTZCY7DMJTA5QIFMBWLNUU5 X-MailFrom: daniel.baluta@oss.nxp.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: lgirdwood@gmail.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, linux-kernel@vger.kernel.org, daniel.baluta@gmail.com, paul.olaru@nxp.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Daniel Baluta After commit bbf7d3b1c4f40 ("ASoC: soc-pcm: align BE 'atomicity' with that of the FE") BE and FE atomicity must match. In the case of Compress PCM there is a mismatch in atomicity between FE and BE and we get errors like this: [ 36.434566] sai1-wm8960-hifi: dpcm_be_connect: FE is atomic but BE is nonatomic, invalid configuration [ 36.444278] PCM Deep Buffer: ASoC: can't connect SAI1.OUT In order to fix this we must inherit the atomicity from DAI link associated with current PCM Compress FE. Fixes: bbf7d3b1c4f4 ("ASoC: soc-pcm: align BE 'atomicity' with that of the FE") Signed-off-by: Daniel Baluta --- sound/soc/soc-compress.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index e7aa6f360cab..d649b0cf4744 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -622,6 +622,9 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) return ret; } + /* inherit atomicity from DAI link */ + be_pcm->nonatomic = rtd->dai_link->nonatomic; + rtd->pcm = be_pcm; rtd->fe_compr = 1; if (rtd->dai_link->dpcm_playback)