| Message ID | 20230208101545.45711-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 679ee73bbee28cab441008f8cca38160cc8f3d05 |
| Headers | show |
| Series | [v2,1/7] arm64: dts: qcom: ipq6018: align RPM G-Link node with bindings | expand |
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: > Bindings expect (and most of DTS use) the RPM G-Link node name to be > "rpm-requests". > > Applied, thanks! [1/7] arm64: dts: qcom: ipq6018: align RPM G-Link node with bindings commit: 679ee73bbee28cab441008f8cca38160cc8f3d05 [2/7] arm64: dts: qcom: qcs404: align RPM G-Link node with bindings commit: 7bf30eb441b3bdaa368e65837a03f9fbba033180 [3/7] arm64: dts: qcom: msm8996: align RPM G-Link clock-controller node with bindings commit: 407ef897bd0275e38ae33d410857e71c092679bd Best regards,
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: > Bindings expect (and most of DTS use) the RPM G-Link node name to be > "rpm-requests". > > Applied, thanks! [6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0 [7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813 Best regards,
On Wed, Feb 8, 2023 at 4:16 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names > property. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. None. > 2. Previously was sent as separate patch. > > There are no strict dependencies. This can go anytime. The next patch > (glink-rpm-edge) should be applied in the same or later cycle (could be > via different trees). Except that without this patch there is now a warning in linux-next. Rob
On Tue, Feb 14, 2023 at 11:28 AM Bjorn Andersson <andersson@kernel.org> wrote: > > On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: > > Bindings expect (and most of DTS use) the RPM G-Link node name to be > > "rpm-requests". > > > > > > Applied, thanks! > > [6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema > commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0 > [7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description > commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813 You need to apply patch 4 too. There's a warning in linux-next now without it. Rob
On 15/02/2023 15:10, Rob Herring wrote: > On Tue, Feb 14, 2023 at 11:28 AM Bjorn Andersson <andersson@kernel.org> wrote: >> >> On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: >>> Bindings expect (and most of DTS use) the RPM G-Link node name to be >>> "rpm-requests". >>> >>> >> >> Applied, thanks! >> >> [6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema >> commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0 >> [7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description >> commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813 > > You need to apply patch 4 too. There's a warning in linux-next now without it. Bjorn, can you grab patch 4 as well? Best regards, Krzysztof
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: > Bindings expect (and most of DTS use) the RPM G-Link node name to be > "rpm-requests". > > Applied, thanks! [4/7] dt-bindings: mailbox: qcom,apcs-kpss-global: drop mbox-names from example commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a Best regards,
On Wed, Feb 08, 2023 at 11:15:42AM +0100, Krzysztof Kozlowski wrote: > Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names > property. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. None. > 2. Previously was sent as separate patch. > > There are no strict dependencies. This can go anytime. The next patch > (glink-rpm-edge) should be applied in the same or later cycle (could be > via different trees). Jassi, I missed this note and merged the following patches, introducing the forecasted issue in linux-next. To remedy this, I took the liberty of merging this patch as well into the remoteproc tree. Regards, Bjorn > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 943f9472ae10..56b386b688b3 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -155,7 +155,6 @@ examples: > interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>; > qcom,rpm-msg-ram = <&rpm_msg_ram>; > mboxes = <&apcs_glb 0>; > - mbox-names = "rpm_hlos"; > }; > > # Example apcs with qcs404 > -- > 2.34.1 >
On Wed, Feb 15, 2023 at 1:19 PM Bjorn Andersson <andersson@kernel.org> wrote: > > On Wed, Feb 08, 2023 at 11:15:42AM +0100, Krzysztof Kozlowski wrote: > > Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names > > property. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > --- > > > > Changes since v1: > > 1. None. > > 2. Previously was sent as separate patch. > > > > There are no strict dependencies. This can go anytime. The next patch > > (glink-rpm-edge) should be applied in the same or later cycle (could be > > via different trees). > > Jassi, I missed this note and merged the following patches, introducing > the forecasted issue in linux-next. To remedy this, I took the liberty > of merging this patch as well into the remoteproc tree. > No problem. Cheers.
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote: > Bindings expect (and most of DTS use) the RPM G-Link node name to be > "rpm-requests". > > Applied, thanks! [5/7] dt-bindings: soc: qcom,apr: correct qcom,intents type commit: b5bec0f00ee1c52ff0965a5dba4c91c413a6f3de Best regards,
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index d32c9b2515ee..bbd94025ff5d 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -176,7 +176,7 @@ rpm-glink { qcom,rpm-msg-ram = <&rpm_msg_ram>; mboxes = <&apcs_glb 0>; - rpm_requests: glink-channel { + rpm_requests: rpm-requests { compatible = "qcom,rpm-ipq6018"; qcom,glink-channels = "rpm_requests";