From patchwork Wed Dec 21 10:23:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 635977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4734C4332F for ; Wed, 21 Dec 2022 10:27:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1342616BC; Wed, 21 Dec 2022 11:26:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1342616BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671618469; bh=fcHxp6xzffuBwUiPQ9VbkO96PvX/aCLLNmhxVnc0Eas=; h=From:To:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MuDaG6ws2F3lCpkW8UZbL24I5JwxZy3ZUlWGNPMdhYmi/l5VUE5MG3rzao/VpWwN0 kuXqSCCLkdwQ35lekUnMA4g34sqc1/1f5Jvgflw0hF2NLYLN3cFtf09sYaYC9sb6bc 9irXjH8Ldpi/pKEXo8LLWVVHFjdkcJGyuMLUUei8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D8B82F80588; Wed, 21 Dec 2022 11:24:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 36A8FF80022; Wed, 21 Dec 2022 11:23:55 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 49F9EF80022 for ; Wed, 21 Dec 2022 11:23:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 49F9EF80022 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=d3hl8VSA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671618234; x=1703154234; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fcHxp6xzffuBwUiPQ9VbkO96PvX/aCLLNmhxVnc0Eas=; b=d3hl8VSAb7EZiLWy317/LToYtaa+hJZkYJCwnfXSgA8GpntPXahQaTz5 U7gET1t6yvPC2GX7PdCS0rUTEMnX8Pj/C2iqXKlCON8p3Wq4E4UzZPl+O dgirxhZZet+BxVMTKObkA0iczSa4DxFwxD33KVFE9CyvRNSqCNsBuWpwP ABnDBwVaMiORyvnxnFMVYYEkrusE9/FOm7NvZvLQxH5MiB8uso6hVAPon yINKLhG9ByqlUZWy+ty1nszhYf1OEguEezzB+mFwNS8k26WrnAWQpUSI8 p2m1DQcdXLzu73//9ORYO/NrlBJut+lLwT1XNS9DCu9ZW0nutbEqUp4lZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="406078715" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="406078715" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 02:23:51 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="681984443" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="681984443" Received: from cofearra-mobl.ger.corp.intel.com (HELO pujfalus-desk.ger.corp.intel.com) ([10.252.20.202]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 02:23:48 -0800 From: Peter Ujfalusi To: lgirdwood@gmail.com, broonie@kernel.org Subject: [PATCH 11/11] ASoC: SOF: trace: No need to check for op pointer in sof_fw_trace_free() Date: Wed, 21 Dec 2022 12:23:28 +0200 Message-Id: <20221221102328.9635-12-peter.ujfalusi@linux.intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221221102328.9635-1-peter.ujfalusi@linux.intel.com> References: <20221221102328.9635-1-peter.ujfalusi@linux.intel.com> MIME-Version: 1.0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.intel.com, rander.wang@intel.com, ranjani.sridharan@linux.intel.com, yung-chuan.liao@linux.intel.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" If the sdev->fw_trace_is_supported is true then we must have the fw_tracing ops set, no need to check again. Signed-off-by: Peter Ujfalusi Reviewed-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Bard Liao Reviewed-by: Rander Wang --- sound/soc/sof/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/trace.c b/sound/soc/sof/trace.c index 0e92269c4a00..b2ab51e5214a 100644 --- a/sound/soc/sof/trace.c +++ b/sound/soc/sof/trace.c @@ -20,7 +20,7 @@ int sof_fw_trace_init(struct snd_sof_dev *sdev) void sof_fw_trace_free(struct snd_sof_dev *sdev) { - if (!sdev->fw_trace_is_supported || !sdev->ipc->ops->fw_tracing) + if (!sdev->fw_trace_is_supported) return; if (sdev->ipc->ops->fw_tracing->free)