From patchwork Sat Oct 15 00:12:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 615231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8803C433FE for ; Sat, 15 Oct 2022 00:13:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2612672EA; Sat, 15 Oct 2022 02:13:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2612672EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1665792836; bh=shOX9kfX1Rh6vXzWbwOdxyQ42SN6zQjnm/Kdib8Mep4=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=J7UTbPeJxLgKCIPgR7iasBLtYfQFeCOIL2uyTwdm4Wce5wVz7SpOgY2YXd5JFaLRL E8Icle2G8bkD5FvCBKrN/1/tlr8M/aUEcDNZWVQ3TYjKSUH8Om1vUqJUZ6s3Zm5dZ6 zRNtWhggd5egyWb+ES0quRew+il7K6BgH2fN4eEE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C691BF801F5; Sat, 15 Oct 2022 02:13:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 225B5F801F5; Sat, 15 Oct 2022 02:13:04 +0200 (CEST) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4749BF80115 for ; Sat, 15 Oct 2022 02:12:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4749BF80115 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ekN/1fFj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=KNt+pCSIUZ9+O3L8HoQe1tmbspN8QLuURkdKt3vda7s=; b=ekN/1fFjDh8HdTdr8OyIHH1VZ3 1B+vgd01iZnf/itUErKgBI6cOUZdEIryUBIi7QTCLZGMstfAxWfeAYPvlo3CFivnE+wQHPSrzYW0O acGL9OA49uWn03sKPDxKg9XgnpIgYs7zv2QE1LejVxnphyYME/cn0Z9O0uxztpw28nhncRyD5EPMw YL6p078s0zH3RMzpqf6tf/Tzbk1fhu2M1tVDsUJ1FQ3ZNU7XYm8ayN/CBGM7fmOHr4k+sCDcKWDiK yuvHZaN6xhThWecIgpyts8ItC2+Qhr8BU1QHxeKVvY8o+yFEHtquMgk/zRwPnCcND2K6HpV6LMg2h +ZTgzp5A==; Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojUn8-0081ai-Hl; Sat, 15 Oct 2022 00:12:39 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: qcom: SND_SOC_SC7180 optionally depends on SOUNDWIRE Date: Fri, 14 Oct 2022 17:12:28 -0700 Message-Id: <20221015001228.18990-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, kernel test robot , Randy Dunlap , Liam Girdwood , stable@vger.kernel.org, Ajit Pandey , Mark Brown , Srinivas Kandagatla , Banajit Goswami , Takashi Iwai , Cheng-Yi Chiang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" If SOUNDWIRE is enabled, then SND_SOC_SC7180 should depend on SOUNDWIRE to prevent SOUNDWIRE=m and SND_SOC_SC7180=y, which causes build errors: s390-linux-ld: sound/soc/qcom/common.o: in function `qcom_snd_sdw_prepare': common.c:(.text+0x140): undefined reference to `sdw_disable_stream' s390-linux-ld: common.c:(.text+0x14a): undefined reference to `sdw_deprepare_stream' s390-linux-ld: common.c:(.text+0x158): undefined reference to `sdw_prepare_stream' s390-linux-ld: common.c:(.text+0x16a): undefined reference to `sdw_enable_stream' s390-linux-ld: common.c:(.text+0x17c): undefined reference to `sdw_deprepare_stream' s390-linux-ld: sound/soc/qcom/common.o: in function `qcom_snd_sdw_hw_free': common.c:(.text+0x344): undefined reference to `sdw_disable_stream' s390-linux-ld: common.c:(.text+0x34e): undefined reference to `sdw_deprepare_stream' Fixes: 3bd975f3ae0a ("ASoC: qcom: sm8250: move some code to common") Fixes: 9e3ecb5b1681 ("ASoC: qcom: sc7180: Add machine driver for sound card registration") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Srinivas Kandagatla Cc: Banajit Goswami Cc: Mark Brown Cc: Liam Girdwood Cc: Ajit Pandey Cc: Cheng-Yi Chiang Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: stable@vger.kernel.org Cc: alsa-devel@alsa-project.org --- Sorry, I can't tell which Fixes: hash is appropriate here. sound/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -187,6 +187,7 @@ config SND_SOC_SC8280XP config SND_SOC_SC7180 tristate "SoC Machine driver for SC7180 boards" depends on I2C && GPIOLIB + depends on SOUNDWIRE || SOUNDWIRE=n select SND_SOC_QCOM_COMMON select SND_SOC_LPASS_SC7180 select SND_SOC_MAX98357A