From patchwork Thu Sep 29 07:35:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 610629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A0B9C07E9D for ; Thu, 29 Sep 2022 07:38:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 61B6C1651; Thu, 29 Sep 2022 09:37:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 61B6C1651 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1664437089; bh=cSWfaDpMIDvPg8HiF1L9wlcJC6sPaO3t6kwnmzNdKTY=; h=From:To:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FSWttMxVAL5KWGVxMVDhwhSpOdtK46tYkJZqFG+ivQsr72vP1eUshpw3DXxdQ70iM gGLdiDZLh21yPbplqk/ZMExxSrtffZcdYQV9kE3FHo6Um5cdxhxMXKeu364WAr/2j1 rqO+8zUlT3wdcohHsScHFjFGAK9o7wa3IhpjQiyI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D0E66F80539; Thu, 29 Sep 2022 09:36:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3DD87F8053C; Thu, 29 Sep 2022 09:36:03 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5F96FF80519 for ; Thu, 29 Sep 2022 09:35:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5F96FF80519 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xyGju36m"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="01LFyAgk" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BEAA021B9B; Thu, 29 Sep 2022 07:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1664436955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T5gleWSgupy5Q46T3nfKAh1/GVJjYykvomOG7Wkcqgk=; b=xyGju36mURPXvLESF1z/0o0Zh1D5SRyXNfovivVlifmQgduk/HljkiJbBulPLObty89FGa XfotE//FLleBNAkLjMomOCdk+O9fq2mRhYylKPFzx4RFXgFyCOX8kItsrGz70r0FGzoYCM A+wfS9LucIFloz34q52h9QoD85PJihs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1664436955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T5gleWSgupy5Q46T3nfKAh1/GVJjYykvomOG7Wkcqgk=; b=01LFyAgkDs7aEonOjAGbfspsoNvsuIXbaWB1bDEJXppPeVFonnfVZe/AlTYJFJkFfdTqlK j90pKtHj35hi5kDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9665E1348E; Thu, 29 Sep 2022 07:35:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GNDVI9tKNWMFfQAAMHmgww (envelope-from ); Thu, 29 Sep 2022 07:35:55 +0000 From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: [PATCH 7/8] ALSA: hda/via: Add model option to codec driver, too Date: Thu, 29 Sep 2022 09:35:44 +0200 Message-Id: <20220929073545.1085-8-tiwai@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220929073545.1085-1-tiwai@suse.de> References: <20220929073545.1085-1-tiwai@suse.de> MIME-Version: 1.0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The model option of snd-hda-intel or SOF driver is useful for testing / debugging quirks. Since many devices have multiple codecs and the quirk is rather codec-specific, it's often difficult to pass the model to the proper target. This patch adds the equivalent model option to VIA codec driver, so that user can optionally specify the option for the codec instead of snd-hda-intel or SOF drivers. That is, you can pass the boot option like snd_hda_codec_via.model=foobar or snd_hda_codec_via.model=1043:13f7 for applying a quirk no matter whether you use snd-hda-intel or SOF. The model option of snd-hda-intel or SOF is still effective. When the option is given for both, the option for the controller driver wins. Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_via.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c index aea7fae2ca4b..a60900525d8c 100644 --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include #include @@ -45,6 +46,11 @@ #include "hda_jack.h" #include "hda_generic.h" +/* codec-specific model option -- equivalent with snd-hda-intel.model option */ +static char *codec_model; +module_param_named(model, codec_model, charp, 0444); +MODULE_PARM_DESC(model, "Use the given board model."); + /* Pin Widget NID */ #define VT1708_HP_PIN_NID 0x20 #define VT1708_CD_PIN_NID 0x24 @@ -119,6 +125,11 @@ static struct via_spec *via_new_spec(struct hda_codec *codec) codec->power_save_node = 1; spec->gen.power_down_unused = 1; codec->patch_ops = via_patch_ops; + + /* assign optional modelname; freed at snd_hda_codec_dev_release() */ + if (!codec->modelname && codec_model) + codec->modelname = kstrdup(codec_model, GFP_KERNEL); + return spec; }