From patchwork Fri May 20 21:06:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 574955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB28C433F5 for ; Fri, 20 May 2022 21:07:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D4A341711; Fri, 20 May 2022 23:06:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D4A341711 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653080848; bh=yYjAnH1dp0HZCKfEVdlZoxqq4j9Tl0It3Iy0wsyknRw=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=h0zSfpZbmUT+i2gY0FFEmYJF4QB4c1dWZ/eH+gCDqTMjexS/cWQGBMvudfKOgOIVH zA1fn518Fj7exRNZbRXEKr2RXgsli7vV6N3KRy66dVKmngCZUAFhijMGmsUhgNM1/K TsCiEOisWoFmm+/SzILQCSUoYloo2v1edkq2S/OA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6CF1FF80153; Fri, 20 May 2022 23:06:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C5670F8019D; Fri, 20 May 2022 23:06:36 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DB086F800D2 for ; Fri, 20 May 2022 23:06:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DB086F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U8G0xeBJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653080791; x=1684616791; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yYjAnH1dp0HZCKfEVdlZoxqq4j9Tl0It3Iy0wsyknRw=; b=U8G0xeBJbWQj19SdD3alQAckxIDKDxifd7EfCljSqUKVCJBoXa+HxTdc axgKYo2ffREfwcxo4pd0M01kFhA6dqd1A/Y8sZZX0241sFUAoNA5ssQKg VmNVvbDEkmYXY/oDmdcCvQpk5Is28Swpi0eKJWprrQDnomR6v5y+HLx38 Ko4a27+9gORScJSxs3h9YJkYCX2UvUOhMZdvipaXNqolDHNBbnxR35Pwt F/tToEWGUO22h2pl67DSOUeAsUX6YPlzCk+YLs6KEr6fvmQT1lmDgFHwv xsReyBaQGeid3fvpOy5YPaGoqPBP3mBkCAuiWIczReWSE3JS4hRIzvVAk w==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298051280" X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="298051280" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 14:06:25 -0700 X-IronPort-AV: E=Sophos;i="5.91,240,1647327600"; d="scan'208";a="628354397" Received: from achsu-mobl2.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.212.181.190]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 14:06:25 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH] ASoC: soc-pcm: fix BE transition for TRIGGER_START Date: Fri, 20 May 2022 16:06:15 -0500 Message-Id: <20220520210615.607229-1-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: tiwai@suse.de, =?utf-8?q?P=C3=A9ter_Ujfalusi?= , broonie@kernel.org, Bard Liao , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" A obvious editing mistake caught with a cppcheck warning sound/soc/soc-pcm.c:2132:8: style: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = soc_pcm_trigger(be_substream, cmd); ^ sound/soc/soc-pcm.c:2126:9: note: ret is assigned ret = soc_pcm_trigger(be_substream, ^ sound/soc/soc-pcm.c:2129:9: note: ret is assigned ret = soc_pcm_trigger(be_substream, ^ Fixes: 374b50e234a3e ('ASoC: soc-pcm: improve BE transition for TRIGGER_START') Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Péter Ujfalusi --- sound/soc/soc-pcm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 6f43db35a5c84..a827cc3c158ae 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2128,8 +2128,6 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, else ret = soc_pcm_trigger(be_substream, SNDRV_PCM_TRIGGER_START); - - ret = soc_pcm_trigger(be_substream, cmd); if (ret) { be->dpcm[stream].be_start--; goto next;