From patchwork Wed May 18 02:16:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wan Jiabing X-Patchwork-Id: 573894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 433A7C433F5 for ; Wed, 18 May 2022 02:17:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 847BF844; Wed, 18 May 2022 04:16:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 847BF844 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652840261; bh=IcNKg/DBtSueSl1abF4ofbMut+VVYrsrP7xmSMHNuBo=; h=From:To:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=DWHd+RMZqsx5WnGo96uKjh1HxSxyEApNzeelKglKxPW5bku2dpxqqUB0uzDkqRF4x Bm8HkVUOTYVbwDMTk5pYoyhJcS9leOSjy48G7ZW45TbQemUjkrWwKXWv7fqPfqu6RN BOR437VXN7MAgJvvEUGmRwfX4n5OrXrbbM3RN7dk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1F260F80159; Wed, 18 May 2022 04:16:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 882AEF800E1; Wed, 18 May 2022 04:16:49 +0200 (CEST) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:feae::71e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1EAE9F800E1 for ; Wed, 18 May 2022 04:16:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1EAE9F800E1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=vivo0.onmicrosoft.com header.i=@vivo0.onmicrosoft.com header.b="QsqPw9kx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A8ZRn+9aY+Y+cYQvl6t/aj3sU1aAp786zY1xNMsdSZJ+UIoUyfur+IJbdYK0Nuy22wVXgPaVjzYLEjqxnl9U5sR3cQX7/pkL7k6GIqqiq9N4SJMKDxk7WLo2dAVXBiyRFKypy8HifVO6jne7AEJKPfmy8voMVh5c8uU3GTLAp0UfGWBbOtYVtwVgV4yneiEV3ti9m4YuBNcdVkHY3aJrdkhU4MgdcqT1fU25ZHu/TUSgqmkGp26CNKOc7UGdyE6ldJGaSs8NTwDvILnAQIW92HTkQVC5Rd45vT64tbYaiYZ8gLe7HHLRDLA/UAX+sKPSLC7/VIImxI/Qz1r++K5b2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XsE58IKnAb3BKSAYYBFxTVT6EQnXu2MJ2p534pvYh8=; b=M/EfYZLTlJZqW/LA0xHzXlwv7UHxZqBmAy4nPrgzT2fSMep4YLRqv2XGQpmwOxoFoK9HIuBtzStvjtwDAQLq4z3JKN+R0JSfBMhBG6/bUmKzRzEnRcEFt1cYmhPbTmcJ+JrxK9NjDtfVxYTxHRocPlCzOhXpGad6FkmiPwd0jgzuhOpD2AGrLpaoyIiWnJ+roCWDG+mr8V533eF7VJ/6I65OR7sGf7ex/9ZIEOSVGxwGd7d+LcBHdhzV97u40quf3l7yM3CXl00h7ii6jJz/xeGZwYNrIBf2TO6nsK/BunsYwn0haBfsznP66OJLrNWAm/YADWcaL//ptAc1E9v+bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo0.onmicrosoft.com; s=selector2-vivo0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+XsE58IKnAb3BKSAYYBFxTVT6EQnXu2MJ2p534pvYh8=; b=QsqPw9kxn8VMj4a6jOG0qKxSgUX9nn8FrsO4b2c0tBDeOnWli7s9mUFKlqZc8b/MaNc3TpcCOerSLzV5PffGFPFqPolYCflx4lEMPjAdG6dDbzHqbJCgSdas94xmIfDx1SVTlNhVVfiQDNMK+VC8isUPYe+Pxnu2EpF52GeQnfY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) by TYZPR06MB4525.apcprd06.prod.outlook.com (2603:1096:400:88::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Wed, 18 May 2022 02:16:34 +0000 Received: from SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5]) by SG2PR06MB3367.apcprd06.prod.outlook.com ([fe80::ccb7:f612:80b2:64d5%4]) with mapi id 15.20.5250.018; Wed, 18 May 2022 02:16:34 +0000 From: Wan Jiabing To: Jaroslav Kysela , Takashi Iwai , Wan Jiabing , gushengxian , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: usb-audio: Fix wrong kfree issue in snd_usb_endpoint_free_all Date: Wed, 18 May 2022 10:16:16 +0800 Message-Id: <20220518021617.10114-1-wanjiabing@vivo.com> X-Mailer: git-send-email 2.36.1 X-ClientProxiedBy: HK2PR0302CA0018.apcprd03.prod.outlook.com (2603:1096:202::28) To SG2PR06MB3367.apcprd06.prod.outlook.com (2603:1096:4:78::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8912ffea-101a-4e5a-3831-08da38746d8e X-MS-TrafficTypeDiagnostic: TYZPR06MB4525:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S0/aRQSHs/iqgDuvzoYhbZ8188g/uDo+whKNhH2BK2EvDVMmgBJl7mOCiguR7+1ndE8xD7QVtqW0EEAX6MzZ3MahE3elOfJMxdKIG0p+5p/QryG6qLN4SZFsVa04esDpyeQoNC5VdqBP1YVroyre8ZgqH8MNuSZGu1zNJPtPRHeWdHuICrpe/8/d5Nseo6+lTSkk1CHIEo5ImuiamWI6OhPN1QcCyG5TqlNh2bAHMrW0M56TV53u3rZMxB6qOdAvpV2CebJM4C2wo3t6lS1DpMzPJH51rWZh+HjHag2xXYxksTxl701nsK/pEteHLvnTHVehGzGvps6Dj3y9NnG+Fa2d3D5NcShZzH79a9b1mMHOaDKLZDIMYei4nxnUtrMPRw7t/ZIGJWv3JYq6RmlssZilS4M6NrqmR5ta+PI8qNg9J76UGOiJb3uXoAkXeOFUKS0XgXwLwnDbPdVY6nI2ZFfrpUpwG9SQ77tAyFH7Fl9E7k2UNLa89kCe960J3wLra5oTXEju11uTDyAfVJH+4xrGrHVMuO0bLJuhQG/tGKHI8O1yZY0fhS+65k7aQ9ote1G+fg4vKAUKlZD9CBCsWonbRxOpQcOe/j7qV0BuKllbNsiGUcrjfiiuvIgbcEMOyS8d/nywyWPQ9kDGTbpuKTtg48IBSWN7btSATy/0Xe59Gum/Ec5yKAjWHEgFFzxyTK89ltBBHPXyE0n1Vbco0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SG2PR06MB3367.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(26005)(86362001)(186003)(2616005)(38100700002)(1076003)(38350700002)(4744005)(52116002)(6506007)(6512007)(66556008)(36756003)(110136005)(66946007)(316002)(83380400001)(8676002)(5660300002)(6666004)(8936002)(66476007)(508600001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o7yOdzth9hkr21/jTxAE1E9iYbiN4rphs1rPH4SBa1P8l96vLVxBemD1E8p6x2eWO03EBJHSncGNZm6psQMroUgwAvp9EyiLWns6fXTWCutR0SnZMLIwBxhu6kg5dCxRXIDRTjXmPCrJG0jTlF1+O75IL/NnVnzDm1t5ywt126oeTVBu/LYvCE8pbrYuB1QfDulvEc+9xrjXP9nm+3gnu1rciliTpo8MQqI4wLg3QcEI9hLruKxyJKmFiKrmnRHa3a6pPulIRA3RBQDJf7SqFlt6AZqIpyR7AOumUrT5zJUd+AHI8CKO0H1jTGZx8iVQtCEjYuNkIgqKw7POxtbt1DAbGgllsRXU68U/y0sUnObAiQilWRpRbS9xg6Cenm/FddGnx8SenZ2bTuQ8bJZRqafvruX3yh+O/7XQgb6LtPQHC+JWdQi66SAyrRVGdmwriN9/k34nZpsh35NmhjObzvrt8LC/rWyFM8Fo/qEJzxf81RIOz4O/SRu+lEb4Rz6upu+GwoNYyNpGr19J0Schqvujl1hk6DOwRZlvs9nYilTBK+71zaW7NMi1WiXz4yiSnDHBSWyd/C6zbaLBoJfWsTk0k+H15Wom0ao0OOleVXd2n9sAiUH8T9IAkTqWNEsYraeAOy4eYzgRee9CmW1tBNic3SISqlzUSg28/BX87kJTHpNB4TteiNRJIfIF40TS43WXcpvRZfnpUVYpV9U6Xp5bGPt/rSILosWNIN4StGjcLwFX1VRQeVZlEzhOhY3jQpB9HTzXUGCVslcqKcyN9eoB5lYWk4gNdzmtFu/DE4zcH+y8Q3t2uqlQXfYHIewsz3/XeoZaLKK62MOdKxgUt3cHpWjnfT6Y3I8mQ98KJV+CdsBEor1bow/gFSkMwENoyBrwvcKylgmWsf94U/5w+yFioHM7ykyKkR/pggQyNc0ibF22BJq3qWo/33+0pPvqa4kzGUgLEXnYj8dK5Gr6ocqupobQIF2HqpuPGS3on18wlsaJwWPW3EjYb676YkoLV+16+dTWv4yFgheOG89D8uBcyqbZUgLnaH2H6kb+6qfDCTtRe/vsY8hxDLYKN05mSuGpoxJUKIQBkWKqqQu75go9JHGRiyptmMulqxuwce8CJJ92bEC6+zqyVvaz3RsnR2Tchm+oejOnQtDA6cF7mI3yjHDIfKzDwSvYQZjFuZA2UFeRvobfut+eVkt767CI1PaNCdY2TL+cYCh62qZbIe5Xhw7jWvFurNV86F/rYULOn2QlwjEUy9dLVo8zOMkw43R07+qMMZvnaZ8t2vOcL5vyNeDKnM1c2aW/bElkqywnGDzeM4qG3zyYNaSm2U08XqyqNKy0kNosBhtewQHvhmiJTJDv1upgtsrqN9i+YozcskpbfEhdmIF7fSDon/s9cETNT11XOmDxBV5eY+qu4e44euUZkC91uhDSUHUkzdK8s2hEMhzJN6xJ6gtq8cwOQKDqfI7ql3Y7/R9KKvtnFqHsDwgoKe3ed5FuReZehRPtSnSn9jKNeBXK/1R/D2p0Kd/3XdeLrR5SQRRaMetn0QPkxXis2VE87vWSBBNLfb0XzeWsrg/U1B2mrfPX+vEdFzJN0CG901bE8+O2X8Q7ZeG6TdiVEgr6B3WxohYHyRLRF0eRTJZjriELC/oeni13HBZ81vNrcn8f7yHTCsfihxTUOHMQBl6mcii5HBVlKmCklZbaYFnZ/K7+Gm6NbROkfiqE4lFsp+u2KCkQJjYoOQ== X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8912ffea-101a-4e5a-3831-08da38746d8e X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 02:16:33.4401 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w12OCxASwuUC8mbFGxP3vLzTUYrbI/8Za9ULUnhokb+fhP95amCa8NS/7yzRr1+F7oMIouM9K2zICD50O1YoOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4525 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fix following coccicheck error: ./sound/usb/endpoint.c:1671:8-10: ERROR: reference preceded by free on line 1671. Here should be 'cp' rather than 'ip'. Fixes: c11117b634f4 ("ALSA: usb-audio: Refcount multiple accesses on the single clock") Signed-off-by: Wan Jiabing --- sound/usb/endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c index df5a70013a85..f9c921683948 100644 --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c @@ -1668,7 +1668,7 @@ void snd_usb_endpoint_free_all(struct snd_usb_audio *chip) kfree(ip); list_for_each_entry_safe(cp, cn, &chip->clock_ref_list, list) - kfree(ip); + kfree(cp); } /*