From patchwork Tue Apr 5 17:27:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ranjani Sridharan X-Patchwork-Id: 556191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4A22C433EF for ; Tue, 5 Apr 2022 17:31:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B412187B; Tue, 5 Apr 2022 19:30:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B412187B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1649179898; bh=aHeEdozjzhN10+ojMXxyVSzysrqi+K0GCs4Upy/EeYc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qNQJbtEEAyKEnukxqq8wl/0XQX3aQlWjMM50Fz+/Tmjj2X8EfITUvlCGBLdVjuKnr Y0MmoJ8iE/atgp80BA+zYMyV/Adtp8hsMyMKw/yGq7WZITf9tMz7nLdLBYblkCmF/c Yr1v5cAKY9QCJHH4YgwFxJS7kdjbTejx/RZpH6Gc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E6604F8055C; Tue, 5 Apr 2022 19:27:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DEDA0F80536; Tue, 5 Apr 2022 19:27:49 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1B228F800D2 for ; Tue, 5 Apr 2022 19:27:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1B228F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cNqO3J9p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649179660; x=1680715660; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aHeEdozjzhN10+ojMXxyVSzysrqi+K0GCs4Upy/EeYc=; b=cNqO3J9prlK2VpCBI6mlQe1Vvjtxuq4mXoc6dgA86iNN6vmNtPxwZACE hPK7jn+v52DW1zovlkHR0+lINpOMxe4XcgxXAQArF1kH3GMvrINFaiA1X aRhwzbcdatAX14KY/hPhSi5Z0YbmTIwNLIPK0V1FO5VoWJtu8r+Y0XYyo 5U58CI3GEDGzEZVX52jyAi9J4AU3UfSB7qqiHOFcmN/22olxVQBhjCtBT JiPjuKdt+rdyF4IqzpEaz1ZH2CwYhBDvOJLARuF6D2Syd+nyZBZ1tsLRp w26FaBnQZuHFeAZg2RjoQgystXUkP7DOHzdNdgWizrdQUfCx/UDxpLwMR A==; X-IronPort-AV: E=McAfee;i="6200,9189,10308"; a="323986755" X-IronPort-AV: E=Sophos;i="5.90,236,1643702400"; d="scan'208";a="323986755" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 10:27:25 -0700 X-IronPort-AV: E=Sophos;i="5.90,236,1643702400"; d="scan'208";a="722140986" Received: from reginari-mobl7.amr.corp.intel.com (HELO rsridh2-mobl1.localdomain) ([10.254.28.131]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 10:27:24 -0700 From: Ranjani Sridharan To: alsa-devel@alsa-project.org Subject: [PATCH 09/15] ASoC: SOF: ipc: Add check for mandatory IPC message handling ops Date: Tue, 5 Apr 2022 10:27:02 -0700 Message-Id: <20220405172708.122168-10-ranjani.sridharan@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220405172708.122168-1-ranjani.sridharan@linux.intel.com> References: <20220405172708.122168-1-ranjani.sridharan@linux.intel.com> MIME-Version: 1.0 Cc: tiwai@suse.de, Peter Ujfalusi , Pierre-Louis Bossart , Ranjani Sridharan , broonie@kernel.org, Daniel Baluta X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Peter Ujfalusi Make sure that the mandatory IPC message handling ops are provided by the IPC implementation. Signed-off-by: Peter Ujfalusi Reviewed-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Signed-off-by: Ranjani Sridharan --- sound/soc/sof/ipc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c index 4966a2a41704..d11c5e6e57fb 100644 --- a/sound/soc/sof/ipc.c +++ b/sound/soc/sof/ipc.c @@ -1066,6 +1066,11 @@ struct snd_sof_ipc *snd_sof_ipc_init(struct snd_sof_dev *sdev) ops = ipc->ops; /* check for mandatory ops */ + if (!ops->tx_msg || !ops->rx_msg || !ops->set_get_data || !ops->get_reply) { + dev_err(sdev->dev, "Missing IPC message handling ops\n"); + return NULL; + } + if (!ops->pcm) { dev_err(sdev->dev, "Missing IPC PCM ops\n"); return NULL;