From patchwork Wed Dec 29 02:18:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: GitHub pull_request - opened X-Patchwork-Id: 528816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEB04C433EF for ; Wed, 29 Dec 2021 02:19:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0CBC2174C; Wed, 29 Dec 2021 03:18:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0CBC2174C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1640744343; bh=YTbGbEi3RbDccc3eLxiMQGzlecNwCTyLvPFqV2rCxEA=; h=From:To:In-Reply-To:References:Subject:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oHF7TuZBUrRs0QhrnOQUG3xLmigovfE8EFqryVxGXGGPMbRnl6Z8fikBRDnNzYi8k IyZo6cx1FpTVRAve13/KnjOlz7unFYP79Kly8KmdAyIAMP/ujS7XRDPYOBL0slUkYa jHOyrSL4+rsIosw8sEZGOA64klvvrdxBkHkDhimw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 96A6CF800D3; Wed, 29 Dec 2021 03:18:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76F3BF801EC; Wed, 29 Dec 2021 03:18:11 +0100 (CET) Received: from webhooks-bot.alsa-project.org (gate.perex.cz [77.48.224.242]) by alsa1.perex.cz (Postfix) with ESMTP id 07B06F800CE for ; Wed, 29 Dec 2021 03:18:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07B06F800CE MIME-Version: 1.0 From: GitHub issues - edited To: alsa-devel@alsa-project.org In-Reply-To: <1640744284689656973-webhooks-bot@alsa-project.org> References: <1640744284689656973-webhooks-bot@alsa-project.org> Subject: [patch] speaker-test/samples/sample_map.csv is not accurate, which does not affect operation of speaker-test Message-Id: <20211229021811.76F3BF801EC@alsa1.perex.cz> Date: Wed, 29 Dec 2021 03:18:11 +0100 (CET) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" alsa-project/alsa-utils issue #133 was edited from ZjYwMj: With alsa-utils 1.2.6: The [commit](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1ca263be84d919aa808601c3#diff-b674355c9f894a18fea52161d54cb3e6590b4db71984be913086abb9486067a6) in question. ``` ``` The directory ``/usr/share/alsa/samples/`` does not exist. It sounds as if ``speaker-test -t wav`` plays the files mentioned in the diff. This inaccuracy does not affect the operation of ``speaker-test``. Do the paths to the wav files hard coded within ``speaker-test``? Does only their ``basename`` counts? Still, I find it a minor bug. Why is ``/usr/share/alsa/speaker-test/sample_map.csv`` distributed anyway? Am I misunderstanding [Install sound samples to correct places](https://github.com/alsa-project/alsa-utils/commit/fb2f99f1f99c430d1ca263be84d919aa808601c3)? Is it for informational purposes? Was it used in the past, and no longer serves its purpose? Is it planed to be used in the future? Is it something else? [speaker-test.c:745](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de62202d2a4974638127f/speaker-test/speaker-test.c#L745) and [746](https://github.com/alsa-project/alsa-utils/blob/00be486131129a6d209de62202d2a4974638127f/speaker-test/speaker-test.c#L746) has the ``basename``s hardcoded. And there is also the default value for ``speaker-test --wavdir`` of ``/usr/share/sounds/alsa``. Issue URL : https://github.com/alsa-project/alsa-utils/issues/133 Repository URL: https://github.com/alsa-project/alsa-utils --- a/usr/share/alsa/speaker-test/sample_map.csv 2021-12-06 18:44:25.000000000 +0000 +++ b/usr/share/alsa/speaker-test/sample_map.csv 2021-12-28 19:48:02.390305957 +0000 @@ -1,2 +1,2 @@ -0, "Front Left", "/usr/share/alsa/samples/Front_Left.wav" -1, "Front Right", "/usr/share/alsa/samples/Front_Right.wav" +0, "Front Left", "/usr/share/sounds/alsa/Front_Left.wav" +1, "Front Right", "/usr/share/sounds/alsa/Front_Right.wav"