From patchwork Wed Jun 23 10:05:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 465914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C38C4743C for ; Wed, 23 Jun 2021 10:06:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A68B611C1 for ; Wed, 23 Jun 2021 10:06:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A68B611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5BBCE1662; Wed, 23 Jun 2021 12:05:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5BBCE1662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624442806; bh=kabrVEEGJjYBrBwnvILlfntoSEJwnZfugr2rpyGl6Ew=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=SnSvIiTQ4xYn3qwElorSENVeIyVN6k/vjZWv7q386qztyq92NQnfydc5RU/GDr+iK 7+uI5++otWFONcFlcRH2xtL1Q0Y09zoi1MUy3rnX8iXx9vYQRVOogczue6C1huikxK 4xQkkEPmAG1WMESxJpto+RGxvzm8ndPptH2oOSoA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E8379F8016B; Wed, 23 Jun 2021 12:05:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 06CD8F8016D; Wed, 23 Jun 2021 12:05:55 +0200 (CEST) Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C92E0F80137 for ; Wed, 23 Jun 2021 12:05:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C92E0F80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="KPfcIVCU" DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=kabrVEEGJjYBrBwnvILlfntoSEJ wnZfugr2rpyGl6Ew=; b=KPfcIVCU03B9ALfeG+OtNa+BGxTrwf667War+Mh1e6V EG46BpFXhjCrXfSXZfRn/3WIpT3w+Bu1vsRXuMq4ut2WpsXF91NYyAoR5xHZWO9D wYQqNyVW6x5jkg1gn1KS+LGZNxj5BJnW4w4Am07ds+C0gps+WTSG2glU4W92KPuU = Received: (qmail 2554623 invoked from network); 23 Jun 2021 12:05:46 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Jun 2021 12:05:46 +0200 X-UD-Smtp-Session: l3s3148p1@rRDRDGzFJKogARa4RfhaAavnjlTTqzSz From: Wolfram Sang To: alsa-devel@alsa-project.org Subject: [PATCH RFC] ASoC: sh: rcar: dma: : use proper DMAENGINE API for termination Date: Wed, 23 Jun 2021 12:05:45 +0200 Message-Id: <20210623100545.3926-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: Kuninori Morimoto , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , linux-renesas-soc@vger.kernel.org, Wolfram Sang , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" dmaengine_terminate_all() is deprecated in favor of explicitly saying if it should be sync or async. Here, we want dmaengine_terminate_sync() because there is no other synchronization code in the driver to handle an async case. Signed-off-by: Wolfram Sang --- Morimoto-san, can you please double check if this works. I don't know this driver very well. Thank you! sound/soc/sh/rcar/dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c index 95aa26d62e4f..d1b46057df9e 100644 --- a/sound/soc/sh/rcar/dma.c +++ b/sound/soc/sh/rcar/dma.c @@ -101,7 +101,7 @@ static int rsnd_dmaen_stop(struct rsnd_mod *mod, struct rsnd_dmaen *dmaen = rsnd_dma_to_dmaen(dma); if (dmaen->chan) - dmaengine_terminate_all(dmaen->chan); + dmaengine_terminate_sync(dmaen->chan); return 0; }