From patchwork Thu Apr 26 12:44:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 134516 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp2264443lji; Thu, 26 Apr 2018 05:45:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx49w6ivWiw7kptfclkLwB/6ybapCAzQa1Kz/xSBsFsq4JOH+1Lt5IpRnO7A3/phjDgqOMSRz X-Received: by 2002:adf:b004:: with SMTP id f4-v6mr28295245wra.75.1524746730906; Thu, 26 Apr 2018 05:45:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524746730; cv=none; d=google.com; s=arc-20160816; b=LdUIgh/4IY8z4h2YPfjmr+cfpWxuWxPnZ036DhxSnDg74A8o/T9zTNMizUkVNKzk19 1ZWxUYVSn80OdVRglHr/GFEV9pNKy4ecnwcA1wkHGeGz6LWa+ZwKdG3cLL9gq0EDe3Z3 Z5sSfgT58K90nH27mXDziotqWG/GSBPMyLk5302F1jerZDt71daS1WAvpgeD3eiYwyf8 CeDQl3k32MJ0sTMOjN6mGVb3FJwG8zUehIGqggHufs6r/v+pj+iV7TOL/xIpLBVP/rHa D2gQLejo9gbf3d9BuQLak4LBL8XNVSQOAyRYc1VSi6JSZ+FL1UW00H91VjkvMBWEnyFI 6M6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:delivered-to:arc-authentication-results; bh=7Erf8dQMgLQKJ6n1wvSR4yz8Vu78nX90N0f0WHDgpts=; b=H89ja9KTLCOYLcr2KTAXUgc+gemb0WLPz+NXPKYSBC5W2K/UHjJ9sfe5jj7JX2Wm3P kNwznEzZN5G4gcoMI0b6n2lTrHFYo2Z3X5p9pNuCggQGo8o+Tah8sbHBZv7PAFJGY4YC 066pV5mHtlNS+y57tUJ2/1Tb9bJa8gyRsdhpXx1RqXmkd9GtIgGWb5AdIQcK0V/jVPeV 6gmY4ux8XqVFXv6lkO8POZk69MoLPVg6aCEGOe5m1OPN4yAJncow4nyjbSYWVG+w+/nT 8jSJbn0Ve4zeae7tzHdso2Ngf6AyuPwimVh9XF7+EgV/wjpcg1Qt7yqEYHc96pdaE9OD kanw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id 200si9374423wmb.15.2018.04.26.05.45.30; Thu, 26 Apr 2018 05:45:30 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 0B96B26782F; Thu, 26 Apr 2018 14:45:25 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 311D4267812; Thu, 26 Apr 2018 14:45:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by alsa0.perex.cz (Postfix) with ESMTP id 2CFEE2677F6 for ; Thu, 26 Apr 2018 14:45:19 +0200 (CEST) Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0Le9A8-1ebIAK1pKW-00psI3; Thu, 26 Apr 2018 14:44:44 +0200 From: Arnd Bergmann To: y2038@lists.linaro.org, linux-kernel@vger.kernel.org Date: Thu, 26 Apr 2018 14:44:20 +0200 Message-Id: <20180426124422.2921744-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180426124422.2921744-1-arnd@arndb.de> References: <20180426124422.2921744-1-arnd@arndb.de> X-Provags-ID: V03:K1:TDTPdewdp6MHvn7a74pHVhc+qASKxsLqxuFEZBUL+xm39HbziuE PcSLB5uC5i74pR2w0j5l1HR4hWRXxlcPn/3xevUlzR1zGfg8+2z83YNlSk2XVYd7gqXoIhx j61Oiwi8hiQIqeFe7nzwzeO9YAytxuwKohZ/SxLqQA9REwGxPKvzqjpWYPhop89L0Xo1S9Y XdQvcgjAuKpXphn+U6dhA== X-UI-Out-Filterresults: notjunk:1; V01:K0:LLyQxPRrTgI=:o+mVQxtCkX+amY035mknlC JBBoPo0GplMRWK+buOr1uydoctmzJbapsuGCdG1LV4f0zabdg+4lto6gw1UOomv17utPSVWUx rd215x3kRdPARCQ7rWQmT+XVkKr08pSucdGFG7abW+LZDS6RBLFTHgzsMydirgMrvzs1Gpe3C pY5BowdO/h89yJ02tnpYlkTewmw62M0ZkX8JMoLnpMJt7U4sWy8HX1OImxywxs4d+0e/G4rWW 6QJBayPzpjlu0Jyk8ceLgSKtYh0zAWDg7X3aztM1ArqWo2TGZFjmM0SgFiw5P7C+PvbzMI5mh yw8VpCDrQzIe5nO6XH6jP+OiHe363+xGKU4XyudH6fknT/fAPQoTXlAFErulAKC6okfoa5e7s prVnSqh/qteu2NvqJpHH88e/hrQqKiXZUMc+B3G1HN85WShO+rTl7qb7NZzs4DpTXA3OWwe26 RGdW/wVd7BbiVfG7Ikm4sEnC38MM6Veyxze7+z+qoFL7APka0rxErqJATg9YfpMIcGQmqAfmi 7hBIOD2zmvD5DaW+YtGLrKBPSv5QGe6HPbaqdoRVd/49g4N8A2FaZ29yImlpUxRMmiwMJBmS4 OWuH+5t8blY8v84MtfaGkKZQyh0EQf5QbV4Vk8XgfImZ453+Y9VzvlRzvRwI8ktQzCQlKeQhg iG1xF1fY5zI7FHUuj3DhJuLOieqJdLPQhfL+P9jYGWKvQS5rVeRjwhDEaYcMRi4sOOig= Cc: alsa-devel@alsa-project.org, Arnd Bergmann , Baolin Wang , tiwai@suse.com, lgirdwood@gmail.com, o-takashi@sakamocchi.jp, broonie@kernel.org Subject: [alsa-devel] [PATCH 2/4] ALSA: Avoid using timespec for struct snd_ctl_elem_value X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org From: Baolin Wang The struct snd_ctl_elem_value will use 'timespec' type variables to record timestamp, which is not year 2038 safe on 32bits system. Since there are no drivers will implemented the tstamp member of the struct snd_ctl_elem_value, and also the stucture size will not be changed if we change timespec to s64 for tstamp member of struct snd_ctl_elem_value. >From Takashi's comments, "In the library, applications are not expected to access to this structure directly. The applications get opaque pointer to the structure and must use any control APIs to operate it. Actually the library produce no API to handle 'struct snd_ctl_elem_value.tstamp'. This means that we can drop this member from alsa-lib without decline of functionality." Thus we can simply remove the tstamp member to avoid using the type which is not year 2038 safe on 32bits system. Signed-off-by: Baolin Wang Signed-off-by: Arnd Bergmann --- include/uapi/sound/asound.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.9.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h index ed0a120d4f08..1231f0a943f1 100644 --- a/include/uapi/sound/asound.h +++ b/include/uapi/sound/asound.h @@ -954,8 +954,7 @@ struct snd_ctl_elem_value { } bytes; struct snd_aes_iec958 iec958; } value; /* RO */ - struct timespec tstamp; - unsigned char reserved[128-sizeof(struct timespec)]; + unsigned char reserved[128]; }; struct snd_ctl_tlv {