From patchwork Sun Oct 8 06:38:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: brett@worth.au X-Patchwork-Id: 732574 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 233E7E95A91 for ; Mon, 9 Oct 2023 15:59:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 301A5EA6; Mon, 9 Oct 2023 17:59:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 301A5EA6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696867196; bh=ubNRAlRfoQPYsP0oYqhCk61aypjE1o7uIwUcDSiaXng=; h=Subject:From:To:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=G2zZXcu9oCSXR2MdG8cEVe8WRgZruXwC+O8pnK5O5UgAtVgMQtDp56fDrGW/ynKGQ +ze8aX0amDUMhSvOfirfumaXh2CqdAgVVh5hU1Q0EMelkabaGVmtvmeeoe0d9HYPDs S+OloruJJWi3nsfZnr2K8ZI6sgYgEprpL3RFANRk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1B11AF805AB; Mon, 9 Oct 2023 17:57:33 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2A651F805AB; Mon, 9 Oct 2023 17:57:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C6FFEF802BE; Sun, 8 Oct 2023 08:38:31 +0200 (CEST) Received: from mailman-web.alsa-project.org (mailman-web.alsa-project.org [10.254.200.11]) by alsa1.perex.cz (Postfix) with ESMTP id 080BCF8019B for ; Sun, 8 Oct 2023 08:38:23 +0200 (CEST) MIME-Version: 1.0 Subject: [PATCH] hda/realtek: Add SND_PCI_QUIRK entry for the Dell XPS 9530 laptop for dual speakers From: brett@worth.au To: alsa-devel@alsa-project.org Date: Sun, 08 Oct 2023 06:38:23 -0000 Message-ID: <169674710330.21.11445585266903972887@mailman-web.alsa-project.org> User-Agent: HyperKitty on https://mailman.alsa-project.org/ X-MailFrom: brett@worth.au X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: I24RO4HYAYRDVRHM7S2SZK4KYLTDPSY2 X-Message-ID-Hash: I24RO4HYAYRDVRHM7S2SZK4KYLTDPSY2 X-Mailman-Approved-At: Mon, 09 Oct 2023 15:57:19 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The Dell XPS 9530, like previous XPS laptops like the 9520 and 9510 have dual speakers in each channel. If the ALC289_FIXUP_DUAL_SPK flag is not set in sound/pci/hda/patch_realtek.c only the tweeter will work and therefore make the sound quality terrible. This patch has not been tested but is derived from a previous patch attempt from a different user called Pentracillin which was rejected. $ diff -r -up a b Brett Worth diff -r -up a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c --- a/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:36.129618972 +1100 +++ b/sound/pci/hda/patch_realtek.c 2023-10-07 22:16:52.645258218 +1100 @@ -9412,6 +9412,7 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0b1a, "Dell Precision 5570", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x0b37, "Dell Inspiron 16 Plus 7620 2-in-1", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), SND_PCI_QUIRK(0x1028, 0x0b71, "Dell Inspiron 16 Plus 7620", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS), + SND_PCI_QUIRK(0x1028, 0x0beb, "Dell XPS 15 9530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x0c03, "Dell Precision 5340", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0c19, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS), SND_PCI_QUIRK(0x1028, 0x0c1a, "Dell Precision 3340", ALC236_FIXUP_DELL_DUAL_CODECS),