From patchwork Mon Jun 2 15:11:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 31290 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f70.google.com (mail-qa0-f70.google.com [209.85.216.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4BAC420AE6 for ; Mon, 2 Jun 2014 16:19:00 +0000 (UTC) Received: by mail-qa0-f70.google.com with SMTP id cm18sf8926507qab.5 for ; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=3fmSAvzIK0fqdLAZ/zu7OcSJcjOTMkwko9d9x+5w68E=; b=i3BziSMfJCgoQvl/Lwr/epiNA51zkkuTS/ulWnRGSRJ8tEg3k8pTodlMR6g7OcvbsZ G2mvtSpMrIBv8H8sYuLuXQGuuHLc9nngz37IZCjfoOL9/u/Wosy5GhBsck3C/O91pDfN LMq8kNZrq/81bisuRiI4ESHZk8cPUweSXMNmhjZykGDJOLov7707pODHa/Jz2YDEq3VQ 52wP6LASRdOvz+Y0xgdLMj56R1QheoB2gHYSjfm+jkO0kDpEzS3fv3ScljhXe8O0c06+ ADLsDEQni0YmbUZAxzJICwGTq1xIkrKCMLm20ziYSeNlVffGJgB91dEQORNksIBw1YUa zOTw== X-Gm-Message-State: ALoCoQkrNUtcOnX5Sw6fuTlbwqqwHx1Xj0Sf/QBb5Un1dKsIxGodSvHP98H6JoebEJr7MxpzDUyg X-Received: by 10.58.29.14 with SMTP id f14mr14252342veh.32.1401725939867; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.145 with SMTP id f17ls2024510qgd.95.gmail; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) X-Received: by 10.52.103.74 with SMTP id fu10mr26457734vdb.7.1401725939746; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id ce2si8148706vdc.67.2014.06.02.09.18.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 09:18:59 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id ij19so895500vcb.38 for ; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) X-Received: by 10.58.186.207 with SMTP id fm15mr31551793vec.4.1401725939659; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp109700vcb; Mon, 2 Jun 2014 09:18:59 -0700 (PDT) X-Received: by 10.220.249.6 with SMTP id mi6mr4150413vcb.33.1401725939285; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id fl16si8167592vec.81.2014.06.02.09.18.58 for ; Mon, 02 Jun 2014 09:18:59 -0700 (PDT) Received-SPF: none (google.com: alsa-devel-bounces@alsa-project.org does not designate permitted sender hosts) client-ip=77.48.224.243; Received: by alsa0.perex.cz (Postfix, from userid 1000) id D6B57265586; Mon, 2 Jun 2014 18:18:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled version=3.2.4 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 0EDCC265568; Mon, 2 Jun 2014 18:18:21 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id F2516265091; Mon, 2 Jun 2014 18:18:18 +0200 (CEST) Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 1560B265091 for ; Mon, 2 Jun 2014 18:18:12 +0200 (CEST) Received: from host109-151-120-177.range109-151.btcentralplus.com ([109.151.120.177] helo=finisterre) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WrUvx-0006yd-7i; Mon, 02 Jun 2014 16:18:05 +0000 Received: from broonie by finisterre with local (Exim 4.82) (envelope-from ) id 1WrTtU-0000ss-0w; Mon, 02 Jun 2014 16:11:24 +0100 From: Mark Brown To: Fabio Estevam , Jarkko Nikula , Xiubo Li , Liam Girdwood Date: Mon, 2 Jun 2014 16:11:03 +0100 Message-Id: <1401721863-3364-1-git-send-email-broonie@kernel.org> X-Mailer: git-send-email 2.0.0.rc2 X-SA-Exim-Connect-IP: 109.151.120.177 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org, Mark Brown Subject: [alsa-devel] [PATCH] ASoC: cache: Fix error code when not using ASoC level cache X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: broonie@kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Mark Brown It is not an error to have no cache so we shouldn't return an error code and cause our callers to fail, just silently do nothing instead. Thanks to Jarkko for identify the problematic commit. Reported-by: Jarkko Nikula Reported-by: Fabio Estevam Signed-off-by: Mark Brown --- sound/soc/soc-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c index 8fff5b6..00e70b6 100644 --- a/sound/soc/soc-cache.c +++ b/sound/soc/soc-cache.c @@ -73,7 +73,7 @@ int snd_soc_cache_init(struct snd_soc_codec *codec) reg_size = codec_drv->reg_cache_size * codec_drv->reg_word_size; if (!reg_size) - return -EINVAL; + return 0; mutex_init(&codec->cache_rw_mutex);