mbox series

[0/3] ALSA: hda/tas2781: fixes for 6.9-rc1

Message ID cover.1711401621.git.soyer@irl.hu
Headers show
Series ALSA: hda/tas2781: fixes for 6.9-rc1 | expand

Message

Gergo Koteles March 25, 2024, 9:25 p.m. UTC 
Hi,

This series removes the no longer needed digital gain kcontrol, which 
caused problems in tas2563, because the register does not exists there.

This series also adds locking and debug statements to the other 
kcontrols. They sometimes ran in parallel with tasdev_fw_ready, and 
caused weird sound problems.
https://github.com/tomsom/yoga-linux/issues/58

Regards,
Gergo

Gergo Koteles (3):
  ALSA: hda/tas2781: remove digital gain kcontrol
  ALSA: hda/tas2781: add locks to kcontrols
  ALSA: hda/tas2781: add debug statements to kcontrols

 include/sound/tas2781-tlv.h     |   1 -
 sound/pci/hda/tas2781_hda_i2c.c | 103 +++++++++++++++++++++-----------
 2 files changed, 68 insertions(+), 36 deletions(-)


base-commit: 4cece764965020c22cff7665b18a012006359095

Comments

Andy Shevchenko March 25, 2024, 10:07 p.m. UTC | #1 
Mon, Mar 25, 2024 at 05:01:18PM -0500, Pierre-Louis Bossart kirjoitti:

...

> > +	dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
> 
> Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
> add the information with the dyndbg parameter, e.g.
> 
> options snd_intel_dspcfg dyndbg=+pmf
> 
> dev_err/warn don't have this functionality though so in those cases
> there's no replacement for __func__

You beat me up to it, I just downloaded the email thread to say the same.

Since I'm here, I think __func__ in dev_err()/dev_warn() usually says about
poorly written message itself (that it's not unique enough to distinguish
taking into account that this has device instance name as well). While pr_*()
ones indeed may benefit from having it.