mbox series

[0/8] ASoC: amd: acp: refactor acp version differentiation logic

Message ID 20240918061540.685579-1-Vijendar.Mukunda@amd.com
Headers show
Series ASoC: amd: acp: refactor acp version differentiation logic | expand

Message

Vijendar Mukunda Sept. 18, 2024, 6:15 a.m. UTC
Currently different logics being used in the code for acp version
differentiation. This patch series refactors the code to use acp pci
revision id for handling acp version specific code.

Vijendar Mukunda (8):
  ASoC: amd: acp: simplify platform conditional checks code
  ASoC: amd: acp: use acp_rev for platform specific conditional checks
  ASoC: amd: acp: use acp pci revision id for platform differntiation
  ASoC: amd: acp: store acp pci rev id in platform driver private
    structure
  ASoC: amd: acp: pass acp pci revision id as platform data
  ASoC: amd: acp: remove unused variable from acp_card_drvdata structure
  ASoC: amd: acp: replace adata->platform conditional check
  ASoC: amd: acp: remove unused variable from acp platform driver

 sound/soc/amd/acp/acp-i2s.c           | 38 +++++++++++++--------------
 sound/soc/amd/acp/acp-legacy-common.c | 24 ++++++++---------
 sound/soc/amd/acp/acp-legacy-mach.c   |  8 +++---
 sound/soc/amd/acp/acp-mach-common.c   | 38 +++++++++++++++++++--------
 sound/soc/amd/acp/acp-mach.h          | 12 +++------
 sound/soc/amd/acp/acp-pci.c           |  7 +----
 sound/soc/amd/acp/acp-pdm.c           |  2 +-
 sound/soc/amd/acp/acp-platform.c      | 14 +++++-----
 sound/soc/amd/acp/acp-rembrandt.c     |  4 +--
 sound/soc/amd/acp/acp-renoir.c        |  4 +--
 sound/soc/amd/acp/acp-sof-mach.c      |  6 ++---
 sound/soc/amd/acp/acp63.c             |  4 +--
 sound/soc/amd/acp/acp70.c             | 14 ++++------
 sound/soc/amd/acp/acp_common.h        | 19 ++++++++++++++
 sound/soc/amd/acp/amd.h               |  9 ++-----
 15 files changed, 108 insertions(+), 95 deletions(-)
 create mode 100644 sound/soc/amd/acp/acp_common.h

Comments

Vijendar Mukunda Sept. 20, 2024, 8:42 a.m. UTC | #1
On 18/09/24 11:45, Vijendar Mukunda wrote:
> Currently different logics being used in the code for acp version
> differentiation. This patch series refactors the code to use acp pci
> revision id for handling acp version specific code.
One more patch is missing in the series.
Will add it and re spin the patch series.
>
> Vijendar Mukunda (8):
>   ASoC: amd: acp: simplify platform conditional checks code
>   ASoC: amd: acp: use acp_rev for platform specific conditional checks
>   ASoC: amd: acp: use acp pci revision id for platform differntiation
>   ASoC: amd: acp: store acp pci rev id in platform driver private
>     structure
>   ASoC: amd: acp: pass acp pci revision id as platform data
>   ASoC: amd: acp: remove unused variable from acp_card_drvdata structure
>   ASoC: amd: acp: replace adata->platform conditional check
>   ASoC: amd: acp: remove unused variable from acp platform driver
>
>  sound/soc/amd/acp/acp-i2s.c           | 38 +++++++++++++--------------
>  sound/soc/amd/acp/acp-legacy-common.c | 24 ++++++++---------
>  sound/soc/amd/acp/acp-legacy-mach.c   |  8 +++---
>  sound/soc/amd/acp/acp-mach-common.c   | 38 +++++++++++++++++++--------
>  sound/soc/amd/acp/acp-mach.h          | 12 +++------
>  sound/soc/amd/acp/acp-pci.c           |  7 +----
>  sound/soc/amd/acp/acp-pdm.c           |  2 +-
>  sound/soc/amd/acp/acp-platform.c      | 14 +++++-----
>  sound/soc/amd/acp/acp-rembrandt.c     |  4 +--
>  sound/soc/amd/acp/acp-renoir.c        |  4 +--
>  sound/soc/amd/acp/acp-sof-mach.c      |  6 ++---
>  sound/soc/amd/acp/acp63.c             |  4 +--
>  sound/soc/amd/acp/acp70.c             | 14 ++++------
>  sound/soc/amd/acp/acp_common.h        | 19 ++++++++++++++
>  sound/soc/amd/acp/amd.h               |  9 ++-----
>  15 files changed, 108 insertions(+), 95 deletions(-)
>  create mode 100644 sound/soc/amd/acp/acp_common.h
>
Mark Brown Oct. 1, 2024, 5:53 p.m. UTC | #2
On Wed, 18 Sep 2024 11:45:32 +0530, Vijendar Mukunda wrote:
> Currently different logics being used in the code for acp version
> differentiation. This patch series refactors the code to use acp pci
> revision id for handling acp version specific code.
> 
> Vijendar Mukunda (8):
>   ASoC: amd: acp: simplify platform conditional checks code
>   ASoC: amd: acp: use acp_rev for platform specific conditional checks
>   ASoC: amd: acp: use acp pci revision id for platform differntiation
>   ASoC: amd: acp: store acp pci rev id in platform driver private
>     structure
>   ASoC: amd: acp: pass acp pci revision id as platform data
>   ASoC: amd: acp: remove unused variable from acp_card_drvdata structure
>   ASoC: amd: acp: replace adata->platform conditional check
>   ASoC: amd: acp: remove unused variable from acp platform driver
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: amd: acp: simplify platform conditional checks code
      commit: 839a8b18dbd2e2345a261169fb68d950a1071862
[2/8] ASoC: amd: acp: use acp_rev for platform specific conditional checks
      commit: fca471b5d094dabd65f6d8777096e9ed1df1bef7
[3/8] ASoC: amd: acp: use acp pci revision id for platform differntiation
      commit: 5dbf8a19fe5d5a4c764ba88d171b06704354296a
[4/8] ASoC: amd: acp: store acp pci rev id in platform driver private structure
      commit: 40412a298c77eaa4a22a1aa7030bcc0b2e02c618
[5/8] ASoC: amd: acp: pass acp pci revision id as platform data
      commit: 0eae2c96b49d85b31ab635b9dc6f09b09d3c54de
[6/8] ASoC: amd: acp: remove unused variable from acp_card_drvdata structure
      commit: 2e609185e174a9ffd462ab125085ddfcbe9e2f4d
[7/8] ASoC: amd: acp: replace adata->platform conditional check
      commit: b33d93990e3774a24575517c6fcc2167036672d1
[8/8] ASoC: amd: acp: remove unused variable from acp platform driver
      commit: 9864c8af89eb14a2e5334f8e24bb82086182e894

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark