From patchwork Tue Jun 6 09:38:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 690568 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE861C77B73 for ; Tue, 6 Jun 2023 09:40:14 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E6117823; Tue, 6 Jun 2023 11:39:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E6117823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686044412; bh=Rq9AaRXDuRlWUf2x4+tGhBdxhm+biBK0j+Myd4nW8tQ=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=tb7nZ70cYXFyjiWnQJII8g5m9Bgbrtiqrhg/+23cF2eNEPcFNylHniAnm/hAJgpom 7lMhdyNCwXaitwsmv3ZkjKuWvBFVQT4+oFBtjR3oGLmYwA7iEHL2FoG7kZkUYJ5QbN +6EFaeqmOMkGBYHi7FXMApaGnr2TKLf9OeEWA+WE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2BA03F80527; Tue, 6 Jun 2023 11:39:11 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 33334F80199; Tue, 6 Jun 2023 11:39:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A2BB5F804DA; Tue, 6 Jun 2023 11:39:05 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1963DF80155 for ; Tue, 6 Jun 2023 11:38:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1963DF80155 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=OKFyEHeN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yPmjwlHK Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 58C821FD63; Tue, 6 Jun 2023 09:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686044339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5aAHWP2Z3Pd28CxD0s43v2ci0A56RSIhk2O7M/CsCb4=; b=OKFyEHeNm4lUyxXZ34/0Vwb+yVjoEDETUC4dtC0V6lVJ23kSKfQJXepJalO0rOfxKIcqTB Gjz34/XIAFzykcmdv4tEbjruzdnOHur4IbJQYQbacr6NYVxPLf4RInpD6SLVlqgSOaBSPs ASRYiZeXZAQvwJdk0deVqPizRbjUwG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686044339; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5aAHWP2Z3Pd28CxD0s43v2ci0A56RSIhk2O7M/CsCb4=; b=yPmjwlHKnNOHKbz8gi+GZ/hMF72vULJn6srtdkn8BbyTfCtMPqicLMB0iiguVn9ALHcOEB 057HWweTMVLKr/BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2DB3E13519; Tue, 6 Jun 2023 09:38:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2gRjCbP+fmTiVwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 09:38:59 +0000 From: Takashi Iwai To: alsa-devel@alsa-project.org Cc: Jaroslav Kysela Subject: [PATCH 0/4] ALSA: Fix kctl->id initialization Date: Tue, 6 Jun 2023 11:38:51 +0200 Message-Id: <20230606093855.14685-1-tiwai@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Message-ID-Hash: D3ISOKPAWF5WILY5BWFALFCDJWHRZFSI X-Message-ID-Hash: D3ISOKPAWF5WILY5BWFALFCDJWHRZFSI X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Inspired by the recent Jaroslav's fix patch, I skimmed over the tree and found that there are a few other similar bugs. Here is a patch set to address them. Most of them are just shuffling the call order, while the one in HD-audio is changed to use snd_ctl_replace_id() helper. Takashi === Takashi Iwai (4): ALSA: ymfpci: Fix kctl->id initialization ALSA: cmipci: Fix kctl->id initialization ALSA: gus: Fix kctl->id initialization ALSA: hda: Fix kctl->id initialization sound/isa/gus/gus_pcm.c | 2 +- sound/pci/cmipci.c | 6 +++--- sound/pci/hda/hda_codec.c | 6 +++++- sound/pci/ymfpci/ymfpci_main.c | 6 +++--- 4 files changed, 12 insertions(+), 8 deletions(-)