mbox series

[0/3] ASoC: Intel/SOF: simplify S3 resume flows

Message ID 20221017204946.207986-1-pierre-louis.bossart@linux.intel.com
Headers show
Series ASoC: Intel/SOF: simplify S3 resume flows | expand

Message

Pierre-Louis Bossart Oct. 17, 2022, 8:49 p.m. UTC 
All Intel drivers for cAVS platforms contain a sequence for S3 resume
which doesn't seem justified nor necessary. Forensic Git investigation
in internal repositories did not provide any rationale for the
implementation, and tests show no impact when those sequences are
removed.

This sequence was identified as problematic during a large HDaudio
cleanup where all programming sequences were revisited before
extensions are added.

Pierre-Louis Bossart (3):
  ASoC: Intel: Skylake: simplify S3 resume flows
  ASoC: Intel: avs: simplify S3 resume flows
  ASoC: SOF: Intel: hda-dsp: simplify S3 resume flows

 sound/soc/intel/avs/core.c    | 11 -----------
 sound/soc/intel/skylake/skl.c |  9 ---------
 sound/soc/sof/intel/hda-dsp.c | 14 --------------
 3 files changed, 34 deletions(-)

Comments

Cezary Rojewski Oct. 18, 2022, 4:15 p.m. UTC | #1 
On 2022-10-17 10:49 PM, Pierre-Louis Bossart wrote:
> All Intel drivers for cAVS platforms contain a sequence for S3 resume
> which doesn't seem justified nor necessary. Forensic Git investigation
> in internal repositories did not provide any rationale for the
> implementation, and tests show no impact when those sequences are
> removed.
> 
> This sequence was identified as problematic during a large HDaudio
> cleanup where all programming sequences were revisited before
> extensions are added.

This is a good finding as discussed earlier in the review.
Tested-by is already there by the series-wide reviewed-by won't hurt:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>