mbox series

[0/2] Untested TAS2562 power setting fixes

Message ID 20220825142226.80929-1-povik+lin@cutebit.org
Headers show
Series Untested TAS2562 power setting fixes | expand

Message

Martin Povišer Aug. 25, 2022, 2:22 p.m. UTC 
The tas2562 driver does the same thing with the setting of PWR_CTRL
field as the tas2764/tas2770 drivers were doing.
Link: https://lore.kernel.org/alsa-devel/20220808141246.5749-1-povik+lin@cutebit.org/T/#t
Link: https://lore.kernel.org/alsa-devel/20220825140241.53963-1-povik+lin@cutebit.org/T/#t

These are blindly written patches without testing since I don't have
the hardware. (I even tried TI's formal sample request program but
was refused there. CCing @ti.com addresses I found on other series
recently submitted.)

Martin Povišer (2):
  ASoC: tas2562: Drop conflicting set_bias_level power setting
  ASoC: tas2562: Fix mute/unmute

 sound/soc/codecs/tas2562.c | 90 ++++++++++++--------------------------
 1 file changed, 29 insertions(+), 61 deletions(-)

Comments

Mark Brown Sept. 5, 2022, 3:38 p.m. UTC | #1 
On Thu, 25 Aug 2022 16:22:24 +0200, Martin Povišer wrote:
> The tas2562 driver does the same thing with the setting of PWR_CTRL
> field as the tas2764/tas2770 drivers were doing.
> Link: https://lore.kernel.org/alsa-devel/20220808141246.5749-1-povik+lin@cutebit.org/T/#t
> Link: https://lore.kernel.org/alsa-devel/20220825140241.53963-1-povik+lin@cutebit.org/T/#t
> 
> These are blindly written patches without testing since I don't have
> the hardware. (I even tried TI's formal sample request program but
> was refused there. CCing @ti.com addresses I found on other series
> recently submitted.)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: tas2562: Drop conflicting set_bias_level power setting
      commit: b6b55b232564ade5cd91e9b9e2228b49f230d67f
[2/2] ASoC: tas2562: Fix mute/unmute
      commit: 2848d34c3ba1fc6f1ece0736a4faa16c6277f4d3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Martin Povišer Sept. 5, 2022, 3:45 p.m. UTC | #2 
> On 5. 9. 2022, at 17:38, Mark Brown <broonie@kernel.org> wrote:
> 
> On Thu, 25 Aug 2022 16:22:24 +0200, Martin Povišer wrote:
>> The tas2562 driver does the same thing with the setting of PWR_CTRL
>> field as the tas2764/tas2770 drivers were doing.
>> Link: https://lore.kernel.org/alsa-devel/20220808141246.5749-1-povik+lin@cutebit.org/T/#t
>> Link: https://lore.kernel.org/alsa-devel/20220825140241.53963-1-povik+lin@cutebit.org/T/#t
>> 
>> These are blindly written patches without testing since I don't have
>> the hardware. (I even tried TI's formal sample request program but
>> was refused there. CCing @ti.com addresses I found on other series
>> recently submitted.)
>> 
>> [...]
> 
> Applied to
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!

Texas Instruments is shipping me samples of the affected
codecs, so I should be able to test the changes on hardware soon.

Should I find regressions, I will report back.

Martin
Mark Brown Sept. 5, 2022, 4:42 p.m. UTC | #3 
On Mon, Sep 05, 2022 at 05:45:09PM +0200, Martin Povišer wrote:

> Texas Instruments is shipping me samples of the affected
> codecs, so I should be able to test the changes on hardware soon.

> Should I find regressions, I will report back.

Ah, that's great news.