| Message ID | 20220427150720.9194-1-vitalyr@opensource.cirrus.com |
|---|---|
| Headers | show |
| Series | ALSA: hda: cirrus: Add initial DSP support and firmware loading | expand |
Hi Mark, Takashi On 09/05/2022 12:21 pm, Mark Brown wrote: > On Mon, May 09, 2022 at 10:55:35AM +0200, Takashi Iwai wrote: >> Mark Brown wrote: >>> On Wed, Apr 27, 2022 at 04:06:54PM +0100, Vitaly Rodionov wrote: >>>> The CS35L41 Amplifier contains a DSP, capable of running firmware. >>>> The firmware can run algorithms such as Speaker Protection, to ensure >>>> that playback at high gains do not harm the speakers. >>>> Adding support for CS35L41 firmware into the CS35L41 HDA driver also >>>> allows us to support several extra features, such as hiberation >>>> and interrupts. >>> There's a bunch of changes for this driver in the ASoC tree, it looks >>> like the bits that touch ASoC will need basing off those. >> How is the situation for the time being? >> I've been off in the last weeks, so couldn't follow the whole >> thread. > No change, Vitaly didn't update or respond as far as I remember. We'll > need a new version. Sorry for delay, yes we have re-based version, I will send again. Thanks, Vitaly
On Wed, 27 Apr 2022 16:06:54 +0100, Vitaly Rodionov wrote: > The CS35L41 Amplifier contains a DSP, capable of running firmware. > The firmware can run algorithms such as Speaker Protection, to ensure > that playback at high gains do not harm the speakers. > Adding support for CS35L41 firmware into the CS35L41 HDA driver also > allows us to support several extra features, such as hiberation > and interrupts. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [06/26] ASoC: cs35l41: Move cs35l41_set_cspl_mbox_cmd to shared code (no commit info) [07/26] ASoC: cs35l41: Move cs35l41 fs errata into shared code (no commit info) [08/26] ASoC: cs35l41: Move cs_dsp config struct into shared code (no commit info) [18/26] ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code commit: 94e0bc317ad241c022a6bb311b3a28b4d51ea8b6 [20/26] ASoC: cs35l41: Add common cs35l41 enter hibernate function commit: e341efc308e5374ded6b471f9e1ec01450bcc93e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
The CS35L41 Amplifier contains a DSP, capable of running firmware. The firmware can run algorithms such as Speaker Protection, to ensure that playback at high gains do not harm the speakers. Adding support for CS35L41 firmware into the CS35L41 HDA driver also allows us to support several extra features, such as hiberation and interrupts. The chain adds support in stages: - General fixes to improve generalization and code re-use inside the CS35L41 HDA driver. - Add support for interrupts into the driver, which is required for complete support of the firmware. - Refactor ASoC CS35L41 code which deals with firmware to allow for code re-use inside the CS35L41 HDA driver. - Add support for loading firmware and tuning files from file system, and creating alsa controls to control it. - Support firmware load paths for different hardware systems. - Support suspend/resume in the driver when using firmware. The firmware supports hibernation, which allows the CS35L41 to drop into a low power mode during suspend. - Support the ability to unload firmware, swap and reload the firmware. This is to allow different firmware to run during calibration. The intended use-case is to load the firmware once on boot, and the driver autmatically tries to load the firmware after it binds to the HDA driver. This behaviour can be switched off using a kconfig, if desired. Stefan Binding (25): ALSA: hda: cs35l41: Fix error in spi cs35l41 hda driver name ALSA: hda: cs35l41: Set Speaker Position for CLSA0100 Laptop ALSA: hda: cs35l41: Remove Set Channel Map api from binding ALSA: hda: cs35l41: Add Support for Interrupts ALSA: hda: cs35l41: Enable GPIO2 Interrupt for CLSA0100 laptops ASoC: cs35l41: Move cs35l41_set_cspl_mbox_cmd to shared code ASoC: cs35l41: Move cs35l41 fs errata into shared code ASoC: cs35l41: Move cs_dsp config struct into shared code ALSA: hda: cs35l41: Add Amp Name based on channel and index ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly ALSA: hda: cs35l41: Save codec object inside component struct ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver ALSA: hda: cs35l41: Support reading subsystem id from ACPI ALSA: hda: cs35l41: Support multiple load paths for firmware ALSA: hda: cs35l41: Support Speaker ID for laptops ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code ALSA: cs35l41: Do not print error when waking from hibernation ASoC: cs35l41: Add common cs35l41 enter hibernate function ALSA: hda: cs35l41: Support Hibernation during Suspend ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables ALSA: hda: hda_cs_dsp_ctl: Add fw id strings ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence ALSA: hda: cs35l41: Support Firmware switching and reloading ALSA: hda: cs35l41: Add kernel config to disable firmware autoload Vitaly Rodionov (1): ALSA: hda: cs35l41: Add initial DSP support and firmware loading MAINTAINERS | 1 + include/sound/cs35l41.h | 84 +++ sound/pci/hda/Kconfig | 17 + sound/pci/hda/Makefile | 2 + sound/pci/hda/cs35l41_hda.c | 954 +++++++++++++++++++++++++++++++- sound/pci/hda/cs35l41_hda.h | 41 ++ sound/pci/hda/cs35l41_hda_i2c.c | 1 + sound/pci/hda/cs35l41_hda_spi.c | 3 +- sound/pci/hda/hda_component.h | 6 +- sound/pci/hda/hda_cs_dsp_ctl.c | 424 ++++++++++++++ sound/pci/hda/hda_cs_dsp_ctl.h | 40 ++ sound/pci/hda/patch_realtek.c | 81 +-- sound/soc/codecs/cs35l41-lib.c | 193 +++++++ sound/soc/codecs/cs35l41.c | 186 +------ sound/soc/codecs/cs35l41.h | 18 - 15 files changed, 1797 insertions(+), 254 deletions(-) create mode 100644 sound/pci/hda/hda_cs_dsp_ctl.c create mode 100644 sound/pci/hda/hda_cs_dsp_ctl.h