mbox series

[v2,0/4] ASoC: SOF: Intel: DMI L1 power optimization for HDaudio platforms

Message ID 20210812231940.172547-1-pierre-louis.bossart@linux.intel.com
Headers show
Series ASoC: SOF: Intel: DMI L1 power optimization for HDaudio platforms | expand

Message

Pierre-Louis Bossart Aug. 12, 2021, 11:19 p.m. UTC 
This patchset provides an optimization that result in significant power
savings on Intel HDAudio platforms using SOF (Sound Open Firmware).

We previously prevented the Intel DSP from enabling the DMI_L1
capability to work-around issues with pause on capture streams. It
turns out that this also prevented the platform from entering high C
states in full-duplex usages such as videoconferencing - a rather
basic use case since the start of the pandemic.

The support for pause_push/release was already a bit controversial for
Intel platforms, in theory platforms should only enable PAUSE if they
can resume on the same sample, which is not the case on any Intel
platform.

With this patchset, when the user enables DMI L1 via a kernel
parameter, the PAUSE support is disabled for capture streams. A kernel
parameter is far from ideal but it's a placeholder until we have an
API to negotiate capabilities between applications and driver, and
it's far less confusing than a Kconfig option.

Changes since v1:
Removal of SPIB support since it may conflict with Takashi's memalloc
changes. These SPIB changes will be provided after rebase.
Addition of one cleanup for cppcheck warning
Move all changes to intel/ directory, no changes in shared code
Flipped the logic: the selection of DMI L1 disables PAUSE

Pierre-Louis Bossart (4):
  ASoC: SOF: Intel: Kconfig: clarify DMI L1 option description
  ASoC: SOF: Intel: hda-stream: remove always true condition
  ASoC: SOF: Intel: simplify logic for DMI_L1 handling
  ASoC: SOF: Intel: make DMI L1 selection more robust

 sound/soc/sof/intel/Kconfig      | 10 ----------
 sound/soc/sof/intel/hda-pcm.c    | 16 ++++++++++++++--
 sound/soc/sof/intel/hda-stream.c | 11 +++++------
 3 files changed, 19 insertions(+), 18 deletions(-)

Comments

Mark Brown Aug. 13, 2021, 5:26 p.m. UTC | #1 
On Thu, 12 Aug 2021 18:19:36 -0500, Pierre-Louis Bossart wrote:
> This patchset provides an optimization that result in significant power
> savings on Intel HDAudio platforms using SOF (Sound Open Firmware).
> 
> We previously prevented the Intel DSP from enabling the DMI_L1
> capability to work-around issues with pause on capture streams. It
> turns out that this also prevented the platform from entering high C
> states in full-duplex usages such as videoconferencing - a rather
> basic use case since the start of the pandemic.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: SOF: Intel: Kconfig: clarify DMI L1 option description
      commit: 6f28c883b7ba8c611a842b4701eb4fb8bd76b70b
[2/4] ASoC: SOF: Intel: hda-stream: remove always true condition
      commit: d2556edadbf2929dd7b04de59daeb0a571dc0349
[3/4] ASoC: SOF: Intel: simplify logic for DMI_L1 handling
      commit: 5503e938fef3f66240670d28f7d5db7f2dc8f35a
[4/4] ASoC: SOF: Intel: make DMI L1 selection more robust
      commit: 246dd4287dfbaaddc1511c744893621814618bc8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark