mbox series

[RESEND,V2,00/12] Add Vangogh ACP ASoC driver

Message ID 20210717040059.310410-1-Vijendar.Mukunda@amd.com
Headers show
Series Add Vangogh ACP ASoC driver | expand

Message

Vijendar Mukunda July 17, 2021, 4 a.m. UTC
This adds an ASoC driver for the ACP (Audio CoProcessor)
block on AMD Vangogh APU.

Vijendar Mukunda (12):
  ASoC: amd: add Vangogh ACP5x IP register header
  ASoC: amd: add Vangogh ACP PCI driver
  ASoc: amd: add acp5x init/de-init functions
  ASoC: amd: create acp5x platform devices
  ASoC: amd: add ACP5x PCM platform driver
  ASoC: amd: irq handler changes for ACP5x PCM dma driver
  ASoC: amd: add ACP5x pcm dma driver ops
  ASoC: amd: add vangogh i2s controller driver
  ASoC: amd: add vangogh i2s dai driver ops
  ASoC: amd: add vangogh pci driver pm ops
  ASoC: amd: add vangogh i2s dma driver pm ops
  ASoC: amd: enable vangogh acp5x driver build
---
v1 -> v2: fixed review comments
---
 sound/soc/amd/Kconfig                       |   9 +
 sound/soc/amd/Makefile                      |   1 +
 sound/soc/amd/vangogh/Makefile              |   9 +
 sound/soc/amd/vangogh/acp5x-i2s.c           | 429 ++++++++++++++++
 sound/soc/amd/vangogh/acp5x-pcm-dma.c       | 525 ++++++++++++++++++++
 sound/soc/amd/vangogh/acp5x.h               | 192 +++++++
 sound/soc/amd/vangogh/pci-acp5x.c           | 327 ++++++++++++
 sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++
 8 files changed, 1829 insertions(+)
 create mode 100644 sound/soc/amd/vangogh/Makefile
 create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c
 create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
 create mode 100644 sound/soc/amd/vangogh/acp5x.h
 create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c
 create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h

Comments

Pierre-Louis Bossart July 16, 2021, 7:52 p.m. UTC | #1
On 7/16/21 11:00 PM, Vijendar Mukunda wrote:
> This adds an ASoC driver for the ACP (Audio CoProcessor)
> block on AMD Vangogh APU.
> 
> Vijendar Mukunda (12):
>   ASoC: amd: add Vangogh ACP5x IP register header
>   ASoC: amd: add Vangogh ACP PCI driver
>   ASoc: amd: add acp5x init/de-init functions
>   ASoC: amd: create acp5x platform devices
>   ASoC: amd: add ACP5x PCM platform driver
>   ASoC: amd: irq handler changes for ACP5x PCM dma driver
>   ASoC: amd: add ACP5x pcm dma driver ops
>   ASoC: amd: add vangogh i2s controller driver
>   ASoC: amd: add vangogh i2s dai driver ops
>   ASoC: amd: add vangogh pci driver pm ops
>   ASoC: amd: add vangogh i2s dma driver pm ops
>   ASoC: amd: enable vangogh acp5x driver build
> ---
> v1 -> v2: fixed review comments

usually the version number is at the patchset level, here you included v1, v2 and v3 patches and all but the last one use the RESEND prefix?

is this intentional?

> ---
>  sound/soc/amd/Kconfig                       |   9 +
>  sound/soc/amd/Makefile                      |   1 +
>  sound/soc/amd/vangogh/Makefile              |   9 +
>  sound/soc/amd/vangogh/acp5x-i2s.c           | 429 ++++++++++++++++
>  sound/soc/amd/vangogh/acp5x-pcm-dma.c       | 525 ++++++++++++++++++++
>  sound/soc/amd/vangogh/acp5x.h               | 192 +++++++
>  sound/soc/amd/vangogh/pci-acp5x.c           | 327 ++++++++++++
>  sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++
>  8 files changed, 1829 insertions(+)
>  create mode 100644 sound/soc/amd/vangogh/Makefile
>  create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c
>  create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
>  create mode 100644 sound/soc/amd/vangogh/acp5x.h
>  create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c
>  create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h
>
Mark Brown July 19, 2021, 11:56 a.m. UTC | #2
On Sat, Jul 17, 2021 at 10:04:15AM +0530, Mukunda,Vijendar wrote:
> On 7/17/21 1:22 AM, Pierre-Louis Bossart wrote:

> > usually the version number is at the patchset level, here you included v1, v2 and v3 patches and all but the last one use the RESEND prefix?
> > 
> > is this intentional?

> As We have respin the patch series, we have updated cover letter with
> version as V2.
> Got your point. Cover letter shouldn't have any version number.

> We have updated patches as v2 version with fixes.

> It's my bad. For last patch, We have removed extra stuff which we have
> added earlier and marked patch version as V3.

No, you haven't got his point - his point is that everything in the
series (including the cover letter) should have the same version.
Vijendar Mukunda July 19, 2021, 3:10 p.m. UTC | #3
On 7/19/21 5:26 PM, Mark Brown wrote:
> On Sat, Jul 17, 2021 at 10:04:15AM +0530, Mukunda,Vijendar wrote:
>> On 7/17/21 1:22 AM, Pierre-Louis Bossart wrote:
> 
>>> usually the version number is at the patchset level, here you included v1, v2 and v3 patches and all but the last one use the RESEND prefix?
>>>
>>> is this intentional?
> 
>> As We have respin the patch series, we have updated cover letter with
>> version as V2.
>> Got your point. Cover letter shouldn't have any version number.
> 
>> We have updated patches as v2 version with fixes.
> 
>> It's my bad. For last patch, We have removed extra stuff which we have
>> added earlier and marked patch version as V3.
> 
> No, you haven't got his point - his point is that everything in the
> series (including the cover letter) should have the same version.
> 
Will re-spin the patch set as v3 including cover letter and post it