mbox series

[0/6] ALSA: firewire-lib: code refactoring for processing rx packets

Message ID 20210522013303.49596-1-o-takashi@sakamocchi.jp
Headers show
Series ALSA: firewire-lib: code refactoring for processing rx packets | expand

Message

Takashi Sakamoto May 22, 2021, 1:32 a.m. UTC
Hi,

This patchset refactors mainly for processing rx packets.

Except for devices handled by ALSA bebob and dice drivers, the devices
doesn't take care of the value of syt field of CIP header for playback
timing. To code it explicitly, the new flag is added in 1st patch.

Some of devices based on DICE ASICs supports two pairs of packet
streams. In the case, the sequence of rx packet in the streams should
be different independently so that each of them deliver timing
information from each peer. On the other hand, current implementation
pools the sequence in AMDTP domain, then the rx packets are processed
with the same pool. It is inconvenient and in 2nd patch the pool is
prepared per streams.

The other patches are for my future work.


Regards

Takashi Sakamoto (6):
  ALSA: firewire-lib: add flag to unaware of syt in CIP header
  ALSA: firewire-lib: pool sequence of packet in IT context
    independently
  ALSA: firewire-lib: code refactoring for generation of packet
    descriptors
  ALSA: firewire-lib: code refactoring for generation of syt sequence
  ALSA: firewire-lib: code refactoring for generation of data block
    sequence
  ALSA: firewire-lib: code refactoring for transfer delay

 sound/firewire/amdtp-stream.c        | 267 +++++++++++++--------------
 sound/firewire/amdtp-stream.h        |  33 ++--
 sound/firewire/motu/amdtp-motu.c     |   4 +-
 sound/firewire/tascam/amdtp-tascam.c |   6 +-
 4 files changed, 146 insertions(+), 164 deletions(-)

Comments

Takashi Iwai May 22, 2021, 6:50 a.m. UTC | #1
On Sat, 22 May 2021 03:32:57 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> This patchset refactors mainly for processing rx packets.
> 
> Except for devices handled by ALSA bebob and dice drivers, the devices
> doesn't take care of the value of syt field of CIP header for playback
> timing. To code it explicitly, the new flag is added in 1st patch.
> 
> Some of devices based on DICE ASICs supports two pairs of packet
> streams. In the case, the sequence of rx packet in the streams should
> be different independently so that each of them deliver timing
> information from each peer. On the other hand, current implementation
> pools the sequence in AMDTP domain, then the rx packets are processed
> with the same pool. It is inconvenient and in 2nd patch the pool is
> prepared per streams.
> 
> The other patches are for my future work.
> 
> 
> Regards
> 
> Takashi Sakamoto (6):
>   ALSA: firewire-lib: add flag to unaware of syt in CIP header
>   ALSA: firewire-lib: pool sequence of packet in IT context
>     independently
>   ALSA: firewire-lib: code refactoring for generation of packet
>     descriptors
>   ALSA: firewire-lib: code refactoring for generation of syt sequence
>   ALSA: firewire-lib: code refactoring for generation of data block
>     sequence
>   ALSA: firewire-lib: code refactoring for transfer delay

Thanks, applied all six patches now.


Takashi